Skip to content

[SideNav] (Simpler) Apply blur only when keyboard navigating #238589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dosant wants to merge 1 commit into from
Closed

[SideNav] (Simpler) Apply blur only when keyboard navigating #238589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/core/packages/chrome/navigation/src/components/popover/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ import {
*/
let anyPopoverOpen: boolean = false;

// Track if the keyboard was used to decide if we should close the popover on blur
let wasKeyboardUsed = false;
window.addEventListener('keydown', () => {
wasKeyboardUsed = true;
});
window.addEventListener('mousedown', () => {
wasKeyboardUsed = false;
});

/**
* Utility function to check if any popover is open.
*
Expand Down Expand Up @@ -185,6 +194,8 @@ export const SideNavPopover = ({

const handleBlur: FocusEventHandler = useCallback(
(e) => {
if (!wasKeyboardUsed) return;

clearTimeout();

const nextFocused = e.relatedTarget;
Expand Down