Skip to content

[Vega] add object normalization#238503

Merged
markov00 merged 4 commits intoelastic:mainfrom
markov00:2025_10_10-fix_object_normalization
Oct 22, 2025
Merged

[Vega] add object normalization#238503
markov00 merged 4 commits intoelastic:mainfrom
markov00:2025_10_10-fix_object_normalization

Conversation

@markov00
Copy link
Copy Markdown
Contributor

@markov00 markov00 commented Oct 10, 2025 •
edited by kibanamachine
Loading

Summary

Add object normalization to Vega warning/error messages

@markov00 markov00 force-pushed the 2025_10_10-fix_object_normalization branch from d7d3ccb to 05e17e2 Compare October 13, 2025 09:33
@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes labels Oct 13, 2025
@markov00 markov00 marked this pull request as ready for review October 13, 2025 12:29
@markov00 markov00 requested a review from a team as a code owner October 13, 2025 12:29
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 13, 2025

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@markov00 markov00 self-assigned this Oct 13, 2025
dej611
dej611 reviewed Oct 13, 2025
View reviewed changes
src/platform/plugins/private/vis_types/vega/public/data_model/utils.ts
error = error.message;
}
static formatErrorToStr(...args: unknown[]) {
const error: string = args[0] instanceof Error ? args[0].message : 'Error';
Copy link
Copy Markdown
Contributor

@dej611 dej611 Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it include cause too if available?

Copy link
Copy Markdown
Contributor Author

@markov00 markov00 Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually following what was the previous logic. What do you believe we should do with this case? just concatenate the message and the cause together?

Copy link
Copy Markdown
Contributor

@dej611 dej611 Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be nice. Not a blocker, but would be nice to have.

dej611
dej611 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only

@elastic elastic deleted a comment from elasticmachine Oct 14, 2025
@markov00 markov00 merged commit 4d51ac8 into elastic:main Oct 22, 2025
13 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 22, 2025

Starting backport for target branches: 8.19, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/18709099674

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 22, 2025
@markov00
[Vega] add object normalization (elastic#238503)
6cda650 
## Summary

Add object normalization to Vega warning/error messages

(cherry picked from commit 4d51ac8)
@kibanamachine kibanamachine mentioned this pull request Oct 22, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 22, 2025
@markov00
[Vega] add object normalization (elastic#238503)
7f12dfd 
## Summary

Add object normalization to Vega warning/error messages

(cherry picked from commit 4d51ac8)
@kibanamachine kibanamachine mentioned this pull request Oct 22, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 22, 2025
@markov00
[Vega] add object normalization (elastic#238503)
8aa638e 
## Summary

Add object normalization to Vega warning/error messages

(cherry picked from commit 4d51ac8)
@kibanamachine kibanamachine mentioned this pull request Oct 22, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 22, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19
✅ 9.1
✅ 9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 22, 2025
@kibanamachine @markov00
[8.19] [Vega] add object normalization (#238503) (#240015)
7fc9504 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[Vega] add object normalization
(#238503)](#238503)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-10-22T07:44:33Z","message":"[Vega]
add object normalization (#238503)\n\n## Summary\n\nAdd object
normalization to Vega warning/error
messages","sha":"4d51ac82208dde420739bcc9ffb0c762e6192d20","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","ci:build-os-packages","backport:all-open","v9.3.0"],"title":"[Vega]
add object
normalization","number":238503,"url":"https://github.com/elastic/kibana/pull/238503","mergeCommit":{"message":"[Vega]
add object normalization (#238503)\n\n## Summary\n\nAdd object
normalization to Vega warning/error
messages","sha":"4d51ac82208dde420739bcc9ffb0c762e6192d20"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238503","number":238503,"mergeCommit":{"message":"[Vega]
add object normalization (#238503)\n\n## Summary\n\nAdd object
normalization to Vega warning/error
messages","sha":"4d51ac82208dde420739bcc9ffb0c762e6192d20"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
@kibanamachine kibanamachine mentioned this pull request Oct 22, 2025
Merged
kibanamachine added a commit that referenced this pull request Oct 23, 2025
@kibanamachine @markov00
[9.2] [Vega] add object normalization (#238503) (#240017)
48bbea9 
# Backport

This will backport the following commits from `main` to `9.2`:
- [[Vega] add object normalization
(#238503)](#238503)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-10-22T07:44:33Z","message":"[Vega]
add object normalization (#238503)\n\n## Summary\n\nAdd object
normalization to Vega warning/error
messages","sha":"4d51ac82208dde420739bcc9ffb0c762e6192d20","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","ci:build-os-packages","backport:all-open","v9.3.0"],"title":"[Vega]
add object
normalization","number":238503,"url":"https://github.com/elastic/kibana/pull/238503","mergeCommit":{"message":"[Vega]
add object normalization (#238503)\n\n## Summary\n\nAdd object
normalization to Vega warning/error
messages","sha":"4d51ac82208dde420739bcc9ffb0c762e6192d20"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238503","number":238503,"mergeCommit":{"message":"[Vega]
add object normalization (#238503)\n\n## Summary\n\nAdd object
normalization to Vega warning/error
messages","sha":"4d51ac82208dde420739bcc9ffb0c762e6192d20"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 23, 2025
@kibanamachine @markov00
[9.1] [Vega] add object normalization (#238503) (#240016)
59582b8 
# Backport

This will backport the following commits from `main` to `9.1`:
- [[Vega] add object normalization
(#238503)](#238503)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-10-22T07:44:33Z","message":"[Vega]
add object normalization (#238503)\n\n## Summary\n\nAdd object
normalization to Vega warning/error
messages","sha":"4d51ac82208dde420739bcc9ffb0c762e6192d20","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","ci:build-os-packages","backport:all-open","v9.3.0"],"title":"[Vega]
add object
normalization","number":238503,"url":"https://github.com/elastic/kibana/pull/238503","mergeCommit":{"message":"[Vega]
add object normalization (#238503)\n\n## Summary\n\nAdd object
normalization to Vega warning/error
messages","sha":"4d51ac82208dde420739bcc9ffb0c762e6192d20"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238503","number":238503,"mergeCommit":{"message":"[Vega]
add object normalization (#238503)\n\n## Summary\n\nAdd object
normalization to Vega warning/error
messages","sha":"4d51ac82208dde420739bcc9ffb0c762e6192d20"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Oct 27, 2025
@markov00 @NicholasPeretti
[Vega] add object normalization (elastic#238503)
5e006f5 
## Summary

Add object normalization to Vega warning/error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dej611 dej611 dej611 approved these changes

Assignees

@markov00 markov00

Labels

backport:all-open Backport to all branches that could still receive a release bug Fixes for quality problems that affect the customer experience ci:build-os-packages release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.19.7 v9.1.7 v9.2.1 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@markov00 @elasticmachine @kibanamachine @dej611 @mistic @jeramysoucy