[Search][Accessibility] Announce changes when resetting terms in synonyms panel #237877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seialkali
added
release_note:fix
Team:Search
backport:version
seialkali
force-pushed
the
fix/announce-reset-changes-synonym-panel
branch
from
099de11 to
91e1246
Compare
wildemat
approved these changes
Oct 8, 2025
...earch/plugins/search_synonyms/public/components/synonyms_rule_flyout/synonym_rule_flyout.tsx
Show resolved
Hide resolved
Contributor
|
There's a new announcement component that's in beta right now: https://eui.elastic.co/docs/utilities/accessibility/#live-announcer-region- Doesn't really apply to this change because we don't render anything like an Error callout when these clear/reset buttons are pressed. But it's worth knowing about for future a11y tickets. |
seialkali
force-pushed
the
fix/announce-reset-changes-synonym-panel
branch
from
91e1246 to
3fab9ba
Compare
Contributor
|
“Add an announcement for the Remove all button too?”
“Move focus back to the top after Reset/Remove all?”
That should help. Thanks! |
seialkali
force-pushed
the
fix/announce-reset-changes-synonym-panel
branch
from
28f0150 to
d0eef9f
Compare
seialkali
force-pushed
the
fix/announce-reset-changes-synonym-panel
branch
from
d0eef9f to
d394484
Compare
seialkali
added
v8.19.6
backport:all-open
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1, 9.2 https://github.com/elastic/kibana/actions/runs/18404821482 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2025
…nyms panel (elastic#237877) ## Summary Currently, when a user clicks `Reset changes` or `Remove all` on the Add Terms panel (for either equivalent or explicit types) in the Synonyms set editor, the terms are reset visually but the change is not announced by VoiceOver on macOS Safari. This breaks WCAG 4.1.2: Name, Role, Value (Level A). This PR updates the Add Terms panel to use `aria-live="polite"` announcements when either buttons are clicked, so screen readers can inform users of the change. ### How to test 1. Enable VoiceOver on macOS (Cmd + F5). 2. Open Kibana and navigate to **Search → Synonyms**. 3. Create a new synonyms set and select either "equivalent" or "explicit" rule. 4. Add terms and click "Reset changes". 5. Confirm that VoiceOver announces that the terms have been reset. 6. Add terms and click "Remove all". 5. Confirm that VoiceOver announces that the terms have been removed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Note Fixes an accessibility issue where resetting changes or removing all terms in the Synonyms panel was not announced by screen readers. VoiceOver users on Safari will now hear updates when terms are reset. (cherry picked from commit 9e7e748)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
alexwizp
reviewed
Oct 10, 2025
| <EuiFlexItem grow={false}> | ||
| <EuiButtonEmpty | ||
| data-test-subj="searchSynonymsSynonymsRuleFlyoutResetChangesButton" | ||
| aria-label={i18n.translate( |
Contributor
There was a problem hiding this comment.
@seialkali @wildemat — just a note for future reference: there’s no need to set an explicit aria-label on EuiButtonEmpty.
This was an issue we introduced in the ESLint rule, and it’s already been fixed in elastic/eui#9046
.
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2025
…n synonyms panel (#237877) (#238420) # Backport This will backport the following commits from `main` to `9.2`: - [[Search][Accessibility] Announce changes when resetting terms in synonyms panel (#237877)](#237877) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Brittany","email":"seialkali@gmail.com"},"sourceCommit":{"committedDate":"2025-10-10T11:13:41Z","message":"[Search][Accessibility] Announce changes when resetting terms in synonyms panel (#237877)\n\n## Summary\nCurrently, when a user clicks `Reset changes` or `Remove all` on the Add\nTerms panel (for either equivalent or explicit types) in the Synonyms\nset editor, the terms are reset visually but the change is not announced\nby VoiceOver on macOS Safari. This breaks WCAG 4.1.2: Name, Role, Value\n(Level A).\n\nThis PR updates the Add Terms panel to use `aria-live=\"polite\"`\nannouncements when either buttons are clicked, so screen readers can\ninform users of the change.\n\n### How to test\n1. Enable VoiceOver on macOS (Cmd + F5).\n2. Open Kibana and navigate to **Search → Synonyms**.\n3. Create a new synonyms set and select either \"equivalent\" or\n\"explicit\" rule.\n4. Add terms and click \"Reset changes\".\n5. Confirm that VoiceOver announces that the terms have been reset.\n6. Add terms and click \"Remove all\".\n5. Confirm that VoiceOver announces that the terms have been removed.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] ~Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Note\n\nFixes an accessibility issue where resetting changes or removing all\nterms in the Synonyms panel was not announced by screen readers.\nVoiceOver users on Safari will now hear updates when terms are reset.","sha":"9e7e748579b074f756e438941f236355ca190656","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Search","backport:all-open","ci:cloud-redeploy","v9.3.0"],"title":"[Search][Accessibility] Announce changes when resetting terms in synonyms panel","number":237877,"url":"https://github.com/elastic/kibana/pull/237877","mergeCommit":{"message":"[Search][Accessibility] Announce changes when resetting terms in synonyms panel (#237877)\n\n## Summary\nCurrently, when a user clicks `Reset changes` or `Remove all` on the Add\nTerms panel (for either equivalent or explicit types) in the Synonyms\nset editor, the terms are reset visually but the change is not announced\nby VoiceOver on macOS Safari. This breaks WCAG 4.1.2: Name, Role, Value\n(Level A).\n\nThis PR updates the Add Terms panel to use `aria-live=\"polite\"`\nannouncements when either buttons are clicked, so screen readers can\ninform users of the change.\n\n### How to test\n1. Enable VoiceOver on macOS (Cmd + F5).\n2. Open Kibana and navigate to **Search → Synonyms**.\n3. Create a new synonyms set and select either \"equivalent\" or\n\"explicit\" rule.\n4. Add terms and click \"Reset changes\".\n5. Confirm that VoiceOver announces that the terms have been reset.\n6. Add terms and click \"Remove all\".\n5. Confirm that VoiceOver announces that the terms have been removed.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] ~Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Note\n\nFixes an accessibility issue where resetting changes or removing all\nterms in the Synonyms panel was not announced by screen readers.\nVoiceOver users on Safari will now hear updates when terms are reset.","sha":"9e7e748579b074f756e438941f236355ca190656"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237877","number":237877,"mergeCommit":{"message":"[Search][Accessibility] Announce changes when resetting terms in synonyms panel (#237877)\n\n## Summary\nCurrently, when a user clicks `Reset changes` or `Remove all` on the Add\nTerms panel (for either equivalent or explicit types) in the Synonyms\nset editor, the terms are reset visually but the change is not announced\nby VoiceOver on macOS Safari. This breaks WCAG 4.1.2: Name, Role, Value\n(Level A).\n\nThis PR updates the Add Terms panel to use `aria-live=\"polite\"`\nannouncements when either buttons are clicked, so screen readers can\ninform users of the change.\n\n### How to test\n1. Enable VoiceOver on macOS (Cmd + F5).\n2. Open Kibana and navigate to **Search → Synonyms**.\n3. Create a new synonyms set and select either \"equivalent\" or\n\"explicit\" rule.\n4. Add terms and click \"Reset changes\".\n5. Confirm that VoiceOver announces that the terms have been reset.\n6. Add terms and click \"Remove all\".\n5. Confirm that VoiceOver announces that the terms have been removed.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] ~Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Note\n\nFixes an accessibility issue where resetting changes or removing all\nterms in the Synonyms panel was not announced by screen readers.\nVoiceOver users on Safari will now hear updates when terms are reset.","sha":"9e7e748579b074f756e438941f236355ca190656"}}]}] BACKPORT--> Co-authored-by: Brittany <seialkali@gmail.com>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…nyms panel (elastic#237877) ## Summary Currently, when a user clicks `Reset changes` or `Remove all` on the Add Terms panel (for either equivalent or explicit types) in the Synonyms set editor, the terms are reset visually but the change is not announced by VoiceOver on macOS Safari. This breaks WCAG 4.1.2: Name, Role, Value (Level A). This PR updates the Add Terms panel to use `aria-live="polite"` announcements when either buttons are clicked, so screen readers can inform users of the change. ### How to test 1. Enable VoiceOver on macOS (Cmd + F5). 2. Open Kibana and navigate to **Search → Synonyms**. 3. Create a new synonyms set and select either "equivalent" or "explicit" rule. 4. Add terms and click "Reset changes". 5. Confirm that VoiceOver announces that the terms have been reset. 6. Add terms and click "Remove all". 5. Confirm that VoiceOver announces that the terms have been removed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Note Fixes an accessibility issue where resetting changes or removing all terms in the Synonyms panel was not announced by screen readers. VoiceOver users on Safari will now hear updates when terms are reset.
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…nyms panel (elastic#237877) ## Summary Currently, when a user clicks `Reset changes` or `Remove all` on the Add Terms panel (for either equivalent or explicit types) in the Synonyms set editor, the terms are reset visually but the change is not announced by VoiceOver on macOS Safari. This breaks WCAG 4.1.2: Name, Role, Value (Level A). This PR updates the Add Terms panel to use `aria-live="polite"` announcements when either buttons are clicked, so screen readers can inform users of the change. ### How to test 1. Enable VoiceOver on macOS (Cmd + F5). 2. Open Kibana and navigate to **Search → Synonyms**. 3. Create a new synonyms set and select either "equivalent" or "explicit" rule. 4. Add terms and click "Reset changes". 5. Confirm that VoiceOver announces that the terms have been reset. 6. Add terms and click "Remove all". 5. Confirm that VoiceOver announces that the terms have been removed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Note Fixes an accessibility issue where resetting changes or removing all terms in the Synonyms panel was not announced by screen readers. VoiceOver users on Safari will now hear updates when terms are reset.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…nyms panel (elastic#237877) ## Summary Currently, when a user clicks `Reset changes` or `Remove all` on the Add Terms panel (for either equivalent or explicit types) in the Synonyms set editor, the terms are reset visually but the change is not announced by VoiceOver on macOS Safari. This breaks WCAG 4.1.2: Name, Role, Value (Level A). This PR updates the Add Terms panel to use `aria-live="polite"` announcements when either buttons are clicked, so screen readers can inform users of the change. ### How to test 1. Enable VoiceOver on macOS (Cmd + F5). 2. Open Kibana and navigate to **Search → Synonyms**. 3. Create a new synonyms set and select either "equivalent" or "explicit" rule. 4. Add terms and click "Reset changes". 5. Confirm that VoiceOver announces that the terms have been reset. 6. Add terms and click "Remove all". 5. Confirm that VoiceOver announces that the terms have been removed. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Note Fixes an accessibility issue where resetting changes or removing all terms in the Synonyms panel was not announced by screen readers. VoiceOver users on Safari will now hear updates when terms are reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when a user clicks
Reset changesorRemove allon the Add Terms panel (for either equivalent or explicit types) in the Synonyms set editor, the terms are reset visually but the change is not announced by VoiceOver on macOS Safari. This breaks WCAG 4.1.2: Name, Role, Value (Level A).This PR updates the Add Terms panel to use
aria-live="polite"announcements when either buttons are clicked, so screen readers can inform users of the change.How to test
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosIf a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.Flaky Test Runner was used on any tests changedrelease_note:*label is applied per the guidelinesbackport:*labels.Release Note
Fixes an accessibility issue where resetting changes or removing all terms in the Synonyms panel was not announced by screen readers. VoiceOver users on Safari will now hear updates when terms are reset.