Skip to content

[FTR] Disable dockerServers service when stubbing#237634

Merged
dgieselaar merged 6 commits intoelastic:mainfrom
dgieselaar:no-tests-no-docker
Oct 14, 2025
Merged

[FTR] Disable dockerServers service when stubbing#237634
dgieselaar merged 6 commits intoelastic:mainfrom
dgieselaar:no-tests-no-docker

Conversation

@dgieselaar
Copy link
Contributor

@dgieselaar dgieselaar commented Oct 6, 2025

Currently the dockerServers service starts a package registry container even if there are no tests. The package registry container can take up to 2m to start on CI, so it adds an unnecessary delay.

Relates to: #237584

@dgieselaar dgieselaar requested a review from a team as a code owner October 6, 2025 12:45
@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.2.0 v9.3.0 labels Oct 6, 2025
@dmlemeshko dmlemeshko self-requested a review October 7, 2025 10:19
@dmlemeshko
Copy link
Contributor

@dgieselaar I skipped tests to reproduce the issue, but I couldn't in main. Do you have config where it actually starts containers during tests check?

*[main][~/github/kibana]$ node scripts/functional_tests.js --config x-pack/solutions/observability/test/serverless/functional/configs/config.ts
 warn ❗️❗️❗️
 warn ❗️❗️❗️
 warn ❗️❗️❗️
 warn    Don't forget to use `node scripts/build_kibana_platform_plugins` to build plugins you plan on testing
 warn ❗️❗️❗️
 warn ❗️❗️❗️
 warn ❗️❗️❗️
 info Filtering out any suites that include the tag(s): [ 'skipSvlOblt' ]
 info Filtering out any suites that include the tag(s): [ 'skipSvlOblt' ]
 info Filtering out any suites that include the tag(s): [ 'skipSvlOblt' ]
 info Starting tests

 └-: serverless observability UI
   └-> "before all" hook: beforeTestSuite.trigger in "serverless observability UI"
   └-: navigation
     └-> "before all" hook: beforeTestSuite.trigger for "navigate observability sidenav & breadcrumbs"
     └-> "before all" hook for "navigate observability sidenav & breadcrumbs"
     └-> navigate observability sidenav & breadcrumbs
     └-> active sidenav section is auto opened on load
     └-> shows cases in sidebar navigation
     └-> navigates to cases app
     └-> navigates to alerts app

0 passing (1ms)
5 pending

The code change makes sense, just want to see the actual issue.

@dgieselaar
Copy link
Contributor Author

dgieselaar commented Oct 9, 2025

@dmlemeshko yes, locally you have to specify FLEET_PACKAGE_REGISTRY_PORT=6064 to have it start the container. But there are plenty of examples. If you go to https://buildkite.com/elastic/kibana-pull-request/builds/349260/steps/canvas?sid=0199c918-953f-4f51-b2ea-f6c70e3325e1, collapse the groups and search for configs containing serverless at the bottom you'll see a couple of examples.

Copy link
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgieselaar
Copy link
Contributor Author

I'm waiting until #238397 is in so I can get evidence of this being an improvement.

@dgieselaar dgieselaar self-assigned this Oct 13, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #122 / lens serverless - group 1 - subgroup 6 lens logsdb smoke testing functions support Scenarios with changing stream type LogsDB downgraded to regular data stream scenarios LogsDB stream with no additional stream/index and no host.name field should visualize a date histogram chart
  • [job] [logs] FTR Configs #64 / serverless security UI Serverless Security Cases Cases List bulk actions severity change the severity of cases to medium correctly

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/test 309 310 +1
Unknown metric groups

API count

id before after diff
@kbn/test 366 367 +1

History

cc @dgieselaar

@dgieselaar
Copy link
Contributor Author

Based on the following query I think there's about 8 configs that were starting docker even without tests:

FROM scout-test-events-*
  | WHERE reporter.type == "ftr" AND buildkite.build.number IN (350861, 350741) AND event.action == "run-end"
  | WHERE test_run.tests.total == 0
  | SORT process.uptime DESC
  | STATS left = AVG(process.uptime) WHERE buildkite.build.number == 350861, right = AVG(process.uptime) WHERE buildkite.build.number != 350861 BY test_run.config.file.path
  | SORT right DESC

So this saves about 10m tops. Not much, but it's a sane thing to do.

@dgieselaar dgieselaar merged commit 74ac864 into elastic:main Oct 14, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.2

https://github.com/elastic/kibana/actions/runs/18504791591

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2025
Currently the dockerServers service starts a package registry container
even if there are no tests. The package registry container can take up
to 2m to start on CI, so it adds an unnecessary delay.

Relates to: elastic#237584

(cherry picked from commit 74ac864)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 14, 2025
…38984)

# Backport

This will backport the following commits from `main` to `9.2`:
- [[FTR] Disable dockerServers service when stubbing
(#237634)](#237634)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"dario.gieselaar@elastic.co"},"sourceCommit":{"committedDate":"2025-10-14T17:25:29Z","message":"[FTR]
Disable dockerServers service when stubbing (#237634)\n\nCurrently the
dockerServers service starts a package registry container\neven if there
are no tests. The package registry container can take up\nto 2m to start
on CI, so it adds an unnecessary delay.\n\nRelates to:
https://github.com/elastic/kibana/issues/237584","sha":"74ac864aa28e3e99e015c8b3614dd2d7555ac6d5","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.3.0"],"title":"[FTR]
Disable dockerServers service when
stubbing","number":237634,"url":"https://github.com/elastic/kibana/pull/237634","mergeCommit":{"message":"[FTR]
Disable dockerServers service when stubbing (#237634)\n\nCurrently the
dockerServers service starts a package registry container\neven if there
are no tests. The package registry container can take up\nto 2m to start
on CI, so it adds an unnecessary delay.\n\nRelates to:
https://github.com/elastic/kibana/issues/237584","sha":"74ac864aa28e3e99e015c8b3614dd2d7555ac6d5"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237634","number":237634,"mergeCommit":{"message":"[FTR]
Disable dockerServers service when stubbing (#237634)\n\nCurrently the
dockerServers service starts a package registry container\neven if there
are no tests. The package registry container can take up\nto 2m to start
on CI, so it adds an unnecessary delay.\n\nRelates to:
https://github.com/elastic/kibana/issues/237584","sha":"74ac864aa28e3e99e015c8b3614dd2d7555ac6d5"}}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Oct 15, 2025
Currently the dockerServers service starts a package registry container
even if there are no tests. The package registry container can take up
to 2m to start on CI, so it adds an unnecessary delay.

Relates to: elastic#237584
mgadewoll pushed a commit to tkajtoch/kibana that referenced this pull request Oct 17, 2025
Currently the dockerServers service starts a package registry container
even if there are no tests. The package registry container can take up
to 2m to start on CI, so it adds an unnecessary delay.

Relates to: elastic#237584
rylnd pushed a commit to rylnd/kibana that referenced this pull request Oct 17, 2025
Currently the dockerServers service starts a package registry container
even if there are no tests. The package registry container can take up
to 2m to start on CI, so it adds an unnecessary delay.

Relates to: elastic#237584
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Oct 23, 2025
Currently the dockerServers service starts a package registry container
even if there are no tests. The package registry container can take up
to 2m to start on CI, so it adds an unnecessary delay.

Relates to: elastic#237584
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Oct 27, 2025
Currently the dockerServers service starts a package registry container
even if there are no tests. The package registry container can take up
to 2m to start on CI, so it adds an unnecessary delay.

Relates to: elastic#237584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v9.2.0 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants