Skip to content

[9.2] [dashboard] fixs controls cause double fetch (#237169)#237356

Merged
kibanamachine merged 2 commits intoelastic:9.2from
kibanamachine:backport/9.2/pr-237169
Oct 3, 2025
Merged

[9.2] [dashboard] fixs controls cause double fetch (#237169)#237356
kibanamachine merged 2 commits intoelastic:9.2from
kibanamachine:backport/9.2/pr-237169

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.2:

Questions ?

Please refer to the Backport tool documentation

Fixes elastic#237147

PR updates dashboard to wait until controls are ready before rendering
panels. This prevents a double fetch when panels would fetch data while
controls where building filters and then fetch data again once controls
filters are available.

This PR introduces a small performance degradation to dashboards with
controls. Panels will not start rendering until controls have finished
initializing. This is a better performance trade-off then the current
behavior of issuing a new round of requests once controls are ready.

### Testing
* install sample web logs
* create new dashboard
* add options list control on field `machine.os.keyword`
* Select `ios` in control
* add metric vis with count
* save dashboard
* open dashboard filter network requests to `ese`. Ensure metric chart
only makes a single request
<img width="2048" height="698" alt="Screenshot 2025-10-01 at 12 39
45 PM"
src="https://github.com/user-attachments/assets/b24e039c-2585-4eec-af9b-e459fccf90d7"
/>

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 7f7bd4f)
@kibanamachine kibanamachine requested a review from a team as a code owner October 2, 2025 16:50
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 2, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) October 2, 2025 16:50
@kibanamachine kibanamachine merged commit 1880778 into elastic:9.2 Oct 3, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #91 / Endpoint plugin @ess @serverless @skipInServerlessMKI Endpoint policy response api GET /api/endpoint/policy_response "after all" hook for "should return not found if host has no policy response"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 660.5KB 660.9KB +435.0B

History

cc @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants