Fix violations of the @elastic/eui/tooltip-focusable-anchor ESLint rule
#236721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
Project:Accessibility
release_note:skip
alexwizp
force-pushed
the
sep-29
branch
2 times, most recently
from
e9381dc to
32ae83f
Compare
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
kc13greiner
approved these changes
Oct 7, 2025
Contributor
kc13greiner
left a comment
kc13greiner
left a comment
There was a problem hiding this comment.
LGTM! Just one question
| {option.value?.description ? ( | ||
| <EuiToolTip position="left" content={option.value?.description}> | ||
| <EuiText size="s">{option.label}</EuiText> | ||
| <EuiText size="s" tabIndex={0}> |
Contributor
There was a problem hiding this comment.
I'm unsure about this one: these are options in the combo box, the arrow keys are used to navigate through them. When I tab, it just skips over it.
Is there a different attribute that could be added?
Contributor
Author
There was a problem hiding this comment.
@kc13greiner Yeah... you've found another case of unusual component usage =) I'll take a look at the options how we can deal with similar cases tomorrow morning.
stephmilovic
approved these changes
Oct 7, 2025
Contributor
Author
|
@elastic/kibana-core, @elastic/obs-ux-management-team, @elastic/stack-monitoring, @elastic/workflows-eng, @tomsonpl please review |
jesuswr
approved these changes
Oct 9, 2025
Contributor
Author
|
@elastic/obs-ux-management-team, @elastic/stack-monitoring, @elastic/workflows-eng, @tomsonpl please review |
consulthys
approved these changes
Oct 9, 2025
Contributor
consulthys
left a comment
consulthys
left a comment
There was a problem hiding this comment.
LGT Stack Monitoring
Thanks for the work!
shahzad31
approved these changes
Oct 9, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
Contributor
|
Starting backport for target branches: 9.1, 9.2 https://github.com/elastic/kibana/actions/runs/18374673215 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2025
…rule (elastic#236721) Closes: elastic#204767 Closes: elastic#221091 **Summary** This PR fixes accessibility violations related to EuiTooltip usage across the codebase. **Details** 1. Ensures that all `EuiTooltip` components are anchored to elements that can receive keyboard focus. 2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`, `EuiText`) used as tooltip anchors so they are keyboard-focusable. **Why** Tooltips anchored to non-focusable elements were not accessible to keyboard users. These changes improve compliance with accessibility guidelines and ensure a better experience for all users. **More context** Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint. See elastic/eui#9051 for more details --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 7088e5c)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Oct 9, 2025
…rule (elastic#236721) Closes: elastic#204767 Closes: elastic#221091 **Summary** This PR fixes accessibility violations related to EuiTooltip usage across the codebase. **Details** 1. Ensures that all `EuiTooltip` components are anchored to elements that can receive keyboard focus. 2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`, `EuiText`) used as tooltip anchors so they are keyboard-focusable. **Why** Tooltips anchored to non-focusable elements were not accessible to keyboard users. These changes improve compliance with accessibility guidelines and ensure a better experience for all users. **More context** Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint. See elastic/eui#9051 for more details --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 7088e5c) # Conflicts: # src/platform/packages/private/kbn-index-editor/src/components/file_clashes.tsx # src/platform/packages/private/kbn-index-editor/src/components/flyout_content.tsx # src/platform/packages/shared/kbn-apm-ui-shared/src/components/timestamp/index.tsx # src/platform/packages/shared/kbn-unified-field-list/src/components/field_stats/field_top_values_bucket.tsx # src/platform/plugins/shared/data/public/search/session/sessions_mgmt/components/table/columns/get_columns.tsx # src/platform/plugins/shared/workflows_management/public/components/workflows_empty_state/workflows_empty_state.tsx # x-pack/platform/plugins/shared/index_management/public/application/components/mappings_editor/components/document_fields/fields/fields_list_item.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/flyout_content/details_panel.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/table.tsx # x-pack/platform/plugins/shared/streams_app/public/components/data_management/schema_editor/field_status.tsx # x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_enrichment/processors/processor_metrics.tsx # x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_management/classic.tsx # x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_management/wired.tsx # x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_routing/idle_routing_stream_entry.tsx # x-pack/solutions/observability/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/badge/sync_badge.tsx # x-pack/solutions/observability/plugins/apm/public/components/shared/trace_waterfall/bar_details.tsx # x-pack/solutions/observability/plugins/observability/common/components/elapsed_timestamp_tooltip.tsx # x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/common.tsx # x-pack/solutions/security/plugins/security_solution/public/management/components/console_argument_selectors/custom_scripts_selector/custom_script_selector.tsx # x-pack/solutions/security/plugins/security_solution/public/management/components/console_argument_selectors/pending_actions_selector/pending_actions_selector.tsx # x-pack/solutions/security/plugins/security_solution/public/reports/components/ai_value/compare_percentage_badge.tsx
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2025
…SLint rule (#236721) (#238227) # Backport This will backport the following commits from `main` to `9.2`: - [Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule (#236721)](#236721) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-09T11:21:50Z","message":"Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule (#236721)\n\nCloses: https://github.com/elastic/kibana/issues/204767\nCloses: https://github.com/elastic/kibana/issues/221091\n\n**Summary**\n\nThis PR fixes accessibility violations related to EuiTooltip usage\nacross the codebase.\n\n**Details**\n\n1. Ensures that all `EuiTooltip` components are anchored to elements\nthat can receive keyboard focus.\n2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`,\n`EuiText`) used as tooltip anchors so they are keyboard-focusable.\n\n**Why**\n\nTooltips anchored to non-focusable elements were not accessible to\nkeyboard users. These changes improve compliance with accessibility\nguidelines and ensure a better experience for all users.\n\n**More context**\nFix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint.\nSee elastic/eui#9051 for more details\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"7088e5c0994a2206251cc55ad8abf684797cdcde","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:Fleet","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.2.0","v9.1.5","v9.3.0"],"title":"Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule","number":236721,"url":"https://github.com/elastic/kibana/pull/236721","mergeCommit":{"message":"Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule (#236721)\n\nCloses: https://github.com/elastic/kibana/issues/204767\nCloses: https://github.com/elastic/kibana/issues/221091\n\n**Summary**\n\nThis PR fixes accessibility violations related to EuiTooltip usage\nacross the codebase.\n\n**Details**\n\n1. Ensures that all `EuiTooltip` components are anchored to elements\nthat can receive keyboard focus.\n2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`,\n`EuiText`) used as tooltip anchors so they are keyboard-focusable.\n\n**Why**\n\nTooltips anchored to non-focusable elements were not accessible to\nkeyboard users. These changes improve compliance with accessibility\nguidelines and ensure a better experience for all users.\n\n**More context**\nFix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint.\nSee elastic/eui#9051 for more details\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"7088e5c0994a2206251cc55ad8abf684797cdcde"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236721","number":236721,"mergeCommit":{"message":"Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule (#236721)\n\nCloses: https://github.com/elastic/kibana/issues/204767\nCloses: https://github.com/elastic/kibana/issues/221091\n\n**Summary**\n\nThis PR fixes accessibility violations related to EuiTooltip usage\nacross the codebase.\n\n**Details**\n\n1. Ensures that all `EuiTooltip` components are anchored to elements\nthat can receive keyboard focus.\n2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`,\n`EuiText`) used as tooltip anchors so they are keyboard-focusable.\n\n**Why**\n\nTooltips anchored to non-focusable elements were not accessible to\nkeyboard users. These changes improve compliance with accessibility\nguidelines and ensure a better experience for all users.\n\n**More context**\nFix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint.\nSee elastic/eui#9051 for more details\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"7088e5c0994a2206251cc55ad8abf684797cdcde"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
alexwizp
added a commit
that referenced
this pull request
Oct 10, 2025
…SLint rule (#236721) (#238242) # Backport This will backport the following commits from `main` to `9.1`: - [Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule (#236721)](#236721) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-09T11:21:50Z","message":"Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule (#236721)\n\nCloses: https://github.com/elastic/kibana/issues/204767\nCloses: https://github.com/elastic/kibana/issues/221091\n\n**Summary**\n\nThis PR fixes accessibility violations related to EuiTooltip usage\nacross the codebase.\n\n**Details**\n\n1. Ensures that all `EuiTooltip` components are anchored to elements\nthat can receive keyboard focus.\n2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`,\n`EuiText`) used as tooltip anchors so they are keyboard-focusable.\n\n**Why**\n\nTooltips anchored to non-focusable elements were not accessible to\nkeyboard users. These changes improve compliance with accessibility\nguidelines and ensure a better experience for all users.\n\n**More context**\nFix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint.\nSee elastic/eui#9051 for more details\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"7088e5c0994a2206251cc55ad8abf684797cdcde","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:Fleet","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.2.0","v9.1.5","v9.3.0"],"title":"Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule","number":236721,"url":"https://github.com/elastic/kibana/pull/236721","mergeCommit":{"message":"Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule (#236721)\n\nCloses: https://github.com/elastic/kibana/issues/204767\nCloses: https://github.com/elastic/kibana/issues/221091\n\n**Summary**\n\nThis PR fixes accessibility violations related to EuiTooltip usage\nacross the codebase.\n\n**Details**\n\n1. Ensures that all `EuiTooltip` components are anchored to elements\nthat can receive keyboard focus.\n2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`,\n`EuiText`) used as tooltip anchors so they are keyboard-focusable.\n\n**Why**\n\nTooltips anchored to non-focusable elements were not accessible to\nkeyboard users. These changes improve compliance with accessibility\nguidelines and ensure a better experience for all users.\n\n**More context**\nFix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint.\nSee elastic/eui#9051 for more details\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"7088e5c0994a2206251cc55ad8abf684797cdcde"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238227","number":238227,"state":"OPEN"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236721","number":236721,"mergeCommit":{"message":"Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint rule (#236721)\n\nCloses: https://github.com/elastic/kibana/issues/204767\nCloses: https://github.com/elastic/kibana/issues/221091\n\n**Summary**\n\nThis PR fixes accessibility violations related to EuiTooltip usage\nacross the codebase.\n\n**Details**\n\n1. Ensures that all `EuiTooltip` components are anchored to elements\nthat can receive keyboard focus.\n2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`,\n`EuiText`) used as tooltip anchors so they are keyboard-focusable.\n\n**Why**\n\nTooltips anchored to non-focusable elements were not accessible to\nkeyboard users. These changes improve compliance with accessibility\nguidelines and ensure a better experience for all users.\n\n**More context**\nFix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint.\nSee elastic/eui#9051 for more details\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"7088e5c0994a2206251cc55ad8abf684797cdcde"}}]}] BACKPORT-->
kibanamachine
added
v9.1.6
and removed
backport missing
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…rule (elastic#236721) Closes: elastic#204767 Closes: elastic#221091 **Summary** This PR fixes accessibility violations related to EuiTooltip usage across the codebase. **Details** 1. Ensures that all `EuiTooltip` components are anchored to elements that can receive keyboard focus. 2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`, `EuiText`) used as tooltip anchors so they are keyboard-focusable. **Why** Tooltips anchored to non-focusable elements were not accessible to keyboard users. These changes improve compliance with accessibility guidelines and ensure a better experience for all users. **More context** Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint. See elastic/eui#9051 for more details --------- Co-authored-by: kibanamachine <[email protected]>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…rule (elastic#236721) Closes: elastic#204767 Closes: elastic#221091 **Summary** This PR fixes accessibility violations related to EuiTooltip usage across the codebase. **Details** 1. Ensures that all `EuiTooltip` components are anchored to elements that can receive keyboard focus. 2. Added `tabIndex={0}` to non-interactive elements (e.g., `span`, `EuiText`) used as tooltip anchors so they are keyboard-focusable. **Why** Tooltips anchored to non-focusable elements were not accessible to keyboard users. These changes improve compliance with accessibility guidelines and ensure a better experience for all users. **More context** Fix violations of the `@elastic/eui/tooltip-focusable-anchor` ESLint. See elastic/eui#9051 for more details --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #204767
Closes: #221091
Summary
This PR fixes accessibility violations related to EuiTooltip usage across the codebase.
Details
EuiTooltipcomponents are anchored to elements that can receive keyboard focus.tabIndex={0}to non-interactive elements (e.g.,span,EuiText) used as tooltip anchors so they are keyboard-focusable.Why
Tooltips anchored to non-focusable elements were not accessible to keyboard users. These changes improve compliance with accessibility guidelines and ensure a better experience for all users.
More context
Fix violations of the
@elastic/eui/tooltip-focusable-anchorESLint. See elastic/eui#9051 for more details