Skip to content

[Security Solution] Adds customized_fields and has_base_version fields to internal rule schema #235394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dplumlee merged 4 commits into from
Sep 20, 2025
Merged

[Security Solution] Adds customized_fields and has_base_version fields to internal rule schema #235394

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e6d0f0
adds fields as optional to internal schema
dplumlee Sep 17, 2025
1c823ad
Merge remote-tracking branch 'upstream/main' into rule-customizations…
dplumlee Sep 17, 2025
a90217a
Merge remote-tracking branch 'upstream/main' into rule-customizations…
dplumlee Sep 18, 2025
68905e8
Merge branch 'main' into rule-customizations-field-internal-schema
dplumlee Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...y/plugins/security_solution/server/lib/detection_engine/rule_schema/model/rule_schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,14 @@ export const RuleSourceCamelCased = z.discriminatedUnion('type', [
z.object({
type: z.literal('external'),
isCustomized: IsExternalRuleCustomized,
customizedFields: z
Copy link
Contributor

@vitaliidm vitaliidm Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add new parameter to external schemas too?

Copy link
Contributor Author

@dplumlee dplumlee Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what this PR is doing. We need to add it to the internal rule schemas first due to our intermediate release practice with rule schema modifications

.array(
z.object({
fieldName: z.string(),
})
)
.optional(),
hasBaseVersion: z.boolean().optional(),
}),
z.object({
type: z.literal('internal'),
Expand Down