Skip to content

[6.x] Add context to job picker for accessibility (#23483) #23496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alvarezmelissa87 merged 1 commit into from
Sep 25, 2018
Merged

[6.x] Add context to job picker for accessibility (#23483) #23496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions x-pack/plugins/ml/public/components/job_select_list/job_select_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
ng-if="singleSelection !== true"
type="checkbox"
ng-checked="allGroupsSelected"
aria-label="Select all groups checkbox"
aria-label="Select all groups checkbox. Total count {{selected.groups.length}}."
ng-click="toggleAllGroupsSelection()" />
Groups
</div>
Expand All @@ -25,6 +25,7 @@
<label class="kuiFormLabel">
<div >
<input
aria-label="Group ID {{group.id}}"
ng-if="singleSelection !== true && group.selectable === true" type="checkbox"
ng-model="group.selected"
ng-click="toggleGroupSelection()" />
Expand Down Expand Up @@ -53,7 +54,7 @@
<div class="list-section-title" ng-if="singleSelection !== true">
<input type="checkbox"
ng-checked="allJobsSelected"
aria-label="Select all jobs checkbox"
aria-label="Select all jobs checkbox. Total count {{selected.jobs.length}}."
ng-click="toggleAllJobsSelection()" />
Jobs
</div>
Expand All @@ -72,7 +73,7 @@
value="{{job.id}}"
ng-model="$parent.$parent.selectedJobRadio"
ng-disabled='job.disabled' />
<span ng-class="{'disabled-job': job.disabled}">{{job.id}}</span>
<span ng-class="{'disabled-job': job.disabled}" aria-label="Job ID {{job.id}}">{{job.id}}</span>
</span>
</div>
<div>
Expand All @@ -81,6 +82,7 @@
</div>
<div
class='gant-bar'
aria-label="time range {{job.timeRange.label}}"
ng-class="{'disabled-job': job.disabled, 'gant-bar-running': job.running}"
tooltip='{{job.timeRange.label}}'
tooltip-placement="bottom"
Expand Down