[ES|QL] fix column name detection#234788
Closed
drewdaemon wants to merge 3 commits intoelastic:mainfrom
Closed
Conversation
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
Author
|
/ci |
ac79f9f to
3fcbed0
Compare
Contributor
Author
|
/ci |
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Contributor
Author
|
@stratoula before I go to the effort of debugging tests and stuff, can you confirm that you agree with the overall decisions I made here? They are described in the PR description. |
Contributor
|
the 2nd is a good catch, it makes sense yes (unfortunately...). Let's create 2 PRs though. The one to solve quickly the regression (it is very bad, I dont want to land in serverless) and the other the existing bug. I want to test the latter well so it might take more time to get merged in main |
Contributor
Author
|
Makes sense, I'll split them out and we'll get the first fix in |
Contributor
Author
|
Waiting on #234986 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before

After

This fixes this case (pre-existing bug)
Screen.Recording.2025-09-11.at.2.28.15.PM.mov
Checklist