Skip to content

[6.x] display hits and total hits for courier inspector requests (#23434) #23449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nreese merged 1 commit into from
Sep 24, 2018
Merged

[6.x] display hits and total hits for courier inspector requests (#23434) #23449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ui/public/courier/utils/courier_inspector_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,15 @@ function getResponseInspectorStats(searchSource, resp) {
}

if (resp && resp.hits) {
stats.Hits = {
stats['Hits (total)'] = {
value: `${resp.hits.total}`,
description: 'The number of documents that match the query.',
};

stats.Hits = {
value: `${resp.hits.hits.length}`,
description: 'The number of documents returned by the query.',
};
}

if (lastRequest && (lastRequest.ms === 0 || lastRequest.ms)) {
Expand Down
2 changes: 1 addition & 1 deletion test/functional/apps/discover/_inspector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default function ({ getService, getPageObjects }) {
const STATS_ROW_VALUE_INDEX = 1;
function getHitCount(requestStats) {
const hitsCountStatsRow = requestStats.find((statsRow) => {
return statsRow[STATS_ROW_NAME_INDEX] === 'Hits';
return statsRow[STATS_ROW_NAME_INDEX] === 'Hits (total)';
});
return hitsCountStatsRow[STATS_ROW_VALUE_INDEX];
}
Expand Down