[Inspect component] Close inspect overlay on Escape key press#234137
Merged
kowalczyk-krzysztof merged 7 commits intoelastic:mainfrom Sep 5, 2025
Merged
Conversation
kowalczyk-krzysztof
added
release_note:skip
kowalczyk-krzysztof
added
the
Team:SharedUX
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Escape key functionality to close the inspect overlay in the Kibana inspect component. When users press the Escape key while the inspect overlay is active, it will close the overlay and exit inspection mode.
Key changes:
- Added a utility function to detect Escape key presses
- Integrated keyboard event handling into the inspect overlay component
- Added test coverage for the new Escape key functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| keyboard_shortcut.ts | Added utility function isEscapeKey to detect Escape key presses |
| inspect_overlay.tsx | Integrated Escape key handling to close overlay and added keyboard event listener |
| inspect_overlay.test.tsx | Added test case to verify Escape key closes the overlay |
...platform/plugins/private/inspect_component/public/lib/keyboard_shortcut/keyboard_shortcut.ts
Outdated
Show resolved
Hide resolved
…oard_shortcut/keyboard_shortcut.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kowalczyk-krzysztof
changed the title
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
|
kowalczyk-krzysztof
deleted the
feat/add-escape-key-close-to-inspect-component
branch
shahargl
pushed a commit
to shahargl/kibana
that referenced
this pull request
Sep 7, 2025
…c#234137) ## Summary This PR adds closing on `Escape` key press functionality to inspect overlay. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
…c#234137) ## Summary This PR adds closing on `Escape` key press functionality to inspect overlay. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
…c#234137) ## Summary This PR adds closing on `Escape` key press functionality to inspect overlay. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds closing on
Escapekey press functionality to inspect overlay.