[Security assistant] Remove feature flag to enable conversation sharing#234100
Merged
stephmilovic merged 10 commits intoelastic:mainfrom Sep 11, 2025
Merged
[Security assistant] Remove feature flag to enable conversation sharing#234100stephmilovic merged 10 commits intoelastic:mainfrom
stephmilovic merged 10 commits intoelastic:mainfrom
Conversation
stephmilovic
added
the
release_note:skip
stephmilovic
added
backport:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the feature flag controlling conversation sharing functionality in the security assistant, making the feature permanently available in both ESS and serverless environments. The primary changes include removing all references to the isAssistantSharingEnabled feature flag and updating Cypress tests to work properly in serverless environments.
Key changes:
- Complete removal of the
isAssistantSharingEnabledfeature flag and related conditional logic - Removal of color differentiation for conversation share icons (now all icons use default color)
- Updates to Cypress tests to properly handle user authentication and test scenarios in serverless environments
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| shared_conversations.cy.ts | Updated Cypress tests to remove serverless skip tags, simplified user handling, and removed conditional logic for serverless vs ESS testing |
| config.ts | Removed feature flag override for assistant sharing in Cypress configuration |
| use_assistant_availability.ts | Removed feature flag import and isAssistantSharingEnabled property from the hook |
| index.ts (kbn-elastic-assistant) | Removed isAssistantSharingEnabled property from UseAssistantAvailability interface |
| types.tsx | Removed isAssistantSharingEnabled property from AssistantAvailability interface |
| index.tsx (assistant) | Removed isAssistantSharingEnabled prop passing to child components |
| index.tsx (conversation_sidepanel) | Removed isAssistantSharingEnabled prop and related conditional logic |
| conversation_list_item.tsx | Removed feature flag dependency, color differentiation for icons, and conditional rendering of context menu |
| conversation_list_item.test.tsx | Updated test to remove isAssistantSharingEnabled prop |
| index.tsx (assistant_header) | Removed isAssistantSharingEnabled prop and conditional rendering of ShareSelectModal |
| index.test.tsx (assistant_header) | Updated tests to remove isAssistantSharingEnabled prop usage |
| kbn_elastic_assistant.devdocs.json | Updated API documentation to remove isAssistantSharingEnabled references |
Comment on lines
+289
to
+295
| const loginSecondaryUser = (isServerless: boolean, username: string) => { | ||
| if (isServerless) { | ||
| loginWithUser({ username, password: 'changeme' }); | ||
| } else { | ||
| login(username); | ||
| } | ||
| ); | ||
| }; |
There was a problem hiding this comment.
The hardcoded password 'changeme' is a security concern. Consider using environment variables or a more secure credential management approach for test environments.
e40pud
approved these changes
Sep 10, 2025
Contributor
e40pud
left a comment
e40pud
left a comment
There was a problem hiding this comment.
This is awesome! Tested locally and did not notice any weirdness 🚀
.../security/test/security_solution_cypress/cypress/e2e/ai_assistant/shared_conversations.cy.ts
Show resolved
Hide resolved
.../security/test/security_solution_cypress/cypress/e2e/ai_assistant/shared_conversations.cy.ts
Show resolved
Hide resolved
.../security/test/security_solution_cypress/cypress/e2e/ai_assistant/shared_conversations.cy.ts
Outdated
Show resolved
Hide resolved
enriquesanchez-elastic
approved these changes
Sep 11, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge requirements
Docs update: elastic/docs-content#2903