[Streams] Enable UI by default#233997
Conversation
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
|
Pinging @elastic/streams-program-team (Team:streams-program) |
shahzad31
left a comment
There was a problem hiding this comment.
Obs UX changes LGTM !!
flash1293
left a comment
There was a problem hiding this comment.
Tested and works fine.
The
return from(
repositoryClient
.fetch('GET /api/streams/_status', {
signal: new AbortController().signal,
})
.then(
(response) => (response.enabled ? ENABLED_STATUS : DISABLED_STATUS),
(error) => {
logger.error(error);
return UNKNOWN_STATUS;
}
)
).pipe(startWith(UNKNOWN_STATUS), shareReplay(1));
doesn't matter anymore, since it's never triggered (serverless security/search don't show the nav item ever, and that would be the only case that's still affected).
After that LGTM
Makes sense, will remove it and return |
There was a problem hiding this comment.
Pull Request Overview
This PR enables the Streams UI by default for both observability serverless and stateful deployments by removing the observability:enableStreamsUI advanced setting option. The UI is now always enabled instead of being controlled by a configurable setting.
Key Changes:
- Removed the
OBSERVABILITY_ENABLE_STREAMS_UIsetting and its associated configuration - Hardcoded the Streams UI to be enabled (
enabled: true) - Updated status determination logic to use deployment type checks instead of setting values
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| use_streams_privileges.ts | Removes UI setting check and hardcodes UI as enabled |
| plugin.ts | Updates registerFeatureFlags function call to remove plugins parameter |
| feature_flags.ts | Removes UI setting registration and serverless detection logic |
| public/plugin.ts | Simplifies status observable to use deployment type checks instead of settings |
| oss_platform.json | Removes telemetry schema entry for the deleted setting |
| types.ts | Removes usage stats type definition for the deleted setting |
| schema.ts | Removes telemetry collection schema for the deleted setting |
| observability_project/index.ts | Removes setting from serverless project configuration |
| setting_ids/index.ts | Removes the setting ID constant definition |
kapral18
left a comment
There was a problem hiding this comment.
LGTM for kibana-management
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
|
closes elastic#232455 ## Summary This PR removes the below `enable streams UI` advanced setting option. The setting is enabled by default for observability serverless deployment as well as for stateful. 
closes elastic#232455 ## Summary This PR removes the below `enable streams UI` advanced setting option. The setting is enabled by default for observability serverless deployment as well as for stateful. 
closes elastic#232455 ## Summary This PR removes the below `enable streams UI` advanced setting option. The setting is enabled by default for observability serverless deployment as well as for stateful. 
closes #232455
Summary
This PR removes the below
enable streams UIadvanced setting option.The setting is enabled by default for observability serverless deployment as well as for stateful.