Skip to content

[Streams] Enable UI by default#233997

Merged
mohamedhamed-ahmed merged 6 commits intoelastic:mainfrom
mohamedhamed-ahmed:232455-enable-streams-ui-by-default
Sep 5, 2025
Merged

[Streams] Enable UI by default#233997
mohamedhamed-ahmed merged 6 commits intoelastic:mainfrom
mohamedhamed-ahmed:232455-enable-streams-ui-by-default

Conversation

@mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented Sep 4, 2025

closes #232455

Summary

This PR removes the below enable streams UI advanced setting option.
The setting is enabled by default for observability serverless deployment as well as for stateful.

enable_streams_ui

@mohamedhamed-ahmed mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:obs-onboarding Observability Onboarding Team Team:streams-program Team Label for Streams program Feature:Streams This is the label for the Streams Project labels Sep 4, 2025
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review September 4, 2025 18:53
@mohamedhamed-ahmed mohamedhamed-ahmed requested review from a team as code owners September 4, 2025 18:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/streams-program-team (Team:streams-program)

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obs UX changes LGTM !!

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine.

The

    return from(
      repositoryClient
        .fetch('GET /api/streams/_status', {
          signal: new AbortController().signal,
        })
        .then(
          (response) => (response.enabled ? ENABLED_STATUS : DISABLED_STATUS),
          (error) => {
            logger.error(error);
            return UNKNOWN_STATUS;
          }
        )
    ).pipe(startWith(UNKNOWN_STATUS), shareReplay(1));

doesn't matter anymore, since it's never triggered (serverless security/search don't show the nav item ever, and that would be the only case that's still affected).

After that LGTM

@mohamedhamed-ahmed
Copy link
Contributor Author

doesn't matter anymore, since it's never triggered (serverless security/search don't show the nav item ever, and that would be the only case that's still affected).

Makes sense, will remove it and return Disabled otherwise 👍

Copilot AI review requested due to automatic review settings September 5, 2025 09:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the Streams UI by default for both observability serverless and stateful deployments by removing the observability:enableStreamsUI advanced setting option. The UI is now always enabled instead of being controlled by a configurable setting.

Key Changes:

  • Removed the OBSERVABILITY_ENABLE_STREAMS_UI setting and its associated configuration
  • Hardcoded the Streams UI to be enabled (enabled: true)
  • Updated status determination logic to use deployment type checks instead of setting values

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
use_streams_privileges.ts Removes UI setting check and hardcodes UI as enabled
plugin.ts Updates registerFeatureFlags function call to remove plugins parameter
feature_flags.ts Removes UI setting registration and serverless detection logic
public/plugin.ts Simplifies status observable to use deployment type checks instead of settings
oss_platform.json Removes telemetry schema entry for the deleted setting
types.ts Removes usage stats type definition for the deleted setting
schema.ts Removes telemetry collection schema for the deleted setting
observability_project/index.ts Removes setting from serverless project configuration
setting_ids/index.ts Removes the setting ID constant definition

Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for kibana-management

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streams 23 22 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 133 132 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 668.9KB 668.8KB -40.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
streams 7.5KB 7.4KB -111.0B
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 134 133 -1

History

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohamedhamed-ahmed mohamedhamed-ahmed merged commit 57a7fe5 into elastic:main Sep 5, 2025
12 checks passed
shahargl pushed a commit to shahargl/kibana that referenced this pull request Sep 7, 2025
closes elastic#232455

## Summary
This PR removes the below `enable streams UI` advanced setting option. 
The setting is enabled by default for observability serverless
deployment as well as for stateful.


![enable_streams_ui](https://github.com/user-attachments/assets/5e533ab5-ca73-40e4-bbe7-89e9e1c6659c)
KodeRad pushed a commit to KodeRad/kibana that referenced this pull request Sep 15, 2025
closes elastic#232455

## Summary
This PR removes the below `enable streams UI` advanced setting option. 
The setting is enabled by default for observability serverless
deployment as well as for stateful.


![enable_streams_ui](https://github.com/user-attachments/assets/5e533ab5-ca73-40e4-bbe7-89e9e1c6659c)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
closes elastic#232455

## Summary
This PR removes the below `enable streams UI` advanced setting option. 
The setting is enabled by default for observability serverless
deployment as well as for stateful.


![enable_streams_ui](https://github.com/user-attachments/assets/5e533ab5-ca73-40e4-bbe7-89e9e1c6659c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team Team:streams-program Team Label for Streams program v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Streams] Enable the Streams UI by default

9 participants