Skip to content

[ObsUX][Infra] Fix Metadata filtering is confusing/broken when typing "OR" in host view #233836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rmyz merged 11 commits into from
Dec 12, 2025
Merged

[ObsUX][Infra] Fix Metadata filtering is confusing/broken when typing "OR" in host view #233836

rmyz merged 11 commits into from
Dec 12, 2025

Conversation

@rmyz
Copy link
Contributor

@rmyz rmyz commented Sep 3, 2025 •
edited by kibanamachine
Loading

Summary

This PR fixes the metadata table not being able to filter "or..." values since it was using KQL and throwing an error.
It uses plain text now to avoid having those issues.

Before

or.in.metadata.doesnt.work.mp4

After

Kapture.2025-09-03.at.11.05.01.mp4

@rmyz rmyz self-assigned this Sep 3, 2025
@rmyz rmyz requested a review from a team September 3, 2025 09:12
@rmyz rmyz added Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. backport:version Backport to applied version labels v9.1.4 v8.19.4 labels Sep 3, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 3, 2025

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@rmyz rmyz enabled auto-merge (squash) September 3, 2025 10:09
jennypavlova
jennypavlova approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!
BTW, the metadata search test is failing now - it's probably the way we get the value, can you please check that?

@rmyz
Copy link
Contributor Author

rmyz commented Sep 4, 2025

Making this a draft since there is an issue with EuiInMemoryTable using searchFormat="text" not updating the query value

@rmyz rmyz marked this pull request as draft September 4, 2025 08:06
auto-merge was automatically disabled September 4, 2025 08:06

Pull request was converted to draft

@rmyz
Copy link
Contributor Author

rmyz commented Oct 14, 2025

The fix was merged in main and it's being backported to 9.2.
This PR is ready to be merged.

@rmyz rmyz marked this pull request as ready for review October 14, 2025 08:35
@rmyz
Copy link
Contributor Author

rmyz commented Oct 14, 2025

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 14, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #140 / Cases cases list filtering "after each" hook for "filters cases by the first cases all user assignee"
  • [job] [logs] FTR Configs #67 / InfraOps App Metrics UI Node Details #Asset Type: host Metadata Tab preserves search term between page reloads
  • [job] [logs] FTR Configs #67 / InfraOps App Metrics UI Node Details #Asset Type: host Metadata Tab preserves search term between page reloads

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.1MB 1.1MB -15.0B

History

cc @rmyz

@rmyz rmyz marked this pull request as draft October 15, 2025 08:34
@rmyz rmyz added v9.2.1 and removed v9.2.0 labels Nov 3, 2025
@rmyz rmyz added the Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation label Dec 11, 2025
@rmyz rmyz added the ci:beta-faster-pr-build Uses an alternative PR build pipeline with speed optimizations label Dec 12, 2025
@rmyz
Copy link
Contributor Author

rmyz commented Dec 12, 2025

/ci

@rmyz rmyz marked this pull request as ready for review December 12, 2025 09:57
@rmyz rmyz requested a review from a team as a code owner December 12, 2025 09:57
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2025

Pinging @elastic/obs-presentation-team (Team:obs-presentation)

MiriamAparicio
MiriamAparicio approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only

@rmyz rmyz merged commit bf537fc into elastic:main Dec 12, 2025
16 checks passed
@rmyz rmyz deleted the 4787-fix-metadata-filter-or branch December 12, 2025 10:20
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 12, 2025

Starting backport for target branches: 9.2

https://github.com/elastic/kibana/actions/runs/20163675735

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 12, 2025
@rmyz
[ObsUX][Infra] Fix Metadata filtering is confusing/broken when typing…
463363d 
… "OR" in host view (elastic#233836)

(cherry picked from commit bf537fc)
@kibanamachine kibanamachine mentioned this pull request Dec 12, 2025
Closed
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 12, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 15, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 15, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @rmyz

seanrathier pushed a commit to seanrathier/kibana that referenced this pull request Dec 15, 2025
@rmyz @seanrathier
[ObsUX][Infra] Fix Metadata filtering is confusing/broken when typing…
4e9cc06 
… "OR" in host view (elastic#233836)
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 16, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @rmyz

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 17, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @rmyz

@rmyz
Copy link
Contributor Author

rmyz commented Dec 18, 2025 •
edited
Loading

backporting to 9.2 won't be done as Eui team tried to release a backport fix but it had too much merge conflicts.

@rmyz rmyz removed backport missing Added to PRs automatically when the are determined to be missing a backport. v9.2.3 labels Dec 18, 2025
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 19, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 19, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233836 locally
cc: @rmyz

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 22, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233836 locally
cc: @rmyz

@rmyz rmyz added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels labels Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bluefinger Bluefinger Bluefinger approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

Assignees

@rmyz rmyz

Labels

backport:skip This PR does not require backporting ci:beta-faster-pr-build Uses an alternative PR build pipeline with speed optimizations release_note:fix Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rmyz @elasticmachine @kibanamachine @Bluefinger @jennypavlova @MiriamAparicio