[Security assistant] Sharing feature flag fix#233788
Merged
stephmilovic merged 5 commits intoelastic:mainfrom Sep 5, 2025
Merged
[Security assistant] Sharing feature flag fix#233788stephmilovic merged 5 commits intoelastic:mainfrom
stephmilovic merged 5 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
patrykkopycinski
approved these changes
Sep 5, 2025
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
shahargl
pushed a commit
to shahargl/kibana
that referenced
this pull request
Sep 7, 2025
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I forgot to hide the sharing features from conversation settings behind the feature flag! Whoops. This PR hides the sharing features from conversation settings. Now, when running with the feature flag set to false, the user will NOT see the following sharing components:
Testing
Run kibana without the feature flag, or with the flag set to false:
Visit the conversation settings page and ensure the sharing column does not show. Edit a conversation, assure sharing settings do not show.