Skip to content

[Security assistant] Sharing feature flag fix#233788

Merged
stephmilovic merged 5 commits intoelastic:mainfrom
stephmilovic:fix_flag_sharing
Sep 5, 2025
Merged

[Security assistant] Sharing feature flag fix#233788
stephmilovic merged 5 commits intoelastic:mainfrom
stephmilovic:fix_flag_sharing

Conversation

@stephmilovic
Copy link
Copy Markdown
Contributor

Summary

I forgot to hide the sharing features from conversation settings behind the feature flag! Whoops. This PR hides the sharing features from conversation settings. Now, when running with the feature flag set to false, the user will NOT see the following sharing components:

Screenshot 2025-08-28 at 2 45 02 PM Screenshot 2025-08-28 at 2 45 07 PM

Testing

Run kibana without the feature flag, or with the flag set to false:

feature_flags.overrides.elasticAssistant.assistantSharingEnabled: false

Visit the conversation settings page and ensure the sharing column does not show. Edit a conversation, assure sharing settings do not show.

@stephmilovic stephmilovic requested a review from a team as a code owner September 2, 2025 19:51
@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI v9.2.0 labels Sep 2, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #126 / management scripted fields preview "after all" hook: afterAll for "should display additional fields"
  • [job] [logs] FTR Configs #126 / management scripted fields preview "before all" hook for "should display script error when script is invalid"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.3MB 10.3MB +148.0B

History

@stephmilovic stephmilovic merged commit c03b81a into elastic:main Sep 5, 2025
12 checks passed
shahargl pushed a commit to shahargl/kibana that referenced this pull request Sep 7, 2025
KodeRad pushed a commit to KodeRad/kibana that referenced this pull request Sep 15, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants