Skip to content

Add max_score to some Elasticsearch SearchHitsMetadata #233641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pquentin wants to merge 3 commits into from
Closed

Add max_score to some Elasticsearch SearchHitsMetadata #233641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac6b059
Add max_score to some Elasticsearch SearchHitsMetadata
pquentin Sep 1, 2025
b951cf3
Add _score and max_score to more mock Elasticsearch responses
pquentin Sep 2, 2025
2474e15
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/packages/saved-objects/api-server-internal/src/lib/apis/find.isolated.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const createSuccessSearchResponse = (objects: ObjectInfo[]): estypes.SearchRespo
_shards: {} as any,
hits: {
total: objects.length,
max_score: 1,
hits: objects.map(createHit),
},
};
Expand Down
1 change: 1 addition & 0 deletions ...ackages/saved-objects/api-server-internal/src/lib/repository.encryption_extension.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,7 @@ describe('SavedObjectsRepository Encryption Extension', () => {
_shards: {} as any,
hits: {
total: 2,
max_score: 2,
hits: [
{
_index: MAIN_SAVED_OBJECT_INDEX,
Expand Down
1 change: 1 addition & 0 deletions ...ore/packages/saved-objects/api-server-internal/src/test_helpers/repository.test.common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,7 @@ export const generateIndexPatternSearchResults = (namespace?: string) => {
_shards: {} as any,
hits: {
total: 4,
max_score: 4,
hits: [
{
_index: MAIN_SAVED_OBJECT_INDEX,
Expand Down
7 changes: 7 additions & 0 deletions src/platform/packages/private/kbn-generate-csv/src/generate_csv.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,7 @@ describe('CsvGenerator', () => {
_id: 'my-cool-id',
_index: 'my-cool-index',
_version: 4,
_score: 1,
fields: {
sku: [`This is a cool SKU.`, `This is also a cool SKU.`],
},
Expand Down Expand Up @@ -1054,6 +1055,7 @@ describe('CsvGenerator', () => {
_id: 'my-cool-id',
_index: 'my-cool-index',
_version: 4,
_score: 1,
fields: {
date: ['2020-12-31T00:14:28.000Z'],
message: [`it's nice to see you`],
Expand Down Expand Up @@ -1104,6 +1106,7 @@ describe('CsvGenerator', () => {
_id: 'my-cool-id',
_index: 'my-cool-index',
_version: 4,
_score: 1,
fields: {
date: ['2020-12-31T00:14:28.000Z'],
message_z: [`test field Z`],
Expand Down Expand Up @@ -1161,6 +1164,7 @@ describe('CsvGenerator', () => {
_id: 'my-cool-id',
_index: 'my-cool-index',
_version: 4,
_score: 1,
fields: {
product: 'coconut',
category: [`cool`, `rad`],
Expand Down Expand Up @@ -1200,6 +1204,7 @@ describe('CsvGenerator', () => {
_id: 'my-cool-id',
_index: 'my-cool-index',
_version: 4,
_score: 1,
fields: {
product: 'coconut',
category: [`cool`, `rad`],
Expand Down Expand Up @@ -1239,6 +1244,7 @@ describe('CsvGenerator', () => {
_id: 'my-cool-id',
_index: 'my-cool-index',
_version: 4,
_score: 1,
fields: {
product: 'coconut',
category: [`cool`, `rad`],
Expand Down Expand Up @@ -1570,6 +1576,7 @@ describe('CsvGenerator', () => {
range(0, 5).map(() => ({
_index: 'lasdf',
_id: 'lasdf123',
_score: 1,
fields: {
date: ['2020-12-31T00:14:28.000Z'],
ip: ['110.135.176.89'],
Expand Down
6 changes: 5 additions & 1 deletion src/platform/packages/private/kbn-generate-csv/src/lib/search_cursor_pit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,10 @@ describe('CSV Export Search Cursor', () => {
});

it('can update internal cursor ID', () => {
cursor.updateIdFromResults({ pit_id: 'very-typical-pit-id', hits: { hits: [] } });
cursor.updateIdFromResults({
pit_id: 'very-typical-pit-id',
hits: { max_score: null, hits: [] },
});
expect(cursor.getCursorId()).toBe('very-typical-pit-id');
});

Expand All @@ -123,6 +126,7 @@ describe('CSV Export Search Cursor', () => {
{
_index: 'test-index',
_id: 'test-doc-id',
_score: 1,
sort: ['Wed Jan 17 15:35:47 MST 2024', 42],
},
]);
Expand Down
8 changes: 4 additions & 4 deletions src/platform/packages/shared/kbn-discover-utils/src/utils/calc_field_counts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import { buildDataTableRecord } from './build_data_record';
describe('calcFieldCounts', () => {
test('returns valid field count data', async () => {
const rows = [
{ _id: '1', _index: 'test', _source: { message: 'test1', bytes: 20 } },
{ _id: '2', _index: 'test', _source: { name: 'test2', extension: 'jpg' } },
{ _id: '1', _index: 'test', _score: 1, _source: { message: 'test1', bytes: 20 } },
{ _id: '2', _index: 'test', _score: 1, _source: { name: 'test2', extension: 'jpg' } },
].map((row) => buildDataTableRecord(row));
const result = calcFieldCounts(rows);
expect(result).toMatchInlineSnapshot(`
Expand All @@ -28,8 +28,8 @@ describe('calcFieldCounts', () => {
});
test('updates field count data', async () => {
const rows = [
{ _id: '1', _index: 'test', _source: { message: 'test1', bytes: 20 } },
{ _id: '2', _index: 'test', _source: { name: 'test2', extension: 'jpg' } },
{ _id: '1', _index: 'test', _score: 1, _source: { message: 'test1', bytes: 20 } },
{ _id: '2', _index: 'test', _score: 1, _source: { name: 'test2', extension: 'jpg' } },
].map((row) => buildDataTableRecord(row));
const result = calcFieldCounts(rows);
expect(result).toMatchInlineSnapshot(`
Expand Down
6 changes: 3 additions & 3 deletions src/platform/packages/shared/kbn-discover-utils/src/utils/convert_value_to_string.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('convertValueToString', () => {
flattenedValue: 'test',
dataTableRecord: {
id: '1',
raw: {},
raw: { _score: 1 },
flattened: { testKey: 'testValue' },
},
fieldFormats: fieldFormatsMock,
Expand All @@ -83,7 +83,7 @@ describe('convertValueToString', () => {
flattenedValue: ['value1', 'value2'],
dataTableRecord: {
id: '1',
raw: {},
raw: { _score: 1 },
flattened: { testKey: 'testValue' },
},
fieldFormats: fieldFormatsMock,
Expand All @@ -107,7 +107,7 @@ describe('convertValueToString', () => {
flattenedValue: 'value',
dataTableRecord: {
id: '1',
raw: {},
raw: { _score: 1 },
flattened: { testKey: 'testValue' },
},
fieldFormats: fieldFormatsMock,
Expand Down
2 changes: 2 additions & 0 deletions src/platform/packages/shared/kbn-discover-utils/src/utils/format_hit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ describe('formatHit', () => {
hit = {
_id: '1',
_index: 'logs',
_score: 1,
fields: {
message: ['foobar'],
extension: ['png'],
Expand Down Expand Up @@ -111,6 +112,7 @@ describe('formatHit', () => {
{
_id: '2',
_index: 'logs',
_score: 1,
fields: {
object: ['object'],
'object.value': [42, 13],
Expand Down
1 change: 1 addition & 0 deletions src/platform/packages/shared/kbn-discover-utils/src/utils/format_value.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const services = {
const hit = {
_id: '1',
_index: 'index',
_score: 1,
fields: {
message: 'foo',
},
Expand Down
2 changes: 1 addition & 1 deletion src/platform/packages/shared/kbn-discover-utils/src/utils/get_field_value.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { getFieldValue } from './get_field_value';

const dataTableRecord: DataTableRecord = {
id: '1',
raw: {},
raw: { _score: 1 },
flattened: {
'field1.value': 'value1',
'field2.value': ['value2'],
Expand Down
2 changes: 1 addition & 1 deletion src/platform/packages/shared/kbn-discover-utils/src/utils/get_formatted_fields.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('getFormattedFields', () => {
field3: null,
field4: undefined,
},
raw: {},
raw: { _score: 1 },
};

beforeEach(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/platform/packages/shared/kbn-search-response-warnings/src/extract_warnings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe('extract search response warnings', () => {
took: 999,
timed_out: true,
_shards: {} as estypes.ShardStatistics,
hits: { hits: [] },
hits: { max_score: null, hits: [] },
};
expect(
extractWarnings(response, mockInspectorService, mockRequestAdapter, 'My request')
Expand Down
6 changes: 3 additions & 3 deletions src/platform/packages/shared/kbn-search-response-warnings/src/handle_warnings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('handleWarnings', () => {
took: 999,
timed_out: true,
_shards: {} as estypes.ShardStatistics,
hits: { hits: [] },
hits: { max_score: null, hits: [] },
} as estypes.SearchResponse,
services: {
inspector: {} as unknown as InspectorStart,
Expand All @@ -75,7 +75,7 @@ describe('handleWarnings', () => {
took: 999,
timed_out: true,
_shards: {} as estypes.ShardStatistics,
hits: { hits: [] },
hits: { max_score: null, hits: [] },
} as estypes.SearchResponse,
services: {
inspector: {} as unknown as InspectorStart,
Expand All @@ -99,7 +99,7 @@ describe('handleWarnings', () => {
took: 999,
timed_out: true,
_shards: {} as estypes.ShardStatistics,
hits: { hits: [] },
hits: { max_score: null, hits: [] },
} as estypes.SearchResponse,
services: {
inspector: {} as unknown as InspectorStart,
Expand Down
5 changes: 5 additions & 0 deletions src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,7 @@ describe('UnifiedDataTable', () => {
id: 'test',
raw: {
_index: 'test_i',
_score: 1,
_id: 'test',
},
flattened: { test: jest.fn() },
Expand Down Expand Up @@ -816,6 +817,7 @@ describe('UnifiedDataTable', () => {
id: 'test',
raw: {
_index: 'test_i',
_score: 1,
_id: 'test',
},
flattened: { test: jest.fn() },
Expand Down Expand Up @@ -845,6 +847,7 @@ describe('UnifiedDataTable', () => {
id: 'test',
raw: {
_index: 'test_i',
_score: 1,
_id: 'test',
},
flattened: { test: jest.fn() },
Expand All @@ -868,6 +871,7 @@ describe('UnifiedDataTable', () => {
id: 'test',
raw: {
_index: 'test_i',
_score: 1,
_id: 'test',
},
flattened: { test: jest.fn() },
Expand Down Expand Up @@ -983,6 +987,7 @@ describe('UnifiedDataTable', () => {
id: 'test',
raw: {
_index: 'test_i',
_score: 1,
_id: 'test',
},
flattened: { test: jest.fn() },
Expand Down
2 changes: 2 additions & 0 deletions ...kages/shared/kbn-unified-data-table/src/components/data_table_document_selection.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ describe('document selection', () => {
const doc = {
_id: 'test-id',
_index: 'test-indices',
_score: 1,
_routing: 'why-not',
};
expect(getDocId(doc)).toMatchInlineSnapshot(`"test-indices::test-id::why-not"`);
Expand All @@ -44,6 +45,7 @@ describe('document selection', () => {
const doc = {
_id: 'test-id',
_index: 'test-indices',
_score: 1,
};
expect(getDocId(doc)).toMatchInlineSnapshot(`"test-indices::test-id::"`);
});
Expand Down
4 changes: 2 additions & 2 deletions ...form/packages/shared/kbn-unified-doc-viewer/src/components/doc_viewer/doc_viewer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describe('<DocViewer />', () => {
},
});
const renderProps = {
hit: buildDataTableRecord({ _index: 't', _id: '1' }),
hit: buildDataTableRecord({ _index: 't', _score: 1, _id: '1' }),
} as DocViewRenderProps;
render(<WrappedDocViewer docViews={registry.getAll()} {...renderProps} />);
expect(screen.getByTestId('sectionErrorBoundaryPromptBody')).toBeInTheDocument();
Expand All @@ -106,7 +106,7 @@ describe('<DocViewer />', () => {
},
});
const renderProps = {
hit: buildDataTableRecord({ _index: 't', _id: '1' }),
hit: buildDataTableRecord({ _index: 't', _score: 1, _id: '1' }),
} as DocViewRenderProps;
render(<WrappedDocViewer docViews={registry.getAll()} {...renderProps} />);
expect(screen.queryByTestId('sectionErrorBoundaryPromptBody')).not.toBeInTheDocument();
Expand Down
10 changes: 5 additions & 5 deletions ...lic/components/doc_viewer_logs_overview/sub_components/stacktrace/apm_stacktrace.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('APM Stacktrace component', () => {
const comp = mountWithIntl(
<ApmStacktrace
hit={{
raw: { _id: '1', _index: 'index1' },
raw: { _id: '1', _score: 1, _index: 'index1' },
flattened: {},
id: '',
}}
Expand All @@ -46,7 +46,7 @@ describe('APM Stacktrace component', () => {
const comp = mountWithIntl(
<ApmStacktrace
hit={{
raw: { _id: '1', _index: 'index1' },
raw: { _id: '1', _score: 1, _index: 'index1' },
flattened: {},
id: '',
}}
Expand Down Expand Up @@ -100,7 +100,7 @@ describe('APM Stacktrace component', () => {
<EuiThemeProvider>
<ApmStacktrace
hit={{
raw: { _id: '1', _index: 'index1' },
raw: { _id: '1', _score: 1, _index: 'index1' },
flattened: {},
id: '',
}}
Expand Down Expand Up @@ -167,7 +167,7 @@ describe('APM Stacktrace component', () => {
<EuiThemeProvider>
<ApmStacktrace
hit={{
raw: { _id: '1', _index: 'index1' },
raw: { _id: '1', _score: 1, _index: 'index1' },
flattened: {},
id: '',
}}
Expand Down Expand Up @@ -200,7 +200,7 @@ describe('APM Stacktrace component', () => {
<EuiThemeProvider>
<ApmStacktrace
hit={{
raw: { _id: '1', _index: 'index1' },
raw: { _id: '1', _score: 1, _index: 'index1' },
flattened: {},
id: '',
}}
Expand Down
1 change: 1 addition & 0 deletions ...orm/plugins/shared/unified_doc_viewer/public/components/doc_viewer_source/source.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ describe('Source Viewer component', () => {
const record = {
_index: 'logstash-2014.09.09',
_id: 'id123',
_score: 1,
message: 'Lorem ipsum dolor sit amet',
extension: 'html',
};
Expand Down
1 change: 1 addition & 0 deletions ...ins/shared/unified_doc_viewer/public/components/doc_viewer_table/get_pin_control.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ describe('getPinControl', () => {
_ignored: [],
_index: 'test',
_id: '1',
_score: 1,
_source: {
message: 'test',
},
Expand Down
1 change: 1 addition & 0 deletions .../shared/unified_doc_viewer/public/components/doc_viewer_table/table_cell_actions.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ describe('TableActions', () => {
_ignored: [],
_index: 'test',
_id: '1',
_score: 1,
_source: {
[fieldName]: fieldValue,
},
Expand Down
1 change: 1 addition & 0 deletions ...plugins/shared/unified_doc_viewer/public/components/doc_viewer_table/test_filters.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const hit = buildDataTableRecord(
{
_ignored: [],
_index: 'test',
_score: 1,
_id: '1',
_source: {
'extension.keyword': 'zip',
Expand Down
1 change: 1 addition & 0 deletions ...platform/plugins/private/reporting/server/routes/common/scheduled/scheduled_query.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1347,6 +1347,7 @@ describe('transformResponse', () => {
...lastRunResponse,
hits: {
total: { value: 1, relation: 'eq' },
max_score: lastRunResponse.hits.max_score,
hits: [lastRunResponse.hits.hits[0]],
},
};
Expand Down
Loading