Skip to content

[Dashboard] Prevent duplicate saves when rapidly clicking save button #233573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickofthyme merged 5 commits into from
Sep 4, 2025
Merged

[Dashboard] Prevent duplicate saves when rapidly clicking save button #233573

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b30bc70
Rapidly clicking save button in save dashboard modal when creating a …
kvanerum Aug 31, 2025
ca33e97
Rapidly clicking save button in save dashboard modal when creating a …
kvanerum Aug 31, 2025
9a1619b
Merge remote-tracking branch 'origin/issue-231314' into issue-231314
kvanerum Aug 31, 2025
51ab714
Merge branch 'main' into issue-231314
elasticmachine Sep 2, 2025
e47afef
Merge branch 'main' into issue-231314
elasticmachine Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/platform/plugins/shared/dashboard/public/dashboard_api/save_modal/save_modal.tsx
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme Sep 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this may solve the issue for dashboards but the modal logic is not consistently expecting the onSave call to return a promise all the way up the call stack to the root async function performing the save.

That said I think it's still worth merging this PR and giving @kvanerum credit for the fix until #233933 get reviewed and merged.

Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export const DashboardSaveModal: React.FC<DashboardSaveModalProps> = ({
newCopyOnSave,
isTitleDuplicateConfirmed,
onTitleDuplicate,
}) => {
}) =>
onSave({
newTitle,
newDescription,
Expand All @@ -74,8 +74,7 @@ export const DashboardSaveModal: React.FC<DashboardSaveModalProps> = ({
isTitleDuplicateConfirmed,
onTitleDuplicate,
newTags: selectedTags,
});
},
}),
[onSave, persistSelectedTimeInterval, selectedTags]
);

Expand Down