[NL2ESQL] Improve correcting/formatting of ES|QL processing#233563
[NL2ESQL] Improve correcting/formatting of ES|QL processing#233563dgieselaar merged 3 commits intoelastic:mainfrom
Conversation
|
|
||
| The following processing commands are available: | ||
|
|
||
| [preview] CHANGE_POINT |
There was a problem hiding this comment.
| [preview] CHANGE_POINT | |
| - [preview] CHANGE_POINT |
| The following processing commands are available: | ||
|
|
||
| [preview] CHANGE_POINT | ||
| - [preview] COMPLETION: send prompts and context to an LLM |
There was a problem hiding this comment.
Do we need to update this file too with these modifications? https://github.com/elastic/kibana/blame/main/x-pack/platform/packages/shared/kbn-ai-tools/src/tools/esql/esql_task_description.text/#L6
There was a problem hiding this comment.
no, it's not being used. I have a follow-up PR for that code where I'll incorporate these changes.
qn895
left a comment
There was a problem hiding this comment.
Left some small comments but otherwise LGTM 🎉
💚 Build Succeeded
Metrics [docs]Public APIs missing exports
History
|
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
…233563) - Removes some incorrect fixes wrt strings as function arguments - Support for correcting quotes in `STATS foo = SUM(bar) WHERE my_field == 'value'` - Pretty formatting for errors, using a syntax that is common for parsers - Added support for `TS` command - Added some functions in ES|QL system message
…233563) - Removes some incorrect fixes wrt strings as function arguments - Support for correcting quotes in `STATS foo = SUM(bar) WHERE my_field == 'value'` - Pretty formatting for errors, using a syntax that is common for parsers - Added support for `TS` command - Added some functions in ES|QL system message
- Removes some incorrect fixes wrt strings as function arguments - Support for correcting quotes in `STATS foo = SUM(bar) WHERE my_field == 'value'` - Pretty formatting for errors, using a syntax that is common for parsers - Added support for `TS` command - Added some functions in ES|QL system message
STATS foo = SUM(bar) WHERE my_field == 'value'TScommand