Skip to content

[NL2ESQL] Improve correcting/formatting of ES|QL processing#233563

Merged
dgieselaar merged 3 commits intoelastic:mainfrom
dgieselaar:nl-2-esql-corrections
Sep 7, 2025
Merged

[NL2ESQL] Improve correcting/formatting of ES|QL processing#233563
dgieselaar merged 3 commits intoelastic:mainfrom
dgieselaar:nl-2-esql-corrections

Conversation

@dgieselaar
Copy link
Contributor

  • Removes some incorrect fixes wrt strings as function arguments
  • Support for correcting quotes in STATS foo = SUM(bar) WHERE my_field == 'value'
  • Pretty formatting for errors, using a syntax that is common for parsers
  • Added support for TS command
  • Added some functions in ES|QL system message

@dgieselaar dgieselaar requested a review from a team as a code owner August 30, 2025 10:46
@dgieselaar dgieselaar added backport:version Backport to applied version labels v9.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 30, 2025

The following processing commands are available:

[preview] CHANGE_POINT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[preview] CHANGE_POINT
- [preview] CHANGE_POINT

The following processing commands are available:

[preview] CHANGE_POINT
- [preview] COMPLETION: send prompts and context to an LLM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's not being used. I have a follow-up PR for that code where I'll incorporate these changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks 👍

Copy link
Member

@qn895 qn895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments but otherwise LGTM 🎉

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
inference 8 9 +1

History

@dgieselaar dgieselaar merged commit 39b56fb into elastic:main Sep 7, 2025
13 checks passed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 9, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233563 locally
cc: @dgieselaar

@dgieselaar dgieselaar added the backport:skip This PR does not require backporting label Sep 9, 2025
@dgieselaar dgieselaar deleted the nl-2-esql-corrections branch September 9, 2025 14:54
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 9, 2025
KodeRad pushed a commit to KodeRad/kibana that referenced this pull request Sep 15, 2025
…233563)

- Removes some incorrect fixes wrt strings as function arguments
- Support for correcting quotes in `STATS foo = SUM(bar) WHERE my_field
== 'value'`
- Pretty formatting for errors, using a syntax that is common for
parsers
- Added support for `TS` command
- Added some functions in ES|QL system message
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
…233563)

- Removes some incorrect fixes wrt strings as function arguments
- Support for correcting quotes in `STATS foo = SUM(bar) WHERE my_field
== 'value'`
- Pretty formatting for errors, using a syntax that is common for
parsers
- Added support for `TS` command
- Added some functions in ES|QL system message
niros1 pushed a commit that referenced this pull request Sep 30, 2025
- Removes some incorrect fixes wrt strings as function arguments
- Support for correcting quotes in `STATS foo = SUM(bar) WHERE my_field
== 'value'`
- Pretty formatting for errors, using a syntax that is common for
parsers
- Added support for `TS` command
- Added some functions in ES|QL system message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants