[dashboard] update dashboard CRUD APIs to accept and return tags as an array of tag saved object ids by nreese · Pull Request #233541 · elastic/kibana

nreese · 2025-08-29T20:53:52Z

#214788 updated dashboard CRUD API read attributes.tags as an array of tag names and write attributes.tags as an array of tag names. Returning attributes.tags as an array of tag names breaks the link between the tag saved object. Instead, attributes.tags should be an array of tag ids.

#214788 updated dashboard CRUD API with a side effect where if a tag saved object did not exist for a tag name, then a tag saved object would be created for the tag name. APIs should not have side effects like this.

This PR updates dashboard CRUD API read attributes.tags as an array of tag ids and write attributes.tags as an array of tag ids to avoid breaking the link between tag saved objects. The PR also removes the ability for the dashboard CRUD APIs to create tag saved objects.

nreese · 2025-08-29T21:06:51Z

/ci

nreese · 2025-09-01T14:43:06Z

@elasticmachine merge upstream

nreese · 2025-09-01T14:45:05Z

/ci

nreese · 2025-09-02T16:27:53Z

/ci

nreese · 2025-09-02T17:57:14Z

/ci

nreese · 2025-09-02T19:43:14Z

/ci

elasticmachine · 2025-09-02T23:07:30Z

Pinging @elastic/kibana-presentation (Team:Presentation)

nreese · 2025-09-04T14:06:34Z

@elasticmachine merge upstream

ThomThomson

Great work & cleanup. It's good to keep the code clean by removing features that aren't in the main value-path. I'm especially happy with the fact that the transform can be synchronous now.

ThomThomson · 2025-09-04T14:27:33Z

src/platform/plugins/shared/dashboard/server/content_management/dashboard_storage.ts

      references: soReferences,
      error: transformDashboardError,
-    } = await transformDashboardIn({
+    } = transformDashboardIn({


Hopefully we can keep this synchronous from now on!

ThomThomson · 2025-09-04T14:28:09Z

...lugins/shared/dashboard/server/content_management/v1/transforms/in/transform_dashboard_in.ts

+    });
+
+    // TODO - remove once all references are provided server side
+    const nonTagIncomingReferences = incomingReferences.filter(


Good to keep these separately!

ThomThomson · 2025-09-04T14:28:45Z

...lugins/shared/dashboard/server/content_management/v1/transforms/in/transform_tags_in.test.ts

+
+import { transformTagsIn } from './transform_tags_in';
+
+describe('transformTagsIn', () => {


Nice simple tests!

…no-cache --fix'

elasticmachine · 2025-09-22T21:22:31Z

💚 Build Succeeded

Buildkite Build
Commit: b4c4544

Metrics [docs]

✅ unchanged

History

💚 Build #335103 succeeded 36c049e
💔 Build #335078 failed 359131a
💔 Build #335051 failed 2df0938
💔 Build #334679 failed 0e0a5ed
💔 Build #334286 failed ccf2e4b

…n array of tag saved object ids (elastic#233541) Part of elastic#216346 elastic#214788 updated dashboard CRUD API read `attributes.tags` as an array of tag names and write `attributes.tags` as an array of tag names. Returning `attributes.tags` as an array of tag names breaks the link between the tag saved object. Instead, `attributes.tags` should be an array of tag ids. elastic#214788 updated dashboard CRUD API with a side effect where if a tag saved object did not exist for a tag name, then a tag saved object would be created for the tag name. APIs should not have side effects like this. This PR updates dashboard CRUD API read `attributes.tags` as an array of tag ids and write `attributes.tags` as an array of tag ids to avoid breaking the link between tag saved objects. The PR also removes the ability for the dashboard CRUD APIs to create tag saved objects. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…n array of tag saved object ids (#233541) Part of #216346 #214788 updated dashboard CRUD API read `attributes.tags` as an array of tag names and write `attributes.tags` as an array of tag names. Returning `attributes.tags` as an array of tag names breaks the link between the tag saved object. Instead, `attributes.tags` should be an array of tag ids. #214788 updated dashboard CRUD API with a side effect where if a tag saved object did not exist for a tag name, then a tag saved object would be created for the tag name. APIs should not have side effects like this. This PR updates dashboard CRUD API read `attributes.tags` as an array of tag ids and write `attributes.tags` as an array of tag ids to avoid breaking the link between tag saved objects. The PR also removes the ability for the dashboard CRUD APIs to create tag saved objects. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…n array of tag saved object ids (elastic#233541) Part of elastic#216346 elastic#214788 updated dashboard CRUD API read `attributes.tags` as an array of tag names and write `attributes.tags` as an array of tag names. Returning `attributes.tags` as an array of tag names breaks the link between the tag saved object. Instead, `attributes.tags` should be an array of tag ids. elastic#214788 updated dashboard CRUD API with a side effect where if a tag saved object did not exist for a tag name, then a tag saved object would be created for the tag name. APIs should not have side effects like this. This PR updates dashboard CRUD API read `attributes.tags` as an array of tag ids and write `attributes.tags` as an array of tag ids to avoid breaking the link between tag saved objects. The PR also removes the ability for the dashboard CRUD APIs to create tag saved objects. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

nreese added 2 commits August 29, 2025 14:53

[dashboard] tag ids

babc32a

add more test cases

ccf2e4b

nreese changed the title ~~[dashboard] tag ids~~ [dashboard] update dashboard CRUD APIs to accept and return tags as an array of tag saved object ids Aug 29, 2025

elasticmachine and others added 2 commits September 1, 2025 16:43

Merge branch 'main' into dashboard_tags

e5e7318

remove tags integration test

0e0a5ed

avoid dropping references

2df0938

remove inject tag names test

359131a

remove update tags test

36c049e

nreese marked this pull request as ready for review September 2, 2025 23:07

nreese requested a review from a team as a code owner September 2, 2025 23:07

nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// backport:skip This PR does not require backporting Project:Dashboards API v9.2.0 labels Sep 2, 2025

nreese added the release_note:skip Skip the PR/issue when compiling release notes label Sep 2, 2025

Merge branch 'main' into dashboard_tags

91adf22

ThomThomson self-requested a review September 4, 2025 14:25

ThomThomson approved these changes Sep 4, 2025

View reviewed changes

ThomThomson mentioned this pull request Sep 18, 2025

[Dashboards as code] Dashboard client should send tags as array rather than extracting references #216346

Closed

nreese and others added 2 commits September 22, 2025 13:19

merge with main

d1c3ffe

[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…

b4c4544

…no-cache --fix'

nreese merged commit 09e3349 into elastic:main Sep 23, 2025
12 checks passed


		import { transformTagsIn } from './transform_tags_in';

		describe('transformTagsIn', () => {

Conversation

nreese commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented Aug 29, 2025

Uh oh!

nreese commented Sep 1, 2025

Uh oh!

nreese commented Sep 1, 2025

Uh oh!

nreese commented Sep 2, 2025

Uh oh!

nreese commented Sep 2, 2025

Uh oh!

nreese commented Sep 2, 2025

Uh oh!

elasticmachine commented Sep 2, 2025

Uh oh!

nreese commented Sep 4, 2025

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

ThomThomson Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

ThomThomson Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 22, 2025

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nreese commented Aug 29, 2025 •

edited

Loading