Skip to content

[8.19] [Security Solution] [Detections] Fix flakey EQL shard test (#215757) #233535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rylnd merged 3 commits into from
Aug 29, 2025
Merged

[8.19] [Security Solution] [Detections] Fix flakey EQL shard test (#215757) #233535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
140d1ee
[Security Solution] [Detections] Fix flakey EQL shard test (#215757)
dhurley14 Mar 28, 2025
5032b82
Fix errant test descriptions
rylnd Aug 29, 2025
e51efc1
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 21 additions & 22 deletions ...ons_response/detection_engine/rule_execution_logic/eql/trial_license_complete_tier/eql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ import {
deleteAllRules,
deleteAllAlerts,
waitForRuleFailure,
waitForRulePartialFailure,
routeWithNamespace,
} from '../../../../../../../common/utils/security_solution';
import { FtrProviderContext } from '../../../../../../ftr_provider_context';
Expand Down Expand Up @@ -254,30 +253,30 @@ export default ({ getService }: FtrProviderContext) => {

it('parses shard failures for EQL event query', async () => {
await esArchiver.load(packetBeatPath);
await setBrokenRuntimeField({ es, index: 'packetbeat-*' });

// sometimes we would hit max signals on the good shard
// and never search the shard with the bad runtime field
// by changing the logic to be "and" broken == 1
// we ensure that both shards are searched
// which I believe was the cause of the test being flakey.
const rule: EqlRuleCreateProps = {
...getEqlRuleForAlertTesting(['auditbeat-*', 'packetbeat-*']),
query: 'any where agent.type == "packetbeat" or broken == 1',
query: 'any where agent.type == "packetbeat" and broken == 1',
};
await setBrokenRuntimeField({ es, index: 'auditbeat-*' });
const createdRule = await createRule(supertest, log, rule);
const createdRuleId = createdRule.id;
await waitForRulePartialFailure({ supertest, log, id: createdRuleId });
const route = routeWithNamespace(DETECTION_ENGINE_RULES_URL);
const response = await supertest
.get(route)
.set('kbn-xsrf', 'true')
.set('elastic-api-version', '2023-10-31')
.query({ id: createdRule.id })
.expect(200);

const ruleResponse = response.body;
expect(
ruleResponse.execution_summary.last_execution.message.includes(
'The EQL event query was only executed on the available shards. The query failed to run successfully on the following shards:'
)
).eql(true);

await unsetBrokenRuntimeField({ es, index: 'auditbeat-*' });
const { logs } = await previewRule({ supertest, rule });
expect_(logs).toEqual(
expect_.arrayContaining([
expect_.objectContaining({
warnings: expect_.arrayContaining([
expect_.stringContaining(
'The EQL event query was only executed on the available shards. The query failed to run successfully on the following shards:'
),
]),
}),
])
);
await unsetBrokenRuntimeField({ es, index: 'packetbeat-*' });
await esArchiver.unload(packetBeatPath);
});

Expand Down
6 changes: 6 additions & 0 deletions ...k/test/security_solution_api_integration/test_suites/detections_response/utils/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export const setBrokenRuntimeField = async ({ es, index }: UpdateMappingsProps)
},
index,
});
await es.indices.refresh({
index,
});
};

export const unsetBrokenRuntimeField = async ({ es, index }: UpdateMappingsProps) => {
Expand All @@ -36,4 +39,7 @@ export const unsetBrokenRuntimeField = async ({ es, index }: UpdateMappingsProps
},
index,
});
await es.indices.refresh({
index,
});
};