[Logs UX] Fix codeql and buildkite pipeline issue#233455
Merged
achyutjhunjhunwala merged 11 commits intoelastic:mainfrom Aug 29, 2025
Merged
[Logs UX] Fix codeql and buildkite pipeline issue#233455achyutjhunjhunwala merged 11 commits intoelastic:mainfrom
achyutjhunjhunwala merged 11 commits intoelastic:mainfrom
Conversation
achyutjhunjhunwala
added
the
release_note:skip
achyutjhunjhunwala
added
backport:skip
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
achyutjhunjhunwala
deleted the
fix-codeql-issues-and-buildkite-pipeline
branch
ymao1
pushed a commit
to ymao1/kibana
that referenced
this pull request
Aug 29, 2025
## Summary closes - elastic/kibana-team#1960 (comment) This PR resolves two critical issues -: 1. Security: [Fixed CodeQL security alerts for incomplete string sanitisation](elastic/kibana-team#1960 (comment)) 2. [CI/CD: Fixed Docker permission denied errors in Buildkite pipeline](https://buildkite.com/elastic/kibana-opentelemetry-semantic-conventions-sync/builds/3/steps/table?jid=0198f539-82a8-4fb2-9be9-f6704960a5a8) Changes Made 🔒 Security Fix - String Escaping - File: src/platform/packages/shared/kbn-otel-semantic-conventions/src/generate.ts - Issue: CodeQL flagged incomplete sanitization on lines 31, 32, 33, and 38 - Fix: Updated string escaping to properly handle both backslashes and single quotes 🐳 Docker Permission Fix - File: .buildkite/scripts/steps/otel_semconv_sync.sh - Issue: Docker weaver command failing with "Permission denied" when writing output files - Root Cause: User ID mapping conflict between host and container environment - Solution: Pre-create output directory with proper permissions before Docker execution The CI fix is still trial and error. I am discussing with Kibana Ops to see how to better check for such errors
jkelas
pushed a commit
to jkelas/kibana
that referenced
this pull request
Sep 2, 2025
## Summary closes - elastic/kibana-team#1960 (comment) This PR resolves two critical issues -: 1. Security: [Fixed CodeQL security alerts for incomplete string sanitisation](elastic/kibana-team#1960 (comment)) 2. [CI/CD: Fixed Docker permission denied errors in Buildkite pipeline](https://buildkite.com/elastic/kibana-opentelemetry-semantic-conventions-sync/builds/3/steps/table?jid=0198f539-82a8-4fb2-9be9-f6704960a5a8) Changes Made 🔒 Security Fix - String Escaping - File: src/platform/packages/shared/kbn-otel-semantic-conventions/src/generate.ts - Issue: CodeQL flagged incomplete sanitization on lines 31, 32, 33, and 38 - Fix: Updated string escaping to properly handle both backslashes and single quotes 🐳 Docker Permission Fix - File: .buildkite/scripts/steps/otel_semconv_sync.sh - Issue: Docker weaver command failing with "Permission denied" when writing output files - Root Cause: User ID mapping conflict between host and container environment - Solution: Pre-create output directory with proper permissions before Docker execution The CI fix is still trial and error. I am discussing with Kibana Ops to see how to better check for such errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes - https://github.com/elastic/kibana-team/issues/1960#issuecomment-3236355328
This PR resolves two critical issues -:
Changes Made
🔒 Security Fix - String Escaping
🐳 Docker Permission Fix
The CI fix is still trial and error. I am discussing with Kibana Ops to see how to better check for such errors