Skip to content

[Security Solution][AI Assistant] Revert conversation mappings changes#233428

Merged
spong merged 3 commits intoelastic:mainfrom
e40pud:security/genai/conversations/revert-mappings
Aug 29, 2025
Merged

[Security Solution][AI Assistant] Revert conversation mappings changes#233428
spong merged 3 commits intoelastic:mainfrom
e40pud:security/genai/conversations/revert-mappings

Conversation

@e40pud
Copy link
Contributor

@e40pud e40pud commented Aug 29, 2025

Summary

Epic: https://github.com/elastic/security-team/issues/12768
Meta: https://github.com/elastic/security-team/issues/13657
RFC: internal link

This PR reverts conversation mappings changes introduced in #232288. Since we decided to put on hold the Using Past Conversation as Context feature, we decided to remove added summary field backed by the semantic_text field to avoid potential issues that users mights have when updating a conversation while the inference endpoint is not available.

Changes:

  • Removed mapping fields: semantic_content and summarized_message_ids
  • As part of these changes, the summary field was hidden on the API level and conversations response object won't have it anymore

@e40pud e40pud added this to the 9.2 milestone Aug 29, 2025
@e40pud e40pud self-assigned this Aug 29, 2025
@e40pud e40pud added the release_note:skip Skip the PR/issue when compiling release notes label Aug 29, 2025
@e40pud e40pud requested a review from a team as a code owner August 29, 2025 07:44
@e40pud e40pud added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI backport:version Backport to applied version labels v9.2.0 labels Aug 29, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@e40pud e40pud requested a review from spong August 29, 2025 07:44
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner August 29, 2025 08:19
array: false,
required: false,
},
'summary.content': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we will still keep this in the field map for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the old mapping fields that we have to keep regardless whether we add new fields or not. They've been added to these mapping since beginning and will need to stay there for compatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my previous PR, I moved these fields into a separate section, but now reverting to an original state.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/elastic-assistant-common 688 681 -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.2MB 10.2MB -249.0B
Unknown metric groups

API count

id before after diff
@kbn/elastic-assistant-common 804 796 -8

cc @e40pud

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair reviewed -- thanks for the updates here @e40pud! LGTM! 👍

@spong spong merged commit a5a93f3 into elastic:main Aug 29, 2025
12 checks passed
ymao1 pushed a commit to ymao1/kibana that referenced this pull request Aug 29, 2025
elastic#233428)

## Summary

Epic: elastic/security-team#12768
Meta: elastic/security-team#13657
RFC: [internal
link](https://docs.google.com/document/d/13jAJ5Q3_At_zAuwKjvpYehnM5uzKJSwZIZ1aJJNAf5k)

This PR reverts conversation mappings changes introduced in
elastic#232288. Since we decided to put
on hold the Using Past Conversation as Context feature, we decided to
remove added summary field backed by the `semantic_text` field to avoid
potential issues that users mights have when updating a conversation
while the inference endpoint is not available.

**Changes**:
* Removed mapping fields: `semantic_content` and
`summarized_message_ids`
* As part of these changes, the `summary` field was hidden on the API
level and conversations response object won't have it anymore

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
jkelas pushed a commit to jkelas/kibana that referenced this pull request Sep 2, 2025
elastic#233428)

## Summary

Epic: elastic/security-team#12768
Meta: elastic/security-team#13657
RFC: [internal
link](https://docs.google.com/document/d/13jAJ5Q3_At_zAuwKjvpYehnM5uzKJSwZIZ1aJJNAf5k)

This PR reverts conversation mappings changes introduced in
elastic#232288. Since we decided to put
on hold the Using Past Conversation as Context feature, we decided to
remove added summary field backed by the `semantic_text` field to avoid
potential issues that users mights have when updating a conversation
while the inference endpoint is not available.

**Changes**:
* Removed mapping fields: `semantic_content` and
`summarized_message_ids`
* As part of these changes, the `summary` field was hidden on the API
level and conversations response object won't have it anymore

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 2, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233428 locally
cc: @e40pud

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233428 locally
cc: @e40pud

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233428 locally
cc: @e40pud

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233428 locally
cc: @e40pud

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233428 locally
cc: @e40pud

@e40pud e40pud added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Sep 9, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants