[Data set quality] Fix error for stateful in updateFailureStore#233292
Merged
SoniaSanzV merged 1 commit intoelastic:mainfrom Aug 28, 2025
Merged
[Data set quality] Fix error for stateful in updateFailureStore#233292SoniaSanzV merged 1 commit intoelastic:mainfrom
SoniaSanzV merged 1 commit intoelastic:mainfrom
Conversation
SoniaSanzV
added
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
Contributor
|
An screenshot with also the end object when a customPeriod is set would be very helpful, so we can see all the cases in the description |
Contributor
Author
Sure! Added to the PR description! |
yngrdyn
reviewed
Aug 28, 2025
...form/plugins/shared/dataset_quality/server/routes/data_streams/update_failure_store/index.ts
Show resolved
Hide resolved
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Sep 2, 2025
…tic#233292) ## Summary I did an error when implementing elastic#231846. In Stateful, when a data stream has the failure retention period set to default, I set the lifecycle to enabled: false, which is wrong. This is the config for a data stream with failure store enabled by default (before interacting with the modal). <img width="706" height="326" alt="Screenshot 2025-08-28 at 12 03 44" src="https://github.com/user-attachments/assets/4a0f78d9-f593-4b7c-bfe1-ee7c7eb90aeb" /> Before this PR: The lifecycle is set to false when no custom retention period, so the retention is not determined by the default value, which is incorrect: <img width="636" height="287" alt="Screenshot 2025-08-28 at 12 04 37" src="https://github.com/user-attachments/assets/387f423f-e3cf-4864-9508-124a60fcc38e" /> With this change: The enabled lifecycle is determined by the enabled fault storage and not by a customRetentionPeriod being assigned. <img width="688" height="321" alt="Screenshot 2025-08-28 at 12 05 45" src="https://github.com/user-attachments/assets/7b05b988-96ac-4fd2-a0d3-bbe1663ba926" /> With customPeriod: <img width="619" height="346" alt="Screenshot 2025-08-28 at 12 27 33" src="https://github.com/user-attachments/assets/1d2d2846-7399-42cd-9f5d-fe96f0b09adc" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I did an error when implementing #231846. In Stateful, when a data stream has the failure retention period set to default, I set the lifecycle to enabled: false, which is wrong. This is the config for a data stream with failure store enabled by default (before interacting with the modal).
Before this PR: The lifecycle is set to false when no custom retention period, so the retention is not determined by the default value, which is incorrect:
With this change: The enabled lifecycle is determined by the enabled fault storage and not by a customRetentionPeriod being assigned.
With customPeriod:
