Skip to content

[9.1] fix: [Analytics:Visualize Library: Create page]Missing state change announcement for switch button (#232983) #233148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Aug 27, 2025
Merged

[9.1] fix: [Analytics:Visualize Library: Create page]Missing state change announcement for switch button (#232983) #233148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import React from 'react';
import { renderWithReduxStore } from '../mocks';
import { SettingsMenu } from './settings_menu';
import { screen, waitFor } from '@testing-library/react';
import { screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';

describe('settings menu', () => {
Expand Down Expand Up @@ -41,17 +41,6 @@ describe('settings menu', () => {
};
};

afterEach(() => {
onCloseMock.mockClear();
});

it('should call onClose when popover closes after toggling', async () => {
const { toggleAutoApply } = renderSettingsMenu();
await toggleAutoApply();

await waitFor(() => expect(onCloseMock).toHaveBeenCalledTimes(1));
});

it('should toggle auto-apply', async () => {
const { toggleAutoApply, isAutoApplyOn } = renderSettingsMenu();

Expand Down
3 changes: 1 addition & 2 deletions x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,13 @@ export function SettingsMenu({
const dispatch = useLensDispatch();

const toggleAutoApply = useCallback(() => {
onClose();
writeToStorage(
new Storage(localStorage),
AUTO_APPLY_DISABLED_STORAGE_KEY,
String(autoApplyEnabled)
);
dispatch(autoApplyEnabled ? disableAutoApply() : enableAutoApply());
}, [dispatch, autoApplyEnabled, onClose]);
}, [dispatch, autoApplyEnabled]);

return (
<EuiWrappingPopover
Expand Down