[Security Solution] [Alerts] Fix deprecated pageNames with redirects#232558
Merged
kqualters-elastic merged 2 commits intoelastic:mainfrom Aug 25, 2025
Merged
[Security Solution] [Alerts] Fix deprecated pageNames with redirects#232558kqualters-elastic merged 2 commits intoelastic:mainfrom
kqualters-elastic merged 2 commits intoelastic:mainfrom
Conversation
kqualters-elastic
added
release_note:fix
backport:version
michaelolo24
approved these changes
Aug 22, 2025
Contributor
michaelolo24
left a comment
michaelolo24
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Contributor
|
Starting backport for target branches: 8.19, 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/17204356821 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 25, 2025
…lastic#232558) ## Summary Related issue: elastic#232557 This pr fixes an issue where deprecated pages that are not registered with the global navigation and search, as the now deprecated app/security/detections/* routes are, but did have custom redirect logic with react router components, stopped working as a result of a recent change elastic#217890 that prevented any of this logic from running if the route was not registered globally, "useLinkInfo" is the hook below that checks this. Alert actions use an older url, app/security/detections/rules/id/{ruleId}, and redirect at the application level to the new url app/security/rules/id/{ruleId} and so this pr explicitly excludes the old route from this check, because we should also continue to not show a detections result in the global search bar that just redirects to the alerts page. Open to doing this in another way if we want, but this seemed the most direct and lowest friction way to make this core functionality work again. Before:  After:  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit c4d6fba)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 25, 2025
…rects (#232558) (#232748) # Backport This will backport the following commits from `main` to `9.1`: - [[Security Solution] [Alerts] Fix deprecated pageNames with redirects (#232558)](#232558) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-08-25T09:05:19Z","message":"[Security Solution] [Alerts] Fix deprecated pageNames with redirects (#232558)\n\n## Summary\n\nRelated issue: https://github.com/elastic/kibana/issues/232557\n\nThis pr fixes an issue where deprecated pages that are not registered\nwith the global navigation and search, as the now deprecated\napp/security/detections/* routes are, but did have custom redirect logic\nwith react router components, stopped working as a result of a recent\nchange #217890 that prevented any\nof this logic from running if the route was not registered globally,\n\"useLinkInfo\" is the hook below that checks this. Alert actions use an\nolder url, app/security/detections/rules/id/{ruleId}, and redirect at\nthe application level to the new url app/security/rules/id/{ruleId} and\nso this pr explicitly excludes the old route from this check, because we\nshould also continue to not show a detections result in the global\nsearch bar that just redirects to the alerts page. Open to doing this in\nanother way if we want, but this seemed the most direct and lowest\nfriction way to make this core functionality work again.\n\nBefore:\n\n\n\n\nAfter:\n\n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"c4d6fbace44838293a553e9ac40ba0db9db8cc15","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","v9.2.0","v9.1.3","v8.19.3","v9.0.6"],"title":"[Security Solution] [Alerts] Fix deprecated pageNames with redirects","number":232558,"url":"https://github.com/elastic/kibana/pull/232558","mergeCommit":{"message":"[Security Solution] [Alerts] Fix deprecated pageNames with redirects (#232558)\n\n## Summary\n\nRelated issue: https://github.com/elastic/kibana/issues/232557\n\nThis pr fixes an issue where deprecated pages that are not registered\nwith the global navigation and search, as the now deprecated\napp/security/detections/* routes are, but did have custom redirect logic\nwith react router components, stopped working as a result of a recent\nchange #217890 that prevented any\nof this logic from running if the route was not registered globally,\n\"useLinkInfo\" is the hook below that checks this. Alert actions use an\nolder url, app/security/detections/rules/id/{ruleId}, and redirect at\nthe application level to the new url app/security/rules/id/{ruleId} and\nso this pr explicitly excludes the old route from this check, because we\nshould also continue to not show a detections result in the global\nsearch bar that just redirects to the alerts page. Open to doing this in\nanother way if we want, but this seemed the most direct and lowest\nfriction way to make this core functionality work again.\n\nBefore:\n\n\n\n\nAfter:\n\n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"c4d6fbace44838293a553e9ac40ba0db9db8cc15"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/232558","number":232558,"mergeCommit":{"message":"[Security Solution] [Alerts] Fix deprecated pageNames with redirects (#232558)\n\n## Summary\n\nRelated issue: https://github.com/elastic/kibana/issues/232557\n\nThis pr fixes an issue where deprecated pages that are not registered\nwith the global navigation and search, as the now deprecated\napp/security/detections/* routes are, but did have custom redirect logic\nwith react router components, stopped working as a result of a recent\nchange #217890 that prevented any\nof this logic from running if the route was not registered globally,\n\"useLinkInfo\" is the hook below that checks this. Alert actions use an\nolder url, app/security/detections/rules/id/{ruleId}, and redirect at\nthe application level to the new url app/security/rules/id/{ruleId} and\nso this pr explicitly excludes the old route from this check, because we\nshould also continue to not show a detections result in the global\nsearch bar that just redirects to the alerts page. Open to doing this in\nanother way if we want, but this seemed the most direct and lowest\nfriction way to make this core functionality work again.\n\nBefore:\n\n\n\n\nAfter:\n\n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"c4d6fbace44838293a553e9ac40ba0db9db8cc15"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
…lastic#232558) ## Summary Related issue: elastic#232557 This pr fixes an issue where deprecated pages that are not registered with the global navigation and search, as the now deprecated app/security/detections/* routes are, but did have custom redirect logic with react router components, stopped working as a result of a recent change elastic#217890 that prevented any of this logic from running if the route was not registered globally, "useLinkInfo" is the hook below that checks this. Alert actions use an older url, app/security/detections/rules/id/{ruleId}, and redirect at the application level to the new url app/security/rules/id/{ruleId} and so this pr explicitly excludes the old route from this check, because we should also continue to not show a detections result in the global search bar that just redirects to the alerts page. Open to doing this in another way if we want, but this seemed the most direct and lowest friction way to make this core functionality work again. Before:  After:  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Aug 28, 2025
…lastic#232558) ## Summary Related issue: elastic#232557 This pr fixes an issue where deprecated pages that are not registered with the global navigation and search, as the now deprecated app/security/detections/* routes are, but did have custom redirect logic with react router components, stopped working as a result of a recent change elastic#217890 that prevented any of this logic from running if the route was not registered globally, "useLinkInfo" is the hook below that checks this. Alert actions use an older url, app/security/detections/rules/id/{ruleId}, and redirect at the application level to the new url app/security/rules/id/{ruleId} and so this pr explicitly excludes the old route from this check, because we should also continue to not show a detections result in the global search bar that just redirects to the alerts page. Open to doing this in another way if we want, but this seemed the most direct and lowest friction way to make this core functionality work again. Before:  After:  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #232557
This pr fixes an issue where deprecated pages that are not registered with the global navigation and search, as the now deprecated app/security/detections/* routes are, but did have custom redirect logic with react router components, stopped working as a result of a recent change #217890 that prevented any of this logic from running if the route was not registered globally, "useLinkInfo" is the hook below that checks this. Alert actions use an older url, app/security/detections/rules/id/{ruleId}, and redirect at the application level to the new url app/security/rules/id/{ruleId} and so this pr explicitly excludes the old route from this check, because we should also continue to not show a detections result in the global search bar that just redirects to the alerts page. Open to doing this in another way if we want, but this seemed the most direct and lowest friction way to make this core functionality work again.
Before:
After:
Checklist