[Security Solution][AI Assistant] Update Message schema and interface (#13657)#232394
Merged
e40pud merged 9 commits intoelastic:mainfrom Aug 28, 2025
Merged
Conversation
e40pud
added
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
Contributor
Author
|
/ci |
mdbirnstiehl
approved these changes
Aug 22, 2025
KDKHD
approved these changes
Aug 27, 2025
Member
KDKHD
left a comment
KDKHD
left a comment
There was a problem hiding this comment.
Tested locally and all is working as expected!
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @e40pud |
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
e40pud
removed
the
backport missing
e40pud
added
backport:skip
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Sep 2, 2025
…ce (elastic#13657) (elastic#232394) ## Summary Epic: elastic/security-team#12768 Meta: elastic/security-team#13657 RFC: [internal link](https://docs.google.com/document/d/13jAJ5Q3_At_zAuwKjvpYehnM5uzKJSwZIZ1aJJNAf5k) With these changes we update the conversation `Message` schema by adding a new field `id`. This will allow us to easily refer messages that are summarized. ### New messages All new messages will be added with the `id` field set. ### Existing messages The `id` field for all existing messages will be `undefined` and will be updated whenever a user updates the conversation: - appends new messages - regenerates a last assistant respond In those case above, all messages within the ongoing conversation will be updated and will have a `id` field set. ### Testing scenarios 1. **Existing messages without `id`** - Create conversation with messages in "pre this PR" code (e.g. main branch) - Checkout code from this PR - Check via Dev Tools that messages within the conversations index do not have `id` field set - Add a new message to one of the conversations - Check that all messages within that conversation are updated and `id` field set for all of them 2. **New messages** - Checkout code from this PR - Create a new chat and add new messages - Check via Dev Tools that all messages within the new conversation have `id` field set --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Epic: https://github.com/elastic/security-team/issues/12768
Meta: https://github.com/elastic/security-team/issues/13657
RFC: internal link
With these changes we update the conversation
Messageschema by adding a new fieldid. This will allow us to easily refer messages that are summarized.New messages
All new messages will be added with the
idfield set.Existing messages
The
idfield for all existing messages will beundefinedand will be updated whenever a user updates the conversation:In those case above, all messages within the ongoing conversation will be updated and will have a
idfield set.Testing scenarios
ididfield setidfield set for all of themidfield set