-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[EDR Workflows][Device Control] Trusted Devices cypress coverage #232269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
szwarckonrad
merged 165 commits into
elastic:main
from
szwarckonrad:device-control-cypress
Aug 28, 2025
Merged
Changes from all commits
Commits
Show all changes
165 commits
Select commit
Hold shift + click to select a range
4d405a0
feat: add trusted devices feature flag and role
szwarckonrad 254e119
feat: add dedicated product feature key for Trusted Devices management
szwarckonrad f1206c1
Merge branch 'main' into device-control-rbac
szwarckonrad b4a07ca
Merge branch 'main' into device-control-rbac
szwarckonrad b187040
Merge branch 'device-control-rbac' of https://github.com/szwarckonrad…
szwarckonrad 168132c
Merge branch 'main' into device-control-rbac
szwarckonrad 298cffc
feat: add USB device protection card with enterprise license check
szwarckonrad b231c5f
refactor: rename and update Device Control card component
szwarckonrad fabb491
Merge branch 'main' into device-control-rbac
szwarckonrad 0662df5
Merge branch 'main' into device-control-rbac
szwarckonrad 7c670d2
Merge branch 'main' into device-control-rbac
szwarckonrad 8a42e2c
Merge branch 'refs/heads/main' into device-control-rbac
szwarckonrad a7a112f
feat: add device control settings to endpoint security policy
szwarckonrad 9420353
feat: add device control settings to endpoint policy configuration
szwarckonrad a4a8dea
chore: remove legacy locked card upgrade message from translations
szwarckonrad 8885331
Merge branch 'main' into device-control-rbac
szwarckonrad 35cf852
feat: add device control license validation to endpoint policy config
szwarckonrad d6decda
Merge branch 'main' into device-control-rbac
szwarckonrad 6708c91
Merge branch 'main' into device-control-rbac
szwarckonrad d0118aa
feat: add device control popup settings and update license checks to …
szwarckonrad 9ac0f77
Merge branch 'main' into device-control-rbac
szwarckonrad 7d0f505
feat: add trusted devices management functionality
szwarckonrad b94b6ca
Merge branch 'main' into device-control-manage
szwarckonrad 9b21efe
Merge branch 'main' into device-control-rbac
szwarckonrad 9988f8a
feat: add execute only access level to device control and update test…
szwarckonrad 5ba098d
Merge branch 'main' into device-control-rbac
szwarckonrad c69573d
Merge branch 'main' into device-control-manage
szwarckonrad e84649a
feat: add endpoint_trusted_devices to detection alert schema and comm…
szwarckonrad c542419
[CI] Auto-commit changed files from 'yarn openapi:bundle'
kibanamachine 546814d
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine 40946bd
[CI] Auto-commit changed files from 'yarn openapi:generate'
kibanamachine 522fa33
feat: add trusted devices to endpoint artifact list types
szwarckonrad 061df95
Merge branch 'main' into device-control-manage
szwarckonrad 7d0503b
Merge branch 'main' into device-control-rbac
szwarckonrad 03a4d9e
refactor: remove unnecessary comments from device control components
szwarckonrad 6b588cb
Merge branch 'main' into device-control-rbac
szwarckonrad ff25c0b
fix: remove outdated upgrade messages from security solution endpoint…
szwarckonrad bc0737b
Merge branch 'device-control-manage' into device-control-combined
szwarckonrad 4b06bf6
feat: add endpoint_trusted_devices to various lists and tests
szwarckonrad 6bf163a
feat: add endpoint_trusted_devices to various lists and tests
szwarckonrad c05578e
Merge branch 'main' into device-control-combined
szwarckonrad b1d066f
Merge branch 'main' into device-control-combined
szwarckonrad 867c16d
Trusted devices form component
szwarckonrad e87577c
Add TrustedDeviceConditionEntryField enum and update translations and…
szwarckonrad 9137c88
Merge branch 'main' into device-control-combined
szwarckonrad a4c09d3
Merge branch 'main' into device-control-rbac
szwarckonrad 3a797b8
Refactor TrustedDevicesApiClient to utilize separate transforms modul…
szwarckonrad 5f54c99
Merge branch 'device-control-rbac' into device-control-manage
szwarckonrad 5c69395
Merge device-control-rbac into device-control-combined
szwarckonrad 74f2f5c
Add new translation for "Windows and Mac" and update OS selection in …
szwarckonrad 9625f60
refactor: update device control access level labels for clarity
szwarckonrad 14daca5
Merge branch 'main' into device-control-rbac
szwarckonrad 807d7d5
refactor: update access level terminology in DeviceControlProtectionL…
szwarckonrad ae1b13d
Merge branch 'main' into device-control-rbac
szwarckonrad ea3b746
Merge branch 'main' into device-control-rbac
szwarckonrad 4dcfe8a
Merge branch 'device-control-rbac' into device-control-manage
szwarckonrad b3f3e3d
Merge branch 'device-control-rbac' into device-control-combined
szwarckonrad 071ba30
feat: add support for trusted devices with new schemas and artifact m…
szwarckonrad 4b8b59d
cr
szwarckonrad 3abead6
Merge branch 'main' into device-control-rbac
szwarckonrad b5b26b9
Merge branch 'device-control-rbac' into device-control-manage
szwarckonrad 47915b2
Merge branch 'device-control-rbac' into device-control-combined
szwarckonrad d7aa239
fix: update experimental feature flag for trusted devices in subfeatu…
szwarckonrad 1751538
Merge branch 'main' into device-control-manage
szwarckonrad eafc50e
Merge branch 'main' into device-control-manage
szwarckonrad cc8d208
Merge branch 'device-control-manage' of https://github.com/szwarckonr…
szwarckonrad e1464aa
Merge branch 'main' into device-control-combined
szwarckonrad 4f4af33
Refactor trusted devices feature flag references to use unified key
szwarckonrad ad6858c
Merge branch 'main' into device-control-manage
szwarckonrad 5baf52f
Merge branch 'device-control-manage' into device-control-combined
szwarckonrad a57b304
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad c84c689
Fix TrustedDevicesArtifactCard to use correct artifacts path
szwarckonrad 2629125
Merge branch 'main' into device-control-manage
szwarckonrad 5786b57
Remove unused createEndpointTrustedDevicesList function and its refer…
szwarckonrad 41a7afc
Merge branch 'main' into device-control-manage
szwarckonrad 8cadd91
Merge branch 'device-control-manage' into device-control-combined
szwarckonrad d37c165
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad fa311fd
Merge branch 'main' into device-control-manage
szwarckonrad 099f6df
Update data-test-subj attribute in TrustedDevicesPolicyCard to "trust…
szwarckonrad 5097bd3
Merge branch 'device-control-rbac' into device-control-combined
szwarckonrad dc0b1f8
Merge branch 'device-control-manage' into device-control-combined
szwarckonrad 2cb9cc7
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad efb0f1d
Merge branch 'main' into device-control-manage
szwarckonrad b05c3b9
Merge branch 'device-control-manage' into device-control-combined
szwarckonrad b6ae545
Merge branch 'main' into device-control-combined
szwarckonrad 29592c6
remove redundant comments
szwarckonrad 11985a1
Merge branch 'main' into device-control-combined
szwarckonrad 816783d
Add tests for Trusted Devices API client, transforms, form, and list …
szwarckonrad 806deff
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad 0949a8f
Merge branch 'main' into device-control-combined
szwarckonrad 29fb9bd
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad ae74be9
Unit coverage
szwarckonrad 1cf678a
Merge branch 'main' into device-control-artifacts
szwarckonrad 41ab373
Merge branch 'main' into device-control-combined
szwarckonrad 2991187
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad 45fe76d
Merge branch 'main' into device-control-combined
szwarckonrad 3ba08ee
Merge branch 'main' into device-control-artifacts
szwarckonrad cb75a3f
Merge branch 'main' into device-control-combined
szwarckonrad fb2be05
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad cb20ec1
CR comments
szwarckonrad 57f5a1e
Add user selection tracking for OS types in TrustedDevicesForm
szwarckonrad 08f8bfc
Merge branch 'main' into device-control-combined
szwarckonrad 5081394
Merge branch 'main' into device-control-validators
szwarckonrad 7ddc578
feat: add trusted device validation
szwarckonrad afd2719
Merge branch 'main' into device-control-validators
szwarckonrad d75a630
Merge branch 'main' into device-control-artifacts
szwarckonrad a945c18
Merge branch 'main' into device-control-combined
szwarckonrad 06a3f15
Merge branch 'main' into device-control-validators
szwarckonrad 253dc5e
feat: enhance trusted device validation with feature flag checks
szwarckonrad 5562369
Merge branch 'main' into device-control-combined
szwarckonrad 115aace
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad 00d7154
Merge branch 'device-control-artifacts' into device-control-validators
szwarckonrad 6b672ee
feat: add support for trusted devices in exception list and role mana…
szwarckonrad 6b576f4
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 2d17172
[CI] Auto-commit changed files from 'yarn openapi:bundle'
kibanamachine c4dcdd0
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine 9fed67b
feat: add trusted devices feature to endpoint policy manager role
szwarckonrad bdedfca
Merge branch 'main' into device-control-combined
szwarckonrad f139fab
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad bec3b4a
Merge branch 'device-control-artifacts' into device-control-validators
szwarckonrad 425f9b2
Merge branch 'device-control-validators' of https://github.com/szwarc…
szwarckonrad f226a89
cr
szwarckonrad 5fb8ded
Merge branch 'main' into device-control-combined
szwarckonrad d61c7c2
lint
szwarckonrad 0d2dc30
Merge branch 'main' into device-control-combined
szwarckonrad b758c66
Merge branch 'main' into device-control-combined
szwarckonrad 5138a55
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad 4d570a6
Merge branch 'device-control-artifacts' into device-control-validators
szwarckonrad ec11fa2
Initial cypress setup for trusted devices
szwarckonrad 8f665d2
Add support for trusted devices in RBAC and navigation tests
szwarckonrad 1c36e39
Add OS_OPTIONS_PLACEHOLDER translation for operating system selection
szwarckonrad df24319
Merge branch 'main' into device-control-combined
szwarckonrad 8803f79
Merge branch 'device-control-combined' into device-control-artifacts
szwarckonrad 37f4071
Merge branch 'device-control-artifacts' into device-control-validators
szwarckonrad 793263a
Merge branch 'device-control-validators' into device-control-cypress
szwarckonrad f140dff
Merge branch 'main' into device-control-artifacts
szwarckonrad 8d9d135
Refactor RBAC navigation tests to include SIEM version filtering for …
szwarckonrad b0f045b
Merge branch 'main' into device-control-artifacts
szwarckonrad 1fb57bd
Merge branch 'device-control-artifacts' of https://github.com/szwarck…
szwarckonrad 682e875
clean up comments
szwarckonrad d559a5a
Merge branch 'device-control-artifacts' into device-control-validators
szwarckonrad b55e8d9
Merge branch 'device-control-validators' into device-control-cypress
szwarckonrad a70302f
align cypress tests
szwarckonrad 1e1a5f9
enable feature in cypress test
szwarckonrad 541ef01
Merge branch 'main' into device-control-artifacts
szwarckonrad 80821a4
Merge branch 'device-control-artifacts' into device-control-validators
szwarckonrad 5b66602
Merge branch 'device-control-validators' into device-control-cypress
szwarckonrad 52365d1
Merge branch 'main' into device-control-artifacts
szwarckonrad 74c3cb1
Merge branch 'device-control-artifacts' into device-control-validators
szwarckonrad bef97c6
Merge branch 'device-control-validators' into device-control-cypress
szwarckonrad 9348340
Merge branch 'main' into device-control-validators
szwarckonrad 8994133
Merge branch 'device-control-validators' into device-control-cypress
szwarckonrad 5ce5dbd
remove outdated comments
szwarckonrad d71ecae
Merge branch 'main' into device-control-validators
szwarckonrad e8ec84d
Merge branch 'main' into device-control-validators
szwarckonrad 17ac822
refactor validation schemas
szwarckonrad 801f034
Merge branch 'device-control-validators' into device-control-cypress
szwarckonrad ee2db0c
Merge branch 'main' into device-control-cypress
szwarckonrad c86441d
Merge branch 'main' into device-control-cypress
szwarckonrad 19126ea
cr: keep roles files synced
szwarckonrad 92386bb
cr: sync detections_admin role
szwarckonrad 58eb1f1
Merge branch 'main' into device-control-cypress
szwarckonrad 1fafdc9
cr: sync roles.yml files
szwarckonrad 848bf47
skip trusted devices in mki
szwarckonrad 711de25
Merge branch 'main' into device-control-cypress
szwarckonrad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
159 changes: 159 additions & 0 deletions
159
...y/plugins/security_solution/public/management/cypress/e2e/artifacts/trusted_devices.cy.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { ENDPOINT_ARTIFACT_LISTS } from '@kbn/securitysolution-list-constants'; | ||
| import { | ||
| createArtifactList, | ||
| createPerPolicyArtifact, | ||
| removeExceptionsList, | ||
| trustedDevicesFormSelectors, | ||
| } from '../../tasks/artifacts'; | ||
| import type { IndexedFleetEndpointPolicyResponse } from '../../../../../common/endpoint/data_loaders/index_fleet_endpoint_policy'; | ||
| import { createAgentPolicyTask, getEndpointIntegrationVersion } from '../../tasks/fleet'; | ||
| import { login } from '../../tasks/login'; | ||
|
|
||
| const { | ||
| openTrustedDevices, | ||
| selectOs, | ||
| selectField, | ||
| selectOperator, | ||
| fillValue, | ||
| fillOutTrustedDevicesFlyout, | ||
| submitForm, | ||
| validateSuccessPopup, | ||
| validateRenderedCondition, | ||
| deleteTrustedDeviceItem, | ||
| } = trustedDevicesFormSelectors; | ||
|
|
||
| describe( | ||
| 'Trusted Devices', | ||
| { | ||
| tags: ['@ess', '@serverless', '@skipInServerlessMKI'], | ||
| env: { | ||
| ftrConfig: { | ||
| kbnServerArgs: [ | ||
| `--xpack.securitySolution.enableExperimental=${JSON.stringify(['trustedDevices'])}`, | ||
| ], | ||
| }, | ||
| }, | ||
| }, | ||
| () => { | ||
| let indexedPolicy: IndexedFleetEndpointPolicyResponse; | ||
|
|
||
| before(() => { | ||
| getEndpointIntegrationVersion().then((version) => { | ||
| createAgentPolicyTask(version).then((data) => { | ||
| indexedPolicy = data; | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
| login(); | ||
| }); | ||
|
|
||
| after(() => { | ||
| if (indexedPolicy) { | ||
| cy.task('deleteIndexedFleetEndpointPolicies', indexedPolicy); | ||
| } | ||
| }); | ||
|
|
||
| const createArtifactBodyRequest = () => ({ | ||
| list_id: ENDPOINT_ARTIFACT_LISTS.trustedDevices.id, | ||
| entries: [ | ||
| { | ||
| field: 'user.name', | ||
| operator: 'included', | ||
| type: 'match', | ||
| value: 'test-user', | ||
| }, | ||
| ], | ||
| os_types: ['windows', 'macos'], | ||
| }); | ||
|
|
||
| describe('Renders Trusted Devices form fields', () => { | ||
| it('Correctly renders trusted devices form for Windows and Mac', () => { | ||
| openTrustedDevices({ create: true }); | ||
|
|
||
| selectOs('Windows and Mac'); | ||
|
|
||
| selectField('Username'); | ||
| selectOperator('is'); | ||
| fillValue('test-user'); | ||
| }); | ||
|
|
||
| it('Renders all field options correctly', () => { | ||
| openTrustedDevices({ create: true }); | ||
| selectOs('Windows and Mac'); | ||
|
|
||
| const fields: Array<'Username' | 'Host' | 'Device ID' | 'Manufacturer' | 'Product ID'> = [ | ||
| 'Username', | ||
| 'Host', | ||
| 'Device ID', | ||
| 'Manufacturer', | ||
| 'Product ID', | ||
| ]; | ||
|
|
||
| fields.forEach((field) => { | ||
| selectField(field); | ||
| cy.getByTestSubj('trustedDevices-form-fieldSelect').should('contain', field); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('Handles CRUD with device fields', () => { | ||
| afterEach(() => { | ||
| removeExceptionsList(ENDPOINT_ARTIFACT_LISTS.trustedDevices.id); | ||
| }); | ||
|
|
||
| it('Correctly creates a trusted device with a single username field on Windows and Mac', () => { | ||
| const expectedCondition = /user\.name\s*IS\s*test-user/i; | ||
|
|
||
| openTrustedDevices({ create: true }); | ||
| fillOutTrustedDevicesFlyout(); | ||
| selectOs('Windows and Mac'); | ||
| selectField('Username'); | ||
| selectOperator('is'); | ||
| fillValue('test-user'); | ||
| submitForm(); | ||
|
|
||
| validateSuccessPopup('create'); | ||
| validateRenderedCondition(expectedCondition); | ||
| }); | ||
|
|
||
| describe('Correctly updates and deletes trusted device with single username field', () => { | ||
| let itemId: string; | ||
|
|
||
| beforeEach(() => { | ||
| createArtifactList(ENDPOINT_ARTIFACT_LISTS.trustedDevices.id); | ||
| createPerPolicyArtifact('Test Trusted Device', createArtifactBodyRequest()).then( | ||
| (response) => { | ||
| itemId = response.body.item_id; | ||
| } | ||
| ); | ||
| }); | ||
|
|
||
| it('Updates trusted device username field item', () => { | ||
| const expectedCondition = /user\.name\s*IS\s*updated-user/i; | ||
|
|
||
| openTrustedDevices({ itemId }); | ||
| fillValue('updated-user'); | ||
| submitForm(); | ||
|
|
||
| validateSuccessPopup('update'); | ||
| validateRenderedCondition(expectedCondition); | ||
| }); | ||
|
|
||
| it('Deletes a trusted device item', () => { | ||
| openTrustedDevices(); | ||
| deleteTrustedDeviceItem(); | ||
| validateSuccessPopup('delete'); | ||
| }); | ||
| }); | ||
| }); | ||
| } | ||
| ); |
25 changes: 25 additions & 0 deletions
25
...gins/security_solution/public/management/cypress/e2e/artifacts/trusted_devices_rbac.cy.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { getArtifactsListTestDataForArtifact } from '../../fixtures/artifacts_page'; | ||
| import { getArtifactMockedDataTests } from '../../support/artifacts_rbac_runner'; | ||
|
|
||
| describe( | ||
| 'Trusted devices RBAC', | ||
| { | ||
| tags: ['@ess', '@serverless', '@skipInServerlessMKI'], | ||
| env: { | ||
| ftrConfig: { | ||
| kbnServerArgs: [ | ||
| `--xpack.securitySolution.enableExperimental=${JSON.stringify(['trustedDevices'])}`, | ||
| ], | ||
| }, | ||
| }, | ||
| }, | ||
|
|
||
| getArtifactMockedDataTests(getArtifactsListTestDataForArtifact('trustedDevices'), ['siemV3']) | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this change in not present in the elasticsearch-controller (yet?). We usually try to keep the role definitions in sync. Otherwise, any testing that relies on this extra privilege might pass locally but fail in MKI runs. What are your plans around this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature targets 9.2 and we will most likely add this privilege before the feature freeze. I'm okay with reverting this change and revisiting once we merged controller. CC @gergoabraham
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pheyos, as we do not have custom roles for serverless in our test suites at the moment, I think there must be a discrepancy somewhere to be able to use the new privileges in cy/ftr tests. the discrepancy is either between
elasticsearch-controllerandkibana(as the current PR introduces it), or between (elasticsearch-controller+ kibana's kbn-es resource) and (kibana's test resource).do you think one is better than the other? i think updating
elasticsearch-controllerlater should be fine, as this allows us to locally test the new roles, and have CI tests in place for the new features, while these tests are skipped in MKI. but i guess we can go the other way around as well - keeping the new privileges out of kbn-es resourceUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started MKI run based off last commit of this PR - https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-defend-workflows/builds/3331
Passed ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gergoabraham @szwarckonrad it's true that we can't always be in perfect sync and there's risk in every version of discrepancy.
In this case, I think it makes sense to go this route. If any FTR tests start failing in MKI due to this role definition change (unlikely unless we explicitly add specific tests for it - the tests seem to be mostly in Cypress), then we would have to skip these tests for MKI runs until the role definition in elasticsearch-controller has caught up. With that, I'm going to approve this PR from the AppEx QA point of view.