Skip to content

[ska] delete x-pack/test_serverless directory#232186

Merged
dmlemeshko merged 5 commits intoelastic:mainfrom
dmlemeshko:ska/delete-test_serverless-dir
Aug 26, 2025
Merged

[ska] delete x-pack/test_serverless directory#232186
dmlemeshko merged 5 commits intoelastic:mainfrom
dmlemeshko:ska/delete-test_serverless-dir

Conversation

@dmlemeshko
Copy link
Contributor

@dmlemeshko dmlemeshko commented Aug 19, 2025 •
edited by kibanamachine
Loading

Summary

Part of https://github.com/elastic/kibana-team/issues/1503

This is cleanup PR, that removes x-pack/test_serverless directory and all its references

should be merged only after we move/update docs #231930

@dmlemeshko dmlemeshko self-assigned this Aug 19, 2025
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.2.0 v9.1.3 v8.19.3 labels Aug 19, 2025
@dmlemeshko dmlemeshko changed the title [ska] delete test_serverless [ska] delete x-pack/test_serverless directory Aug 19, 2025
@dmlemeshko dmlemeshko marked this pull request as ready for review August 19, 2025 10:23
@dmlemeshko dmlemeshko requested review from a team as code owners August 19, 2025 10:23
jbudz
jbudz reviewed Aug 19, 2025
View reviewed changes
@azasypkin azasypkin self-requested a review August 20, 2025 11:35
@dmlemeshko dmlemeshko requested a review from pheyos August 20, 2025 14:54
azasypkin
azasypkin approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

packages/kbn-dependency-usage/src/dependency_graph/common/constants.ts
'packages',
'src',
'x-pack/test',
'x-pack/test_serverless',
Copy link
Contributor

@azasypkin azasypkin Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not related to this PR): @elena-shostak do we need to add x-pack/platform/test and x-pack/solutions/<solution>/test as aggregation groups?

Copy link
Contributor

@elena-shostak elena-shostak Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ yeah, we should

pheyos
pheyos approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko requested review from a team as code owners August 26, 2025 10:33
akowalska622
akowalska622 approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@akowalska622 akowalska622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM 🎉

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 26, 2025

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-serverless 1 - -1

Total ESLint disabled count

id before after diff
@kbn/test-suites-serverless 1 - -1

History

cc @dmlemeshko

@dmlemeshko dmlemeshko enabled auto-merge (squash) August 26, 2025 13:45
maxcold
maxcold approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud_security_posture docs updates lgtm

@dmlemeshko dmlemeshko merged commit 0bbed22 into elastic:main Aug 26, 2025
14 checks passed
@kibanamachine kibanamachine mentioned this pull request Aug 27, 2025
Merged
@dmlemeshko dmlemeshko added backport:version Backport to applied version labels and removed backport:skip This PR does not require backporting labels Aug 27, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 27, 2025

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/17268176346

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 27, 2025

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/17268176309

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 27, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
❌ 9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 232186

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 27, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
❌ 9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 232186

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Aug 27, 2025
Merged
1 task
@dmlemeshko dmlemeshko mentioned this pull request Aug 27, 2025
Merged
@dmlemeshko
Copy link
Contributor Author

dmlemeshko commented Aug 27, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Aug 27, 2025
@dmlemeshko
[ska] delete x-pack/test_serverless directory (elastic#232186)
44c7724 
## Summary

Part of elastic/kibana-team#1503

This is cleanup PR, that removes `x-pack/test_serverless` directory and
all its references

should be merged only after we move/update docs
elastic#231930

(cherry picked from commit 0bbed22)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/solutions/security/plugins/cloud_security_posture/README.md
#	x-pack/test_serverless/api_integration/config.base.ts
#	x-pack/test_serverless/api_integration/ftr_provider_context.d.ts
#	x-pack/test_serverless/api_integration/services/default_fleet_setup.ts
#	x-pack/test_serverless/api_integration/services/index.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_cluster_nodes.api.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_component_templates.api.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_component_templates.helpers.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_datastreams.helpers.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_enrich_policies.api.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_enrich_policies.helpers.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_indices.api.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_indices.helpers.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_mappings.api.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_settings.api.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_templates.api.ts
#	x-pack/test_serverless/api_integration/services/index_management/svl_templates.helpers.ts
#	x-pack/test_serverless/api_integration/services/saml_tools.ts
#	x-pack/test_serverless/api_integration/services/svl_cases/api.ts
#	x-pack/test_serverless/api_integration/services/svl_cases/index.ts
#	x-pack/test_serverless/api_integration/services/svl_cases/omit.ts
#	x-pack/test_serverless/api_integration/services/transform/api.ts
#	x-pack/test_serverless/api_integration/services/transform/index.ts
#	x-pack/test_serverless/api_integration/services/transform/security_common.ts
#	x-pack/test_serverless/functional/config.base.ts
#	x-pack/test_serverless/functional/ftr_provider_context.d.ts
#	x-pack/test_serverless/functional/page_objects/index.ts
#	x-pack/test_serverless/shared/lib/cases/helpers.ts
#	x-pack/test_serverless/shared/lib/object_remover.ts
#	x-pack/test_serverless/shared/services/alerting_api.ts
#	x-pack/test_serverless/shared/services/data_view_api.ts
#	x-pack/test_serverless/shared/services/platform_security_utils.ts
#	x-pack/test_serverless/shared/services/supertest.ts
#	x-pack/test_serverless/shared/services/svl_common_api.ts
#	x-pack/test_serverless/shared/services/svl_reporting.ts
#	x-pack/test_serverless/shared/services/usage_api.ts
#	x-pack/test_serverless/shared/types/index.ts
#	x-pack/test_serverless/tsconfig.json
dmlemeshko added a commit that referenced this pull request Aug 27, 2025
@dmlemeshko @kibanamachine
[9.1] [ska] delete x-pack/test_serverless directory (#232186) (#233118)
480016e 
# Backport

This will backport the following commits from `main` to `9.1`:
- [[ska] delete x-pack/test_serverless directory
(#232186)](#232186)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-08-26T13:55:32Z","message":"[ska]
delete x-pack/test_serverless directory (#232186)\n\n## Summary\n\nPart
of https://github.com/elastic/kibana-team/issues/1503\n\nThis is cleanup
PR, that removes `x-pack/test_serverless` directory and\nall its
references\n\nshould be merged only after we move/update
docs\nhttps://github.com//pull/231930","sha":"0bbed2205d72ff1bd21c10c8e3aeab282f3cc699","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.1.3","v8.19.3"],"title":"[ska]
delete x-pack/test_serverless
directory","number":232186,"url":"https://github.com/elastic/kibana/pull/232186","mergeCommit":{"message":"[ska]
delete x-pack/test_serverless directory (#232186)\n\n## Summary\n\nPart
of https://github.com/elastic/kibana-team/issues/1503\n\nThis is cleanup
PR, that removes `x-pack/test_serverless` directory and\nall its
references\n\nshould be merged only after we move/update
docs\nhttps://github.com//pull/231930","sha":"0bbed2205d72ff1bd21c10c8e3aeab282f3cc699"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/232186","number":232186,"mergeCommit":{"message":"[ska]
delete x-pack/test_serverless directory (#232186)\n\n## Summary\n\nPart
of https://github.com/elastic/kibana-team/issues/1503\n\nThis is cleanup
PR, that removes `x-pack/test_serverless` directory and\nall its
references\n\nshould be merged only after we move/update
docs\nhttps://github.com//pull/231930","sha":"0bbed2205d72ff1bd21c10c8e3aeab282f3cc699"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 29, 2025
Merged
1 task
This was referenced Sep 8, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elena-shostak elena-shostak elena-shostak left review comments

@maxcold maxcold maxcold approved these changes

@azasypkin azasypkin azasypkin approved these changes

@pheyos pheyos pheyos approved these changes

@jbudz jbudz jbudz approved these changes

@dkirchan dkirchan dkirchan approved these changes

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@akowalska622 akowalska622 akowalska622 approved these changes

Assignees

@dmlemeshko dmlemeshko

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.3 v9.1.3 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.