Skip to content

Discover tabs saving#231715

Closed
lukasolson wants to merge 88 commits intoelastic:mainfrom
lukasolson:discover_tabs_saving
Closed

Discover tabs saving#231715
lukasolson wants to merge 88 commits intoelastic:mainfrom
lukasolson:discover_tabs_saving

Conversation

@lukasolson
Copy link
Copy Markdown
Contributor

Summary

Cherry-picks & resolves conflicts of #227159

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@lukasolson lukasolson self-assigned this Aug 13, 2025
@lukasolson lukasolson added Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// Project:OneDiscover Enrich Discover with contextual awareness labels Aug 13, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 13, 2025

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

export const TABS_ENABLED_FEATURE_FLAG_KEY = 'discover.tabsEnabled';

// TEMPORARY: This is a temporary flag to enable/disable tabs in Discover until the feature is fully implemented.
export const TABS_ENABLED =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed in favor of TABS_ENABLED_FEATURE_FLAG_KEY

@davismcphee davismcphee force-pushed the discover_tabs_saving branch from 9d4b502 to 62bb579 Compare August 21, 2025 14:53
@davismcphee davismcphee force-pushed the discover_tabs_saving branch from 6a64295 to b710df3 Compare August 21, 2025 22:11
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 1385 1386 +1
savedSearch 24 28 +4
total +5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2635 2637 +2
dataViews 450 448 -2
discover 157 158 +1
kibanaUtils 414 420 +6
savedSearch 66 101 +35
total +42

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 622.6KB 622.6KB +10.0B
discover 1.1MB 1.1MB +8.2KB
graph 371.0KB 371.0KB +10.0B
infra 1.0MB 1.0MB +11.0B
savedSearch 0.0B 6.8KB +6.8KB
securitySolution 10.4MB 10.4MB +131.0B
visualizations 351.4KB 351.4KB +20.0B
total +15.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
discover 29 36 +7

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 420.7KB 420.8KB +70.0B
dataViews 62.0KB 62.1KB +140.0B
discover 22.7KB 22.6KB -76.0B
kibanaUtils 48.3KB 48.6KB +298.0B
savedSearch 11.6KB 9.9KB -1.7KB
total -1.2KB
Unknown metric groups

API count

id before after diff
data 3259 3265 +6
dataViews 1242 1244 +2
kibanaUtils 607 613 +6
savedSearch 69 104 +35
total +49

async chunk count

id before after diff
savedSearch 0 1 +1

References to deprecated APIs

id before after diff
securitySolution 330 333 +3

History

cc @lukasolson

@lukasolson
Copy link
Copy Markdown
Contributor Author

Replaced by #227159.

@lukasolson lukasolson closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants