Skip to content

Comments

[9.1] [ska] relocate common services and utils to security_solution_api_integration dir (#228780)#231623

Merged
dmlemeshko merged 2 commits intoelastic:9.1from
dmlemeshko:backport/9.1/pr-228780
Aug 13, 2025
Merged

[9.1] [ska] relocate common services and utils to security_solution_api_integration dir (#228780)#231623
dmlemeshko merged 2 commits intoelastic:9.1from
dmlemeshko:backport/9.1/pr-228780

Conversation

@dmlemeshko
Copy link
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…egration dir (elastic#228780)

## Summary

It is a preparation work before we relocate
`x-pack/test/security_solution_api_integration` under
`x-pack/solutions/security/test`:

- moving helpers/utils inside directory to avoid updating imports after
relocation
- importing from `security_solution_api_integration` inside
`x-pack/solutions/security/test` leads to circular dependency issue, so
I copied `common/utils/detections_response` as a temporary workaround
until tests dir is relocated

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
(cherry picked from commit 0051e2c)

# Conflicts:
#	x-pack/test/api_integration/services/security_solution_api.gen.ts
#	x-pack/test/common/services/index.ts
#	x-pack/test/security_solution_api_integration/test_suites/siem_migrations/rules/trial_license_complete_tier/get_prebuilt_rules.ts
#	x-pack/test/security_solution_api_integration/test_suites/siem_migrations/rules/trial_license_complete_tier/install.ts
#	x-pack/test/tsconfig.json
@dmlemeshko dmlemeshko requested a review from fake-haris August 13, 2025 14:29
@dmlemeshko dmlemeshko merged commit ae0f091 into elastic:9.1 Aug 13, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
spaces 235 236 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
spaces 28.5KB 28.6KB +67.0B
Unknown metric groups

API count

id before after diff
spaces 256 259 +3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants