Skip to content

[8.19] [NL2ESQL] Fix tool going into endless loop for ES|QL LOOKUP JOIN (#231217) #231550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qn895 merged 1 commit into from
Aug 13, 2025
Merged

[8.19] [NL2ESQL] Fix tool going into endless loop for ES|QL LOOKUP JOIN (#231217) #231550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/platform/plugins/shared/inference/server/tasks/nl_to_esql/doc_base/aliases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
const aliases: Record<string, string[]> = {
STATS: ['STATS_BY', 'BY', 'STATS...BY', 'STATS ... BY'],
OPERATORS: ['LIKE', 'RLIKE', 'IN'],
JOIN: ['LOOKUP JOIN'],
LOOKUP_JOIN: ['LOOKUPJOIN'],
};

const getAliasMap = () => {
Expand Down
3 changes: 1 addition & 2 deletions x-pack/platform/plugins/shared/inference/server/tasks/nl_to_esql/doc_base/esql_doc_base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ export class EsqlDocumentBase {
}: GetDocsOptions = {}
) {
const keywords = rawKeywords.map((raw) => {
// LOOKUP JOIN has space so we want to retain as is
let keyword = raw.toLowerCase().includes('join') ? raw : format(raw);
let keyword = format(raw);
if (resolveAliases) {
keyword = tryResolveAlias(keyword);
}
Expand Down
2 changes: 1 addition & 1 deletion ...ty/plugins/observability_ai_assistant_app/scripts/evaluation/scenarios/esql/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ async function evaluateEsqlQuery({
const evaluation = await chatClient.evaluate(conversation, [
...(expected
? [
`Returns a ES|QL query that is functionally equivalent to:
`Returns a ES|QL query that is functionally equivalent to:
${expected}. It's OK if column names are slightly different, as long as the expected end result is the same.`,
]
: []),
Expand Down