Skip to content

[8.19] [Detection Engine] Unskip some flaky tests, add better failure messages (#230318)#231526

Merged
rylnd merged 3 commits intoelastic:8.19from
rylnd:backport/8.19/pr-230318
Aug 13, 2025
Merged

[8.19] [Detection Engine] Unskip some flaky tests, add better failure messages (#230318)#231526
rylnd merged 3 commits intoelastic:8.19from
rylnd:backport/8.19/pr-230318

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Aug 12, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

…es (elastic#230318)

## Summary

While the tests affected by this PR are varied, the changes contained
here fall under one of two categories:

1. Unskipping flaky tests
2. Adding better test assertions (in order to produce more actionable
failures later)

### Related Issues
* Closes elastic#224699
* Closes elastic#224780
* Closes elastic#220943
* Closes elastic#202940
* Closes elastic#202945

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0a3e7bb)

# Conflicts:
#	x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/eql/trial_license_complete_tier/eql.ts
#	x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/eql/trial_license_complete_tier/eql_alert_suppression.ts
#	x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/esql/trial_license_complete_tier/esql.ts
@rylnd rylnd requested a review from kibanamachine as a code owner August 12, 2025 20:26
@rylnd rylnd added the backport This PR is a backport of another PR label Aug 12, 2025
@rylnd rylnd enabled auto-merge (squash) August 12, 2025 20:26
@rylnd rylnd disabled auto-merge August 12, 2025 20:29
rylnd added 2 commits August 12, 2025 16:53
These changes are somewhat at odds with what was done in elastic#215757, which
was not backported to 8.19.
@rylnd rylnd enabled auto-merge (squash) August 13, 2025 21:04
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@rylnd rylnd merged commit aae896f into elastic:8.19 Aug 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants