Skip to content

[9.1] [Detection Engine] Unskip some flaky tests, add better failure messages (#230318)#231523

Merged
rylnd merged 2 commits intoelastic:9.1from
rylnd:backport/9.1/pr-230318
Aug 13, 2025
Merged

[9.1] [Detection Engine] Unskip some flaky tests, add better failure messages (#230318)#231523
rylnd merged 2 commits intoelastic:9.1from
rylnd:backport/9.1/pr-230318

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Aug 12, 2025

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…es (elastic#230318)

## Summary

While the tests affected by this PR are varied, the changes contained
here fall under one of two categories:

1. Unskipping flaky tests
2. Adding better test assertions (in order to produce more actionable
failures later)

### Related Issues
* Closes elastic#224699
* Closes elastic#224780
* Closes elastic#220943
* Closes elastic#202940
* Closes elastic#202945

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0a3e7bb)

# Conflicts:
#	x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/esql/trial_license_complete_tier/esql.ts
@rylnd rylnd requested a review from kibanamachine as a code owner August 12, 2025 20:18
@rylnd rylnd added the backport This PR is a backport of another PR label Aug 12, 2025
@rylnd rylnd enabled auto-merge (squash) August 12, 2025 20:18
@rylnd rylnd disabled auto-merge August 12, 2025 20:29
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 12, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #70 / EQL execution logic API @ess @serverless Alert Suppression for EQL rules @skipInServerless sequence queries with suppression duration does not suppress alerts outside of duration when query with 3 sequences
  • [job] [logs] FTR Configs #70 / EQL execution logic API @ess @serverless Alert Suppression for EQL rules @skipInServerless sequence queries with suppression duration does not suppress alerts outside of duration when query with 3 sequences

Metrics [docs]

✅ unchanged

History

Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM

@rylnd rylnd merged commit b1a0809 into elastic:9.1 Aug 13, 2025
12 checks passed
@rylnd rylnd deleted the backport/9.1/pr-230318 branch August 13, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants