[9.1] Remove @paralleldrive/cuid2 (#230293) #231346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Attention Code Owners! Please test these changes before approving. Your know your domains much better than I do, and I need your help to ensure I did not cause any regressions. Thank you! ------- This pull request removes the dependency on `@paralleldrive/cuid2` and replaces it with alternatives (`uuid` and `crypto`) for generating unique IDs. The changes primarily focus on dependency management and updating the code to use the new ID generation methods. ### Dependency Management: * Removed `@paralleldrive/cuid2` from `package.json` and `renovate.json` to eliminate its usage in the project. [[1]](diffhunk://#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L1147) [[2]](diffhunk://#diff-7b5c8955fc544a11b4b74eddb4115f9cc51c9cf162dbffa60d37eeed82a55a57L761) ### Code Updates: * Replaced `createId` from `@paralleldrive/cuid2` with `uuidv4` from the `uuid` package in `sample_client_readme.tsx`. This change affects the `Generate API key` functionality. [[1]](diffhunk://#diff-19ec5ab675709969feeeaaa0b0549d8926f49e3115166426a17370bc6a98d673L13-R13) [[2]](diffhunk://#diff-19ec5ab675709969feeeaaa0b0549d8926f49e3115166426a17370bc6a98d673L148-R148) * Updated `content_stream.ts` to use `randomUUID` from the `crypto` module instead of `createId` for generating IDs in the `ContentStream` class. [[1]](diffhunk://#diff-a7545f2aab64e1136452bd37f3388ae269f64761b19c80cc007be7e7c97f511dL10-R10) [[2]](diffhunk://#diff-a7545f2aab64e1136452bd37f3388ae269f64761b19c80cc007be7e7c97f511dL227-R227) * Updated `file_client.ts` to use `randomUUID` from the `crypto` module instead of `createId` for generating IDs in the `FileClientImpl` class. [[1]](diffhunk://#diff-ffbfbe730b81183661bb18b6b78bbb3903496b5716598f4284531fe31390358aL13-R13) [[2]](diffhunk://#diff-ffbfbe730b81183661bb18b6b78bbb3903496b5716598f4284531fe31390358aL133-R133) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 35f311d) # Conflicts: # package.json
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation