[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load #230842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…psed section that are closed on page load
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
nreese
added
release_note:fix
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
approved these changes
Aug 6, 2025
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm! code review and confirmed that it fixes the bug with duplicating panels when there is a collapsed section.
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16788552547 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Aug 6, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Aug 6, 2025
…psed section that are closed on page load (elastic#230842) Closes elastic#230818 PR updates getChildApi with logic to return `undefined` if panel is in a collapsed section. (cherry picked from commit 3095ceb) # Conflicts: # src/platform/plugins/shared/dashboard/public/dashboard_api/layout_manager/layout_manager.test.ts
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Aug 6, 2025
…psed section that are closed on page load (elastic#230842) Closes elastic#230818 PR updates getChildApi with logic to return `undefined` if panel is in a collapsed section. (cherry picked from commit 3095ceb) # Conflicts: # src/platform/plugins/shared/dashboard/public/dashboard_api/layout_manager/layout_manager.test.ts
nreese
added a commit
that referenced
this pull request
Aug 7, 2025
… collapsed section that are closed on page load (#230842) (#230875) # Backport This will backport the following commits from `main` to `9.1`: - [[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load (#230842)](#230842) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-08-06T21:05:19Z","message":"[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load (#230842)\n\nCloses https://github.com/elastic/kibana/issues/230818\n\nPR updates getChildApi with logic to return `undefined` if panel is in a\ncollapsed section.","sha":"3095cebf0680288689a5fe9d9bd1a3f99146be98","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load","number":230842,"url":"https://github.com/elastic/kibana/pull/230842","mergeCommit":{"message":"[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load (#230842)\n\nCloses https://github.com/elastic/kibana/issues/230818\n\nPR updates getChildApi with logic to return `undefined` if panel is in a\ncollapsed section.","sha":"3095cebf0680288689a5fe9d9bd1a3f99146be98"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230842","number":230842,"mergeCommit":{"message":"[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load (#230842)\n\nCloses https://github.com/elastic/kibana/issues/230818\n\nPR updates getChildApi with logic to return `undefined` if panel is in a\ncollapsed section.","sha":"3095cebf0680288689a5fe9d9bd1a3f99146be98"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
nreese
added a commit
that referenced
this pull request
Aug 7, 2025
…s collapsed section that are closed on page load (#230842) (#230877) # Backport This will backport the following commits from `main` to `8.19`: - [[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load (#230842)](#230842) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-08-06T21:05:19Z","message":"[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load (#230842)\n\nCloses https://github.com/elastic/kibana/issues/230818\n\nPR updates getChildApi with logic to return `undefined` if panel is in a\ncollapsed section.","sha":"3095cebf0680288689a5fe9d9bd1a3f99146be98","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load","number":230842,"url":"https://github.com/elastic/kibana/pull/230842","mergeCommit":{"message":"[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load (#230842)\n\nCloses https://github.com/elastic/kibana/issues/230818\n\nPR updates getChildApi with logic to return `undefined` if panel is in a\ncollapsed section.","sha":"3095cebf0680288689a5fe9d9bd1a3f99146be98"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230842","number":230842,"mergeCommit":{"message":"[dashboard] fix duplicate panel action hangs when dashboard has collapsed section that are closed on page load (#230842)\n\nCloses https://github.com/elastic/kibana/issues/230818\n\nPR updates getChildApi with logic to return `undefined` if panel is in a\ncollapsed section.","sha":"3095cebf0680288689a5fe9d9bd1a3f99146be98"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Aug 7, 2025
…psed section that are closed on page load (elastic#230842) Closes elastic#230818 PR updates getChildApi with logic to return `undefined` if panel is in a collapsed section.
denar50
pushed a commit
to denar50/kibana
that referenced
this pull request
Aug 8, 2025
…psed section that are closed on page load (elastic#230842) Closes elastic#230818 PR updates getChildApi with logic to return `undefined` if panel is in a collapsed section.
Contributor
|
This is a good temporary solution, but the Could we update it to get the titles from the Dashboard state directly rather than going through the embeddable APIs? This should be okay as the intention is to get only Dashboard panel titles, not saved object titles. |
Contributor
Author
I don't think dashboard should reach into embeddable state because there is no guarantee which key is used to saved titles. An embeddable could use its own implementation and its own key to store the title. Maybe getTitles should only return titles from the current section? |
Contributor
|
Ah true, I forgot we had moved titles into the embeddable config. Getting titles from the current section could be a good workaround. |
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…psed section that are closed on page load (elastic#230842) Closes elastic#230818 PR updates getChildApi with logic to return `undefined` if panel is in a collapsed section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230818
PR updates getChildApi with logic to return
undefinedif panel is in a collapsed section.