[9.1] [Entity Store] Fix Enrich Policy execution in multiple namespaces (#230746) #230779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…astic#230746) ## Summary Solves two bugs: - The API key was not being found once multiple spaces were created, and **no enrich policy** should be working before this PR in a kibana with multiple spaces. We were missing the `option` `namespace` to get `getDecryptedAsInternalUser` (doesn't feel that like that much of an option). The call chain: - [`getDecryptedAsInternalUser` calls `internalRepository.get` passing options down](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/encrypted_saved_objects/server/saved_objects/index.ts#L77) - [A `performGet` is done passing options down](https://github.com/elastic/kibana/blob/main/src/core/packages/saved-objects/api-server-internal/src/lib/repository.ts#L377) - [`options.namespace` is normalized (and remais undefined)](https://github.com/elastic/kibana/blob/main/src/core/packages/saved-objects/api-server-internal/src/lib/apis/get.ts#L34) - [We check if document exists in the namespace, passing the undefined namespace](https://github.com/elastic/kibana/blob/main/src/core/packages/saved-objects/api-server-internal/src/lib/apis/get.ts#L56) - [On verifying that the namespace saved in the SavedObject is the same as the passed down](https://github.com/elastic/kibana/blob/main/src/core/packages/saved-objects/api-server-internal/src/lib/apis/utils/internal_utils.ts#L178), we [normalize the namespace to `default`](https://github.com/elastic/kibana/blob/main/src/core/packages/saved-objects/utils-server/src/saved_objects_utils.ts#L39), which is then preset in the list stored in the saved object. - If no API key found for namespace, return all entity types. Before it was being returned an object. Decided to just use method `getEnabledEntityTypes` passing the feature flag as enabled (there is also a log). Relates to elastic#230723 #### Logs Before PR <img width="1671" height="735" alt="image" src="https://github.com/user-attachments/assets/0fc538b9-ecf3-4f9b-9209-198d514b44c7" /> #### Logs with PR <img width="1574" height="141" alt="image" src="https://github.com/user-attachments/assets/1574531f-57e7-4848-8e8b-0aeff033f1c9" /> (cherry picked from commit d495428)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
cc @romulets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation