[9.0] [9.1] [Search] Root Elasticsearch breadcrumb missing link (#230270) (#230393)#230770
Closed
seialkali wants to merge 1 commit intoelastic:9.0from
Closed
[9.0] [9.1] [Search] Root Elasticsearch breadcrumb missing link (#230270) (#230393)#230770seialkali wants to merge 1 commit intoelastic:9.0from
seialkali wants to merge 1 commit intoelastic:9.0from
Conversation
…0270) (elastic#230393) # Backport This will backport the following commits from `main` to `9.1`: - [[Search] Root Elasticsearch breadcrumb missing link (elastic#230270)](elastic#230270) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Brittany","email":"seialkali@gmail.com"},"sourceCommit":{"committedDate":"2025-08-04T11:13:20Z","message":"[Search] Root Elasticsearch breadcrumb missing link (elastic#230270)\n\n## Summary\n\nRoot Elasticsearch breadcrumb missing link when set from search\nnavigation API.\n\nOn the search applications page, the breadcrumb for Elasticsearch had a\nlink back to the home page. This link was missing for the breadcrumbs on\nthe query rules and other pages that use search navigation to set\nbreadcrumbs.\n\n### Before\n\n**Working breadcrumb on the search applications page**\n<img width=\"600\" alt=\"Screenshot 2025-07-31 at 14 41 51\"\nsrc=\"https://github.com/user-attachments/assets/dbd168f0-08f9-479c-84a6-f139362aec3c\"\n/>\n\n**Broken breadcrumb on the query rules page**\n<img width=\"600\" alt=\"Screenshot 2025-07-31 at 14 42 01\"\nsrc=\"https://github.com/user-attachments/assets/aec34891-5c25-447d-b977-f2d2d61babc6\"\n/>\n\n### After\n\n**Fixed breadcrumb on the query rules page**\n<img width=\"600\" alt=\"Screenshot 2025-08-01 at 16 41 36\"\nsrc=\"https://github.com/user-attachments/assets/4a8fb90b-fad4-4c38-94d0-72488e33a797\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] ~Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes Elasticsearch breadcrumb to include a link to the home page for\nsearch pages.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3de36a3276bfacdb25ddbe6f5266c79cb05bbe4b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","v9.2.0","v9.1.1"],"title":"[Search] Root Elasticsearch breadcrumb missing link","number":230270,"url":"https://github.com/elastic/kibana/pull/230270","mergeCommit":{"message":"[Search] Root Elasticsearch breadcrumb missing link (elastic#230270)\n\n## Summary\n\nRoot Elasticsearch breadcrumb missing link when set from search\nnavigation API.\n\nOn the search applications page, the breadcrumb for Elasticsearch had a\nlink back to the home page. This link was missing for the breadcrumbs on\nthe query rules and other pages that use search navigation to set\nbreadcrumbs.\n\n### Before\n\n**Working breadcrumb on the search applications page**\n<img width=\"600\" alt=\"Screenshot 2025-07-31 at 14 41 51\"\nsrc=\"https://github.com/user-attachments/assets/dbd168f0-08f9-479c-84a6-f139362aec3c\"\n/>\n\n**Broken breadcrumb on the query rules page**\n<img width=\"600\" alt=\"Screenshot 2025-07-31 at 14 42 01\"\nsrc=\"https://github.com/user-attachments/assets/aec34891-5c25-447d-b977-f2d2d61babc6\"\n/>\n\n### After\n\n**Fixed breadcrumb on the query rules page**\n<img width=\"600\" alt=\"Screenshot 2025-08-01 at 16 41 36\"\nsrc=\"https://github.com/user-attachments/assets/4a8fb90b-fad4-4c38-94d0-72488e33a797\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] ~Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes Elasticsearch breadcrumb to include a link to the home page for\nsearch pages.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3de36a3276bfacdb25ddbe6f5266c79cb05bbe4b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230270","number":230270,"mergeCommit":{"message":"[Search] Root Elasticsearch breadcrumb missing link (elastic#230270)\n\n## Summary\n\nRoot Elasticsearch breadcrumb missing link when set from search\nnavigation API.\n\nOn the search applications page, the breadcrumb for Elasticsearch had a\nlink back to the home page. This link was missing for the breadcrumbs on\nthe query rules and other pages that use search navigation to set\nbreadcrumbs.\n\n### Before\n\n**Working breadcrumb on the search applications page**\n<img width=\"600\" alt=\"Screenshot 2025-07-31 at 14 41 51\"\nsrc=\"https://github.com/user-attachments/assets/dbd168f0-08f9-479c-84a6-f139362aec3c\"\n/>\n\n**Broken breadcrumb on the query rules page**\n<img width=\"600\" alt=\"Screenshot 2025-07-31 at 14 42 01\"\nsrc=\"https://github.com/user-attachments/assets/aec34891-5c25-447d-b977-f2d2d61babc6\"\n/>\n\n### After\n\n**Fixed breadcrumb on the query rules page**\n<img width=\"600\" alt=\"Screenshot 2025-08-01 at 16 41 36\"\nsrc=\"https://github.com/user-attachments/assets/4a8fb90b-fad4-4c38-94d0-72488e33a797\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] ~Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~\n- [ ]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~\n- [ ] ~[Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios~\n- [ ] ~If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n- [ ] ~This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~\n- [ ] ~[Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release note\n\nFixes Elasticsearch breadcrumb to include a link to the home page for\nsearch pages.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3de36a3276bfacdb25ddbe6f5266c79cb05bbe4b"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Brittany <seialkali@gmail.com> (cherry picked from commit 60c5704)
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
💔 Build Failed
Failed CI StepsHistory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
9.1to9.0:Questions ?
Please refer to the Backport tool documentation