fix: cutom esql tool runtime errors #230745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrazb
added
release_note:skip
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
|
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Aug 7, 2025
## Summary - Make esql tools always return `ToolResultType.tabularData` - Use es cli for building esql query - Actually there is a bug with named params, reported here elastic/elasticsearch-specification#5083 What I'm not doing? - Figuring out how to wire ToolResultType everywhere ... the tool result type can still be `any`. This just fixes runtime errors as we are returning right `type` in the response ### Screenshot Built in and custom esql tools work in agent runtime: <img width="682" height="737" alt="Screenshot 2025-08-06 at 12 13 29" src="https://github.com/user-attachments/assets/9523d82f-58aa-4eab-b653-e8f97f15115e" />
denar50
pushed a commit
to denar50/kibana
that referenced
this pull request
Aug 8, 2025
## Summary - Make esql tools always return `ToolResultType.tabularData` - Use es cli for building esql query - Actually there is a bug with named params, reported here elastic/elasticsearch-specification#5083 What I'm not doing? - Figuring out how to wire ToolResultType everywhere ... the tool result type can still be `any`. This just fixes runtime errors as we are returning right `type` in the response ### Screenshot Built in and custom esql tools work in agent runtime: <img width="682" height="737" alt="Screenshot 2025-08-06 at 12 13 29" src="https://github.com/user-attachments/assets/9523d82f-58aa-4eab-b653-e8f97f15115e" />
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary - Make esql tools always return `ToolResultType.tabularData` - Use es cli for building esql query - Actually there is a bug with named params, reported here elastic/elasticsearch-specification#5083 What I'm not doing? - Figuring out how to wire ToolResultType everywhere ... the tool result type can still be `any`. This just fixes runtime errors as we are returning right `type` in the response ### Screenshot Built in and custom esql tools work in agent runtime: <img width="682" height="737" alt="Screenshot 2025-08-06 at 12 13 29" src="https://github.com/user-attachments/assets/9523d82f-58aa-4eab-b653-e8f97f15115e" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ToolResultType.tabularDataparamstype elasticsearch-specification#5083What I'm not doing?
any. This just fixes runtime errors as we are returning righttypein the responseScreenshot
Built in and custom esql tools work in agent runtime: