[ES|QL] Construct list of quotable keywords from lexer definition, remove hard-coded list#230730
Merged
vadimkibana merged 1 commit intoelastic:mainfrom Aug 6, 2025
Merged
Conversation
Contributor
Author
|
/ci |
vadimkibana
commented
Aug 6, 2025
| _quotableKeywords = new Set<string>(); | ||
|
|
||
| for (const literalName of esql_lexer.literalNames) { | ||
| // Remove null and empty strings |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| // Remove null and empty strings | |
| // Remove nulls |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
|
vadimkibana
added
review
release_note:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Aug 7, 2025
…move hard-coded list (elastic#230730) ## Summary Retrieves a list of keywords from the lexer instead of maintaining a hard-coded version. I see some "dev mode" keywords are missing in the lexer list (such as `FUSE` command), I am thinking it is because those are behind the "dev mode" flag, and will appear once released. Or, we can append more keywords to the new list, if needed. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
stratoula
added
backport:skip
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…move hard-coded list (elastic#230730) ## Summary Retrieves a list of keywords from the lexer instead of maintaining a hard-coded version. I see some "dev mode" keywords are missing in the lexer list (such as `FUSE` command), I am thinking it is because those are behind the "dev mode" flag, and will appear once released. Or, we can append more keywords to the new list, if needed. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retrieves a list of keywords from the lexer instead of maintaining a hard-coded version.
I see some "dev mode" keywords are missing in the lexer list (such as
FUSEcommand), I am thinking it is because those are behind the "dev mode" flag, and will appear once released. Or, we can append more keywords to the new list, if needed.Checklist