[Synthtrace] Remove fnv-plus dependency#230722
Merged
rmyz merged 7 commits intoelastic:mainfrom Aug 8, 2025
Merged
Conversation
rmyz
added
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Bluefinger
reviewed
Aug 6, 2025
src/platform/packages/shared/kbn-apm-synthtrace-client/src/lib/utils/hash.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I'm turning this into a draft. |
Bluefinger
reviewed
Aug 6, 2025
src/platform/packages/shared/kbn-apm-synthtrace-client/src/lib/utils/hash.ts
Show resolved
Hide resolved
Bluefinger
approved these changes
Aug 6, 2025
Contributor
Bluefinger
left a comment
Bluefinger
left a comment
There was a problem hiding this comment.
Just a minor nit with styling
yngrdyn
approved these changes
Aug 7, 2025
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
cc @rmyz |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 8, 2025
(cherry picked from commit 2a59ab5)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 8, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[Synthtrace] Remove `fnv-plus` dependency (#230722)](#230722) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-08-08T06:44:39Z","message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","synthtrace","Team:obs-ux-infra_services","v9.2.0","dependency-reduction"],"title":"[Synthtrace] Remove `fnv-plus` dependency","number":230722,"url":"https://github.com/elastic/kibana/pull/230722","mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230722","number":230722,"mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
rmyz
added a commit
to rmyz/kibana
that referenced
this pull request
Aug 8, 2025
(cherry picked from commit 2a59ab5) # Conflicts: # package.json
rmyz
added a commit
to rmyz/kibana
that referenced
this pull request
Aug 8, 2025
(cherry picked from commit 2a59ab5) # Conflicts: # package.json
rmyz
added a commit
to rmyz/kibana
that referenced
this pull request
Aug 8, 2025
(cherry picked from commit 2a59ab5) # Conflicts: # package.json # yarn.lock
rmyz
added a commit
to rmyz/kibana
that referenced
this pull request
Aug 8, 2025
(cherry picked from commit 2a59ab5) # Conflicts: # package.json # packages/kbn-apm-synthtrace-client/src/lib/utils/hash.test.ts # renovate.json # yarn.lock
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
rmyz
added a commit
that referenced
this pull request
Aug 8, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Synthtrace] Remove `fnv-plus` dependency (#230722)](#230722) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-08-08T06:44:39Z","message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","synthtrace","Team:obs-ux-infra_services","v9.2.0","v9.1.1","dependency-reduction"],"title":"[Synthtrace] Remove `fnv-plus` dependency","number":230722,"url":"https://github.com/elastic/kibana/pull/230722","mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230722","number":230722,"mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/231068","number":231068,"state":"MERGED","mergeCommit":{"sha":"0f11eb798443c582bc9c3261d7aea72053a2fe78","message":"[9.1] [Synthtrace] Remove `fnv-plus` dependency (#230722) (#231068)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[Synthtrace] Remove `fnv-plus` dependency\n(#230722)](https://github.com/elastic/kibana/pull/230722)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>"}}]}] BACKPORT-->
rmyz
added a commit
that referenced
this pull request
Aug 8, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Synthtrace] Remove `fnv-plus` dependency (#230722)](#230722) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-08-08T06:44:39Z","message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","synthtrace","Team:obs-ux-infra_services","v9.2.0","v9.1.1","dependency-reduction"],"title":"[Synthtrace] Remove `fnv-plus` dependency","number":230722,"url":"https://github.com/elastic/kibana/pull/230722","mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230722","number":230722,"mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/231068","number":231068,"state":"MERGED","mergeCommit":{"sha":"0f11eb798443c582bc9c3261d7aea72053a2fe78","message":"[9.1] [Synthtrace] Remove `fnv-plus` dependency (#230722) (#231068)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[Synthtrace] Remove `fnv-plus` dependency\n(#230722)](https://github.com/elastic/kibana/pull/230722)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>"}}]}] BACKPORT-->
rmyz
added a commit
that referenced
this pull request
Aug 8, 2025
# Backport This will backport the following commits from `main` to `8.17`: - [[Synthtrace] Remove `fnv-plus` dependency (#230722)](#230722) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-08-08T06:44:39Z","message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","synthtrace","Team:obs-ux-infra_services","v9.2.0","v9.1.1","dependency-reduction"],"title":"[Synthtrace] Remove `fnv-plus` dependency","number":230722,"url":"https://github.com/elastic/kibana/pull/230722","mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230722","number":230722,"mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/231068","number":231068,"state":"MERGED","mergeCommit":{"sha":"0f11eb798443c582bc9c3261d7aea72053a2fe78","message":"[9.1] [Synthtrace] Remove `fnv-plus` dependency (#230722) (#231068)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[Synthtrace] Remove `fnv-plus` dependency\n(#230722)](https://github.com/elastic/kibana/pull/230722)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>"}}]}] BACKPORT-->
rmyz
added a commit
that referenced
this pull request
Aug 8, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [[Synthtrace] Remove `fnv-plus` dependency (#230722)](#230722) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-08-08T06:44:39Z","message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","synthtrace","Team:obs-ux-infra_services","v9.2.0","v9.1.1","dependency-reduction"],"title":"[Synthtrace] Remove `fnv-plus` dependency","number":230722,"url":"https://github.com/elastic/kibana/pull/230722","mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230722","number":230722,"mergeCommit":{"message":"[Synthtrace] Remove `fnv-plus` dependency (#230722)","sha":"2a59ab5073882c91582e914fe37d06e22e96dc9e"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/231068","number":231068,"state":"MERGED","mergeCommit":{"sha":"0f11eb798443c582bc9c3261d7aea72053a2fe78","message":"[9.1] [Synthtrace] Remove `fnv-plus` dependency (#230722) (#231068)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[Synthtrace] Remove `fnv-plus` dependency\n(#230722)](https://github.com/elastic/kibana/pull/230722)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>"}}]}] BACKPORT-->
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #230414
This PR removes the
fnv-plusdependency by implementing the algorithm where it's used, so we keep the same output as before.We could use the 'crypto' library for Node, but that would change the output.
Testing
simple_tracesynthtrace scenario to test.Performance
It should be relatively the same as before.
Before
After