Skip to content

[8.17] Remove resize-observer-polyfill (#230297) #230663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Aug 5, 2025
Merged

[8.17] Remove resize-observer-polyfill (#230297) #230663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1260,7 +1260,6 @@
"remark-stringify": "^8.0.3",
"require-in-the-middle": "^7.4.0",
"reselect": "^4.1.8",
"resize-observer-polyfill": "1.5.1",
"rison-node": "1.0.2",
"rxjs": "^7.8.2",
"safe-squel": "^5.12.5",
Expand Down
13 changes: 12 additions & 1 deletion packages/kbn-test/src/jest/setup/polyfills.jsdom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,18 @@ if (!Object.hasOwn(global, 'TextEncoder')) {
global.Blob = require('blob-polyfill').Blob;

if (!Object.hasOwn(global, 'ResizeObserver')) {
global.ResizeObserver = require('resize-observer-polyfill');
global.ResizeObserver = class ResizeObserver {
constructor(callback) {
this.callback = callback;
}
observe(element) {
element.addEventListener('resize', this.callback);
}
unobserve(element) {
element.removeEventListener('resize', this.callback);
}
disconnect() {}
};
}

if (!Object.hasOwn(global, 'Worker')) {
Expand Down
15 changes: 0 additions & 15 deletions src/plugins/kibana_utils/public/resize_checker/resize_checker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@
import { ResizeChecker } from './resize_checker';
import { EventEmitter } from 'events';

// If you want to know why these mocks are created,
// please check: https://github.com/elastic/kibana/pull/44750
jest.mock('resize-observer-polyfill');
import ResizeObserver from 'resize-observer-polyfill';

class MockElement {
public clientWidth: number;
public clientHeight: number;
Expand All @@ -41,16 +36,6 @@ class MockElement {
}
}

(ResizeObserver as any).mockImplementation(function (this: any, callback: any) {
this.observe = function (el: MockElement) {
el.addEventListener('resize', callback);
};
this.disconnect = function () {};
this.unobserve = function (el: MockElement) {
el.removeEventListener('resize', callback);
};
});

describe('Resize Checker', () => {
describe('events', () => {
it('is an event emitter', () => {
Expand Down
1 change: 0 additions & 1 deletion src/plugins/kibana_utils/public/resize_checker/resize_checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import { EventEmitter } from 'events';
import { isEqual } from 'lodash';
import ResizeObserver from 'resize-observer-polyfill';

function getSize(el: HTMLElement): [number, number] {
return [el.clientWidth, el.clientHeight];
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28955,7 +28955,7 @@ reselect@^4.0.0, reselect@^4.1.8:
resolved "https://registry.npmjs.org/reselect/-/reselect-4.1.8.tgz"
integrity sha512-ab9EmR80F/zQTMNeneUr4cv+jSwPJgIlvEmVwLerwrWVbpLlBuls9XHzIeTFy4cegU2NHBp3va0LKOzU5qFEYQ==

resize-observer-polyfill@1.5.1, resize-observer-polyfill@^1.5.1:
resize-observer-polyfill@^1.5.1:
version "1.5.1"
resolved "https://registry.yarnpkg.com/resize-observer-polyfill/-/resize-observer-polyfill-1.5.1.tgz#0e9020dd3d21024458d4ebd27e23e40269810464"
integrity sha512-LwZrotdHOo12nQuZlHEmtuXdqGoOD0OhaxopaNFxWzInpEgaLWoVuAMbTzixuosCx2nEG58ngzW3vxdWoxIgdg==
Expand Down