-
Notifications
You must be signed in to change notification settings - Fork 8.5k
fix: [Observability:Overview page]Modal dialogs, flyouts missing title from announcement #230600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e from announcement Closes: elastic#209997
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
cnasikas
approved these changes
Aug 6, 2025
Contributor
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16774319451 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 6, 2025
…e from announcement (elastic#230600) Closes: elastic#209997 **Description** Dialog modal, flyout visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. **Changes made:** 1. added required aria attributes (cherry picked from commit f4e1769)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 6, 2025
…g title from announcement (#230600) (#230754) # Backport This will backport the following commits from `main` to `9.1`: - [fix: [Observability:Overview page]Modal dialogs, flyouts missing title from announcement (#230600)](#230600) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-08-06T10:25:12Z","message":"fix: [Observability:Overview page]Modal dialogs, flyouts missing title from announcement (#230600)\n\nCloses: #209997\n\n**Description**\nDialog modal, flyout visible title should be announced for the users,\nespecially using assistive technology to know what dialog modal, flyout\nopened.\n\n\n**Changes made:**\n1. added required aria attributes","sha":"f4e17694789a4d3d9e878a2c72c4605f27d07ced","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:prev-minor","v9.2.0"],"title":"fix: [Observability:Overview page]Modal dialogs, flyouts missing title from announcement","number":230600,"url":"https://github.com/elastic/kibana/pull/230600","mergeCommit":{"message":"fix: [Observability:Overview page]Modal dialogs, flyouts missing title from announcement (#230600)\n\nCloses: #209997\n\n**Description**\nDialog modal, flyout visible title should be announced for the users,\nespecially using assistive technology to know what dialog modal, flyout\nopened.\n\n\n**Changes made:**\n1. added required aria attributes","sha":"f4e17694789a4d3d9e878a2c72c4605f27d07ced"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230600","number":230600,"mergeCommit":{"message":"fix: [Observability:Overview page]Modal dialogs, flyouts missing title from announcement (#230600)\n\nCloses: #209997\n\n**Description**\nDialog modal, flyout visible title should be announced for the users,\nespecially using assistive technology to know what dialog modal, flyout\nopened.\n\n\n**Changes made:**\n1. added required aria attributes","sha":"f4e17694789a4d3d9e878a2c72c4605f27d07ced"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Aug 7, 2025
…e from announcement (elastic#230600) Closes: elastic#209997 **Description** Dialog modal, flyout visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. **Changes made:** 1. added required aria attributes
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…e from announcement (elastic#230600) Closes: elastic#209997 **Description** Dialog modal, flyout visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. **Changes made:** 1. added required aria attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Project:Accessibility
release_note:skip
Skip the PR/issue when compiling release notes
v9.1.2
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #209997
Description
Dialog modal, flyout visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened.
Changes made: