Skip to content

Conversation

@alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 5, 2025

Closes: #209997

Description
Dialog modal, flyout visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened.

Changes made:

  1. added required aria attributes

@alexwizp alexwizp marked this pull request as ready for review August 5, 2025 14:33
@alexwizp alexwizp requested a review from a team as a code owner August 5, 2025 14:33
@alexwizp alexwizp added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Aug 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.3MB 1.3MB +51.0B
embeddableAlertsTable 940.9KB 941.0KB +51.0B
ml 5.3MB 5.3MB +51.0B
observability 1.3MB 1.3MB +51.0B
securitySolution 10.3MB 10.3MB +52.0B
triggersActionsUi 1.5MB 1.5MB +51.0B
total +307.0B

@alexwizp alexwizp merged commit f4e1769 into elastic:main Aug 6, 2025
20 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16774319451

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 6, 2025
…e from announcement (elastic#230600)

Closes: elastic#209997

**Description**
Dialog modal, flyout visible title should be announced for the users,
especially using assistive technology to know what dialog modal, flyout
opened.

**Changes made:**
1. added required aria attributes

(cherry picked from commit f4e1769)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 6, 2025
…g title from announcement (#230600) (#230754)

# Backport

This will backport the following commits from `main` to `9.1`:
- [fix: [Observability:Overview page]Modal dialogs, flyouts missing
title from announcement
(#230600)](#230600)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-08-06T10:25:12Z","message":"fix:
[Observability:Overview page]Modal dialogs, flyouts missing title from
announcement (#230600)\n\nCloses: #209997\n\n**Description**\nDialog
modal, flyout visible title should be announced for the
users,\nespecially using assistive technology to know what dialog modal,
flyout\nopened.\n\n\n**Changes made:**\n1. added required aria
attributes","sha":"f4e17694789a4d3d9e878a2c72c4605f27d07ced","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:prev-minor","v9.2.0"],"title":"fix:
[Observability:Overview page]Modal dialogs, flyouts missing title from
announcement","number":230600,"url":"https://github.com/elastic/kibana/pull/230600","mergeCommit":{"message":"fix:
[Observability:Overview page]Modal dialogs, flyouts missing title from
announcement (#230600)\n\nCloses: #209997\n\n**Description**\nDialog
modal, flyout visible title should be announced for the
users,\nespecially using assistive technology to know what dialog modal,
flyout\nopened.\n\n\n**Changes made:**\n1. added required aria
attributes","sha":"f4e17694789a4d3d9e878a2c72c4605f27d07ced"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230600","number":230600,"mergeCommit":{"message":"fix:
[Observability:Overview page]Modal dialogs, flyouts missing title from
announcement (#230600)\n\nCloses: #209997\n\n**Description**\nDialog
modal, flyout visible title should be announced for the
users,\nespecially using assistive technology to know what dialog modal,
flyout\nopened.\n\n\n**Changes made:**\n1. added required aria
attributes","sha":"f4e17694789a4d3d9e878a2c72c4605f27d07ced"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Aug 7, 2025
…e from announcement (elastic#230600)

Closes: elastic#209997

**Description**
Dialog modal, flyout visible title should be announced for the users,
especially using assistive technology to know what dialog modal, flyout
opened.


**Changes made:**
1. added required aria attributes
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
@mistic mistic added v9.1.2 and removed v9.1.1 labels Aug 7, 2025
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
…e from announcement (elastic#230600)

Closes: elastic#209997

**Description**
Dialog modal, flyout visible title should be announced for the users,
especially using assistive technology to know what dialog modal, flyout
opened.


**Changes made:**
1. added required aria attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v9.1.2 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Observability:Overview page]Modal dialogs, flyouts missing title from announcement

5 participants