[Security solutions][Intelligence] Upgrade ioc flyout #230593

NicholasPeretti · 2025-08-05T14:00:19Z

Summary

Fixes #189870.

Upgrading intelligence flyout look-and-feel to be more like the alert's flyout.

Screenshots

…no-cache --fix'

...public/threat_intelligence/modules/indicators/components/flyout/highlighted_values_table.tsx

...ty_solution/public/threat_intelligence/modules/indicators/components/flyout/fields_table.tsx

...curity_solution/public/threat_intelligence/modules/indicators/components/flyout/json_tab.tsx

PhilippeOberti

Thanks for making the changes for the JsonTab. I really like having that component now shared, it looks clean!

I left a few more minor comments, let me know if you want to discuss any of them!

...ns/security/plugins/security_solution/public/flyout/document_details/right/tabs/json_tab.tsx

...utions/security/plugins/security_solution/public/flyout/document_details/shared/json_tab.tsx

...lutions/security/plugins/security_solution/public/flyout/document_details/shared/test_ids.ts

...public/threat_intelligence/modules/indicators/components/flyout/highlighted_values_table.tsx

...curity_solution/public/threat_intelligence/modules/indicators/components/flyout/json_tab.tsx

...ns/security/plugins/security_solution/public/flyout/document_details/right/tabs/json_tab.tsx

...utions/security/plugins/security_solution/public/flyout/document_details/shared/json_tab.tsx

PhilippeOberti

A few more very minor comments, this is super close!

.../security_solution/public/threat_intelligence/modules/indicators/components/flyout/block.tsx

...ecurity_solution/public/threat_intelligence/modules/indicators/components/flyout/test_ids.ts

x-pack/solutions/security/plugins/security_solution/public/flyout/shared/json_tab.tsx

...utions/security/plugins/security_solution/public/flyout/document_details/shared/json_tab.tsx

...ecurity_solution/public/flyout/entity_details/user_details_left/tabs/asset_document.test.tsx

PhilippeOberti

Thanks for this nice improvement! Code LGTM and desk tested.

Before merging though, you need to:

fix the translations issues: just run node scripts/i18n_check --fix locally then push the changes. This will fix your CI Quick Checks errors.
fix 2 wrong paths (I commented the correct ones) and remove the VisibleOnHover code that is now unused. This will fix your CI Linting and Checks Types errors (I made the changes locally and ran node scripts/type_check.js --project x-pack/solutions/security/plugins/security_solution/tsconfig.json with no errors).
add the proper labels: Team:Threat Hunting:Investigations, backport:skip, release_note:enhancement and v9.2.0 should be good.

We might want to let @natasha-moore-elastic about this change. It does not seem to me that it would be worth doing a doc update, but she will know more about it.

Also, if you have time (not mandatory) it'd be nice to update the screenshots in the PR description to reflect the latest changes.

I reached out to the @elastic/security-entity-analytics team for review :)

...y_solution/public/threat_intelligence/modules/indicators/components/flyout/json_tab.test.tsx

...curity/plugins/security_solution/public/flyout/document_details/right/tabs/json_tab.test.tsx

.../security_solution/public/threat_intelligence/modules/indicators/components/flyout/block.tsx

elasticmachine · 2025-08-29T11:23:29Z

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

elasticmachine · 2025-09-22T18:33:10Z

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #78 / cases security and spaces enabled: trial Common migrations migrations 7.11.1 -> latest stack version "before all" hook for "adds rule info to only alert comments for 7.12"
[job] [logs] FTR Configs #73 / ESQL execution logic API @ess @serverless ES|QL rule type max alerts identical document ids across multiple indices should generate alerts over multiple pages from different indices but same event id for mv_expand when number alerts exceeds max signal

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	8027	8026	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	10.5MB	10.5MB	-8.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	97.1KB	97.2KB	+64.0B

Unknown metric groups

async chunk count

id	before	after	diff
`securitySolution`	103	104	+1

History

💔 Build #341901 failed e114a5d
💚 Build #340994 succeeded fcccfc9
💔 Build #340400 failed 2093bba
💔 Build #339982 failed 279cb0a
💔 Build #337012 failed 204cfde

cc @NicholasPeretti

kibanamachine · 2025-09-23T09:33:28Z

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/17941727877

kibanamachine · 2025-09-23T09:40:25Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts You might need to backport the following PRs to 8.19: - [Security Solution] [SKA] Moved cypress folder (#230198)
❌	9.1	Backport failed because of merge conflicts You might need to backport the following PRs to 9.1: - [Security Solution] [SKA] Moved cypress folder (#230198)

Manual backport

To create the backport manually run:

node scripts/backport --pr 230593

Questions ?

Please refer to the Backport tool documentation

## Summary Fixes elastic#189870. Upgrading intelligence flyout look-and-feel to be more like the alert's flyout. ## Screenshots <img width="1282" height="1222" alt="Screenshot 2025-08-29 at 12 19 51" src="https://github.com/user-attachments/assets/6b9825ae-32a5-4dc7-9133-94c0cac770e2" /> <img width="1281" height="1222" alt="Screenshot 2025-08-29 at 12 20 05" src="https://github.com/user-attachments/assets/4196e583-2d70-429b-9f83-655cd67cf00a" /> <img width="1281" height="1222" alt="Screenshot 2025-08-29 at 12 20 16" src="https://github.com/user-attachments/assets/7fd7949d-1317-4437-919b-bdbe9585b750" /> --------- Co-authored-by: kibanamachine <[email protected]>

kibanamachine · 2025-09-25T09:48:42Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 230593 locally
cc: @NicholasPeretti

## Summary Fixes #189870. Upgrading intelligence flyout look-and-feel to be more like the alert's flyout. ## Screenshots <img width="1282" height="1222" alt="Screenshot 2025-08-29 at 12 19 51" src="https://github.com/user-attachments/assets/6b9825ae-32a5-4dc7-9133-94c0cac770e2" /> <img width="1281" height="1222" alt="Screenshot 2025-08-29 at 12 20 05" src="https://github.com/user-attachments/assets/4196e583-2d70-429b-9f83-655cd67cf00a" /> <img width="1281" height="1222" alt="Screenshot 2025-08-29 at 12 20 16" src="https://github.com/user-attachments/assets/7fd7949d-1317-4437-919b-bdbe9585b750" /> --------- Co-authored-by: kibanamachine <[email protected]>

## Summary Fixes elastic#189870. Upgrading intelligence flyout look-and-feel to be more like the alert's flyout. ## Screenshots <img width="1282" height="1222" alt="Screenshot 2025-08-29 at 12 19 51" src="https://github.com/user-attachments/assets/6b9825ae-32a5-4dc7-9133-94c0cac770e2" /> <img width="1281" height="1222" alt="Screenshot 2025-08-29 at 12 20 05" src="https://github.com/user-attachments/assets/4196e583-2d70-429b-9f83-655cd67cf00a" /> <img width="1281" height="1222" alt="Screenshot 2025-08-29 at 12 20 16" src="https://github.com/user-attachments/assets/7fd7949d-1317-4437-919b-bdbe9585b750" /> --------- Co-authored-by: kibanamachine <[email protected]>

NicholasPeretti added 3 commits August 1, 2025 16:55

Compress highlights table

178b865

Improve flyout table

d2fc70f

Update json view

c2bce15

NicholasPeretti requested a review from a team as a code owner August 5, 2025 14:00

[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…

25e0b66

…no-cache --fix'

PhilippeOberti requested changes Aug 15, 2025

View reviewed changes

NicholasPeretti added 2 commits August 18, 2025 14:21

Move options from useMemo to module's scope

968acdf

Remove IndicatorValueActions

68849ff

NicholasPeretti self-assigned this Aug 19, 2025

Refactor JsonTab to be reusable

0e4b7d7

NicholasPeretti requested a review from a team as a code owner August 19, 2025 14:04

NicholasPeretti requested a review from CAWilson94 August 19, 2025 14:04

NicholasPeretti added 2 commits August 19, 2025 15:06

Merge branch 'main' into 189870-convert-ioc-flyout

504ed3f

Merge branch 'main' into 189870-convert-ioc-flyout

57c0bca

PhilippeOberti requested changes Aug 21, 2025

View reviewed changes

Apply PR feedback

18fef14

PhilippeOberti reviewed Aug 27, 2025

View reviewed changes

Apply PR feedback

20e3102

PhilippeOberti approved these changes Aug 28, 2025

View reviewed changes

hop-dev approved these changes Aug 28, 2025

View reviewed changes

NicholasPeretti added 3 commits August 29, 2025 11:34

Merge branch 'main' into 189870-convert-ioc-flyout

7d4816c

Applh PR feedback

e0e0a4f

Merge branch 'main' into 189870-convert-ioc-flyout

4e673df

NicholasPeretti added 7 commits September 2, 2025 09:53

Merge branch 'main' into 189870-convert-ioc-flyout

0cd76a9

Fix translations

ff711a5

Merge branch 'main' into 189870-convert-ioc-flyout

56cd64f

Fix unit tests

22e7f2f

Fix cypress tests

d6f51e4

Merge branch 'main' into 189870-convert-ioc-flyout

e819899

Fix cypress tests

204cfde

CAWilson94 approved these changes Sep 9, 2025

View reviewed changes

NicholasPeretti added 6 commits September 16, 2025 16:54

Merge branch 'main' into 189870-convert-ioc-flyout

279cb0a

Fix CI

2093bba

Fix Cypress tests

d51f056

Merge branch 'main' into 189870-convert-ioc-flyout

fcccfc9

Merge branch 'main' into 189870-convert-ioc-flyout

e114a5d

Merge branch 'main' into 189870-convert-ioc-flyout

a9d27f4

NicholasPeretti merged commit d4656bb into elastic:main Sep 23, 2025
13 checks passed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 25, 2025

PhilippeOberti added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Sep 25, 2025

PhilippeOberti mentioned this pull request Nov 7, 2025

[Security Solution][Attacks/Alerts][Attack flyout] JSON tab content #242330

Open

[Security solutions][Intelligence] Upgrade ioc flyout #230593

[Security solutions][Intelligence] Upgrade ioc flyout #230593

Uh oh!

Conversation

NicholasPeretti commented Aug 5, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PhilippeOberti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PhilippeOberti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PhilippeOberti left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Aug 29, 2025

Uh oh!

elasticmachine commented Sep 22, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

Uh oh!

Uh oh!

kibanamachine commented Sep 23, 2025

Uh oh!

kibanamachine commented Sep 23, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Sep 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NicholasPeretti commented Aug 5, 2025 •

edited by kibanamachine

Loading

PhilippeOberti left a comment •

edited

Loading