[ES|QL] fix: completion column unknown validation#230589
Merged
sddonne merged 1 commit intoelastic:mainfrom Aug 6, 2025
Merged
[ES|QL] fix: completion column unknown validation#230589sddonne merged 1 commit intoelastic:mainfrom
sddonne merged 1 commit intoelastic:mainfrom
Conversation
sddonne
added
release_note:skip
sddonne
commented
Aug 5, 2025
| }); | ||
|
|
||
| describe('a custom targetField is provided', () => { | ||
| it('targetField is not available before COMPLETION', () => { |
Contributor
Author
There was a problem hiding this comment.
This can't be tested here now, as the general validation routine is still in validation-autocomplete package.
Contributor
There was a problem hiding this comment.
So this test used to run and stopped working due to this change? 🤔
Contributor
Author
There was a problem hiding this comment.
It made sense when the validation routine was run from validation-autocomplete, now it was passing by chance, because we were checking the unknown columns before pushing the new one.
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
reviewed
Aug 5, 2025
| }, | ||
| ]); | ||
|
|
||
| messages.push(...validateCommandArguments(command, ast, context, callbacks)); |
Contributor
There was a problem hiding this comment.
This fix makes sense yes 👍
stratoula
added
backport:version
stratoula
approved these changes
Aug 5, 2025
stratoula
added
backport:skip
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary Problem: When the completion command was using a target column, the column was marked as unknown. <img width="1636" height="454" alt="image" src="https://github.com/user-attachments/assets/f39bdf32-80df-4922-a63d-c2631cfcb82b" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem: When the completion command was using a target column, the column was marked as unknown.