fix: [ML] Anomaly Detection: Supplied configurations flyout missing title from announcement #230578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itle from announcement Closes: elastic#217136
alexwizp
added
Project:Accessibility
release_note:skip
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
| ownFocus | ||
| onClose={onClose} | ||
| aria-labelledby={'supplied-configurations-flyout'} | ||
| aria-labelledby={flyoutTitleId} |
Contributor
There was a problem hiding this comment.
I confirmed that the dialog title is now being set in the Accessibility Tree View in Chrome Dev tools.
But just to confirm, are we expecting the title to be read out in MacOS VoiceOver, as it just reads out the generic 'You are in a modal dialog' currently? I think I checked this before, and believe it might be a limitation of VoiceOver? Could you confirm the expected behavior here please @alexwizp
Contributor
Author
There was a problem hiding this comment.
@peteharverson That's correct — VoiceOver doesn't announce the dialog name, unlike NVDA, which does. As a quick workaround, you can check the accessibility tree in Chrome to ensure the dialog is properly named."
Contributor
There was a problem hiding this comment.
Thanks for the clarification @alexwizp . That's what I suspected. All looks good in the accessibility tree.
Contributor
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16754085219 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 5, 2025
…itle from announcement (elastic#230578) Closes: elastic#217136 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made:** 1. Aria attributes were fixed for `Supplied configurations flyout` **Screen:** <img width="1356" height="657" alt="image" src="https://github.com/user-attachments/assets/f7fe5c30-5086-4538-ade0-c73a7d597cdd" /> (cherry picked from commit a925155)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 5, 2025
…sing title from announcement (#230578) (#230613) # Backport This will backport the following commits from `main` to `9.1`: - [fix: [ML] Anomaly Detection: Supplied configurations flyout missing title from announcement (#230578)](#230578) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-08-05T15:10:51Z","message":"fix: [ML] Anomaly Detection: Supplied configurations flyout missing title from announcement (#230578)\n\nCloses: #217136\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Aria attributes were fixed for `Supplied configurations flyout`\n\n**Screen:**\n\n<img width=\"1356\" height=\"657\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f7fe5c30-5086-4538-ade0-c73a7d597cdd\"\n/>","sha":"a9251556d549244fb974c92f9ce240da0ff4724c","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:prev-minor","v9.2.0"],"title":"fix: [ML] Anomaly Detection: Supplied configurations flyout missing title from announcement","number":230578,"url":"https://github.com/elastic/kibana/pull/230578","mergeCommit":{"message":"fix: [ML] Anomaly Detection: Supplied configurations flyout missing title from announcement (#230578)\n\nCloses: #217136\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Aria attributes were fixed for `Supplied configurations flyout`\n\n**Screen:**\n\n<img width=\"1356\" height=\"657\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f7fe5c30-5086-4538-ade0-c73a7d597cdd\"\n/>","sha":"a9251556d549244fb974c92f9ce240da0ff4724c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230578","number":230578,"mergeCommit":{"message":"fix: [ML] Anomaly Detection: Supplied configurations flyout missing title from announcement (#230578)\n\nCloses: #217136\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Aria attributes were fixed for `Supplied configurations flyout`\n\n**Screen:**\n\n<img width=\"1356\" height=\"657\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f7fe5c30-5086-4538-ade0-c73a7d597cdd\"\n/>","sha":"a9251556d549244fb974c92f9ce240da0ff4724c"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
…itle from announcement (elastic#230578) Closes: elastic#217136 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made:** 1. Aria attributes were fixed for `Supplied configurations flyout` **Screen:** <img width="1356" height="657" alt="image" src="https://github.com/user-attachments/assets/f7fe5c30-5086-4538-ade0-c73a7d597cdd" />
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…itle from announcement (elastic#230578) Closes: elastic#217136 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made:** 1. Aria attributes were fixed for `Supplied configurations flyout` **Screen:** <img width="1356" height="657" alt="image" src="https://github.com/user-attachments/assets/f7fe5c30-5086-4538-ade0-c73a7d597cdd" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #217136
Description
Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it.
Changes made:
Supplied configurations flyoutScreen: