tests: add unit tests for DAG builder#230531
Merged
skynetigor merged 30 commits intoelastic:mainfrom Aug 6, 2025
Merged
Conversation
…tially updaiting it
…ow Execution Repositories
…itionBranchNodeImpl, and ExitIfNodeImpl
…onBranchNodeImpl - Added validation to ensure EnterIfNodeImpl only has 'enter-condition-branch' successors. - Implemented error handling in ExitConditionBranchNodeImpl to check for 'exit-if' successor type. - Updated tests to cover new validation scenarios for both node implementations.
…stency across step implementations
…n to use the correct schema
…into 13412-Add-unit-tests-for-DAG-builder
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the DAG builder component, which converts workflow steps into executable graphs. The changes primarily focus on testing the conversion logic for conditional (If) and loop (Foreach) steps, along with atomic steps.
- Add unit tests for converting atomic, If condition, and Foreach steps into DAG structures
- Refactor the DAG building logic to properly handle atomic steps with a new
AtomicGraphNodetype - Update function signatures to accept
WorkflowSchemainstead ofWorkflowExecutionEngineModel
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
build_execution_graph.test.ts |
Comprehensive test suite covering atomic, if, foreach, and complex workflow scenarios |
build_execution_graph.ts |
Refactored to support atomic step nodes and improved step visiting logic |
workflow_task_runner.ts |
Updated to pass workflow.definition.workflow to graph converter |
scheduler_service.ts |
Updated to pass workflow.definition.workflow to graph converter |
step_factory.ts |
Added support for atomic step implementation and removed fallback to connector step |
atomic_step_impl.ts |
New implementation for atomic workflow steps |
base.ts |
Added AtomicGraphNode schema and type definitions |
| Various type files | Updated exports to include new AtomicGraphNode type |
...lugins/shared/workflows_management/common/lib/build_execution_graph/build_execution_graph.ts
Outdated
Show resolved
Hide resolved
...lugins/shared/workflows_management/common/lib/build_execution_graph/build_execution_graph.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
|
Kiryous
reviewed
Aug 6, 2025
...lugins/shared/workflows_management/common/lib/build_execution_graph/build_execution_graph.ts
Show resolved
Hide resolved
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Aug 7, 2025
## Summary - Introduce AtomicGraphNode - Add unit-tests for converting If condition step into DAG - Add unit-tests for converting Foreach step into DAG - Tests for other steps have to be done in along with step implementation ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary - Introduce AtomicGraphNode - Add unit-tests for converting If condition step into DAG - Add unit-tests for converting Foreach step into DAG - Tests for other steps have to be done in along with step implementation ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes: #13412
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.