[ES|QL] Add observability tier check for commands #230500

bartoval · 2025-08-05T07:40:11Z

Summary

This PR is part of #216791

add observability tier check for commands

example:

use kibana in local ( Editor does not show CHANGE POINT suggestion)

yarn start and yarn es snapshot --license trial

use kibana servless oblt( Editor not show CHANGE POINT suggestion)

yarn serverless-oblt and yarn es serverless --projectType oblt

bartoval · 2025-08-05T07:44:19Z

I used the serverless observability mode, but I had to manually configure several components like Elastic permissions for docker and add data sources using Minikube or RabbitMQ. Is this setup the intended workflow for a manual test?

elasticmachine · 2025-08-05T07:44:54Z

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula

This looks nice, some comments about the types duplication mostly

stratoula · 2025-08-05T07:43:08Z

src/platform/packages/shared/kbn-esql-types/src/active_product_observability.ts

+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+export interface PricingProductSecurity {


Why don't you import them from here rather than redeclaring them? src/core/packages/pricing/common/src/types.ts

This is the same case we did for the license types to avoid installing new packages in tsconfig.json. We decided to redeclare types

https://github.com/elastic/kibana/pull/228271/files#diff-e332a859d109cdcc17457351d2dfd2ce09a69d0946325a0206bc90ed329832ce

This is similar to
https://github.com/elastic/kibana/pull/229961/files/6ba0e379ba0da1c2e62b0608786bd1e00ab1e115#diff-5f3c3aaf7470bb918f9d6a76c64d0b76225022f247300d2771e0e22513bdd024

For the autocomplete package it makes sense to import from pricing (which is a small package) rather the other way around

Also the other case was in the scripts, here is actual code, these types should not belong at the esql-types package.

stratoula · 2025-08-05T07:43:25Z

src/platform/packages/shared/kbn-esql-types/src/active_product_observability.ts

+  product_lines: Array<'ai_soc' | 'endpoint' | 'cloud'>;
+}
+
+export interface PricingProductObservability {


see comment above

stratoula · 2025-08-05T07:43:45Z

src/platform/packages/shared/kbn-esql-types/src/active_product_observability.ts

+  tier: 'complete' | 'logs_essentials';
+}
+
+export type PricingProduct = PricingProductSecurity | PricingProductObservability;


see comment above

stratoula · 2025-08-05T07:47:36Z

src/platform/packages/shared/kbn-esql-types/index.ts


 export type { ESQLLicenseType, ESQLSignatureLicenseType, ESQLLicenseResult } from './src/license';

+export type {


No these do not belong here, they are already declared in the pricing package so we have to import them from there

see comment above

stratoula

Awesome! LGTM! Functions in a separate PR right Valerio?

bartoval · 2025-08-05T14:16:21Z

Awesome! LGTM! Functions in a separate PR right Valerio?

yes at this point I continue to separate function and command PRs, even if the changes are minimal (there are no tiers on signature)

stratoula · 2025-08-05T14:17:53Z

Makes sense!

elasticmachine · 2025-08-05T14:49:56Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 359050d

Failed CI Steps

FTR Configs #46

Test Failures

[job] [logs] FTR Configs #46 / Journey[cloud_security_dashboard] "before all" hook for "Go to cloud security dashboards Page"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/esql-validation-autocomplete`	33	34	+1
`@kbn/monaco`	192	193	+1
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`esql`	260.6KB	260.7KB	+51.0B
`onechat`	707.6KB	707.6KB	+20.0B
total			+71.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-srcJs`	3.8MB	3.8MB	+262.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/esql-validation-autocomplete`	34	35	+1
`@kbn/monaco`	192	193	+1
total			+2

References to deprecated APIs

id	before	after	diff
`@kbn/esql-editor`	0	3	+3

cc @bartoval

## Summary This PR is part of elastic#216791 add observability tier check for commands example: 1) use kibana in local ( Editor does not show CHANGE POINT suggestion) `yarn start` and `yarn es snapshot --license trial ` <img width="1663" height="418" alt="4" src="https://github.com/user-attachments/assets/f13dc0bb-685e-4a46-8f65-3735424bea1f" /> 2) use kibana servless oblt( Editor not show CHANGE POINT suggestion) `yarn serverless-oblt` and `yarn es serverless --projectType oblt` <img width="1591" height="538" alt="3" src="https://github.com/user-attachments/assets/64e59e9d-c98b-412d-8980-5e4e56dc11ad" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

bartoval self-assigned this Aug 5, 2025

bartoval requested a review from a team as a code owner August 5, 2025 07:40

bartoval added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.2.0 labels Aug 5, 2025

stratoula reviewed Aug 5, 2025

View reviewed changes

bartoval mentioned this pull request Aug 5, 2025

[ES|QL] Check the license + tier and suggest based on it #216791

Closed

9 tasks

bartoval added 2 commits August 5, 2025 14:58

feat: add observability tier check for commands

4604a2d

refactor: resolve PR comments

fbe9339

bartoval force-pushed the esql_add_observability_tier_check branch from a3a9448 to fbe9339 Compare August 5, 2025 12:58

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

359050d

bartoval requested a review from stratoula August 5, 2025 13:20

stratoula approved these changes Aug 5, 2025

View reviewed changes

bartoval merged commit da36805 into elastic:main Aug 5, 2025
12 checks passed

wildemat mentioned this pull request Aug 7, 2025

pr 230826 #231022

Closed

10 tasks

bartoval deleted the esql_add_observability_tier_check branch November 6, 2025 21:04


		export type { ESQLLicenseType, ESQLSignatureLicenseType, ESQLLicenseResult } from './src/license';

		export type {

[ES|QL] Add observability tier check for commands #230500

[ES|QL] Add observability tier check for commands #230500

Uh oh!

Conversation

bartoval commented Aug 5, 2025

Summary

Uh oh!

bartoval commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Aug 5, 2025

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bartoval Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bartoval Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

bartoval commented Aug 5, 2025

Uh oh!

stratoula commented Aug 5, 2025

Uh oh!

elasticmachine commented Aug 5, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

References to deprecated APIs

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bartoval commented Aug 5, 2025 •

edited

Loading

bartoval Aug 5, 2025 •

edited

Loading

bartoval Aug 5, 2025 •

edited

Loading