Skip to content

[Drilldowns] Fix date math plus sign encoding#230469

Merged
kowalczyk-krzysztof merged 1 commit intoelastic:mainfrom
kowalczyk-krzysztof:fix/plus-sign-encoding
Aug 5, 2025
Merged

[Drilldowns] Fix date math plus sign encoding#230469
kowalczyk-krzysztof merged 1 commit intoelastic:mainfrom
kowalczyk-krzysztof:fix/plus-sign-encoding

Conversation

@kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Aug 4, 2025

Summary

This PR fixes an issue with + not being properly encoded when it's part of a date math expression.
Closes: #225044

@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Aug 4, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner August 4, 2025 19:39
@kowalczyk-krzysztof kowalczyk-krzysztof added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Feature:Drilldowns Embeddable panel Drilldowns Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// backport:all-open Backport to all branches that could still receive a release labels Aug 4, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uiActionsEnhanced 17.9KB 18.0KB +49.0B

cc @kowalczyk-krzysztof

@Dosant
Copy link
Contributor

Dosant commented Aug 5, 2025

release_note: fix ?

@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Aug 5, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 7104b6f into elastic:main Aug 5, 2025
28 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16744918953

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 5, 2025
## Summary

This PR fixes an issue with `+` not being properly encoded when it's
part of a date math expression.
Closes: elastic#225044

(cherry picked from commit 7104b6f)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 5, 2025
## Summary

This PR fixes an issue with `+` not being properly encoded when it's
part of a date math expression.
Closes: elastic#225044

(cherry picked from commit 7104b6f)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 5, 2025
## Summary

This PR fixes an issue with `+` not being properly encoded when it's
part of a date math expression.
Closes: elastic#225044

(cherry picked from commit 7104b6f)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 5, 2025
## Summary

This PR fixes an issue with `+` not being properly encoded when it's
part of a date math expression.
Closes: elastic#225044

(cherry picked from commit 7104b6f)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 5, 2025
## Summary

This PR fixes an issue with `+` not being properly encoded when it's
part of a date math expression.
Closes: elastic#225044

(cherry picked from commit 7104b6f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.18
8.19
9.0
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 5, 2025
# Backport

This will backport the following commits from `main` to `9.1`:
- [[Drilldowns] Fix date math plus sign encoding
(#230469)](#230469)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-08-05T08:33:31Z","message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Drilldowns","Team:SharedUX","backport:all-open","v9.2.0"],"title":"[Drilldowns]
Fix date math plus sign
encoding","number":230469,"url":"https://github.com/elastic/kibana/pull/230469","mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230469","number":230469,"mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 5, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[Drilldowns] Fix date math plus sign encoding
(#230469)](#230469)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-08-05T08:33:31Z","message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Drilldowns","Team:SharedUX","backport:all-open","v9.2.0"],"title":"[Drilldowns]
Fix date math plus sign
encoding","number":230469,"url":"https://github.com/elastic/kibana/pull/230469","mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230469","number":230469,"mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 5, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [[Drilldowns] Fix date math plus sign encoding
(#230469)](#230469)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-08-05T08:33:31Z","message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Drilldowns","Team:SharedUX","backport:all-open","v9.2.0"],"title":"[Drilldowns]
Fix date math plus sign
encoding","number":230469,"url":"https://github.com/elastic/kibana/pull/230469","mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230469","number":230469,"mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 5, 2025
# Backport

This will backport the following commits from `main` to `8.17`:
- [[Drilldowns] Fix date math plus sign encoding
(#230469)](#230469)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-08-05T08:33:31Z","message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Drilldowns","Team:SharedUX","backport:all-open","v9.2.0"],"title":"[Drilldowns]
Fix date math plus sign
encoding","number":230469,"url":"https://github.com/elastic/kibana/pull/230469","mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230469","number":230469,"mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 5, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [[Drilldowns] Fix date math plus sign encoding
(#230469)](#230469)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-08-05T08:33:31Z","message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Drilldowns","Team:SharedUX","backport:all-open","v9.2.0"],"title":"[Drilldowns]
Fix date math plus sign
encoding","number":230469,"url":"https://github.com/elastic/kibana/pull/230469","mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230469","number":230469,"mergeCommit":{"message":"[Drilldowns]
Fix date math plus sign encoding (#230469)\n\n## Summary\n\nThis PR
fixes an issue with `+` not being properly encoded when it's\npart of a
date math expression.\nCloses:
#225044","sha":"7104b6f979f8665c5b188b747ce1f3d343ffe0c4"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
## Summary

This PR fixes an issue with `+` not being properly encoded when it's
part of a date math expression.
Closes: elastic#225044
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
## Summary

This PR fixes an issue with `+` not being properly encoded when it's
part of a date math expression.
Closes: elastic#225044
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the fix/plus-sign-encoding branch August 31, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release bug Fixes for quality problems that affect the customer experience Feature:Drilldowns Embeddable panel Drilldowns release_note:fix Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.17.10 v8.18.5 v8.19.2 v9.0.5 v9.1.2 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kibana Drilldown: "Go to URL" using "Encode URL" doesn't encode plus sign (+)

5 participants