Skip to content

[9.1] [Dashboard] Remove unncessary promises (#230313) #230467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Aug 4, 2025
Merged

[9.1] [Dashboard] Remove unncessary promises (#230313) #230467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/platform/plugins/shared/dashboard/server/content_management/dashboard_storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,20 +426,18 @@ export class DashboardStorage {
const soQuery = searchArgsToSOFindOptions(query, optionsToLatest);
// Execute the query in the DB
const soResponse = await soClient.find<DashboardSavedObjectAttributes>(soQuery);
const hits = await Promise.all(
soResponse.saved_objects
.map(async (so) => {
const { item } = savedObjectToItem(so, false, {
allowedAttributes: soQuery.fields,
allowedReferences: optionsToLatest?.includeReferences,
getTagNamesFromReferences: (references: SavedObjectReference[]) =>
this.getTagNamesFromReferences(references, allTags),
});
return item;
})
// Ignore any saved objects that failed to convert to items.
.filter((item) => item !== null)
);
const hits = soResponse.saved_objects
.map((so) => {
const { item } = savedObjectToItem(so, false, {
allowedAttributes: soQuery.fields,
allowedReferences: optionsToLatest?.includeReferences,
getTagNamesFromReferences: (references: SavedObjectReference[]) =>
this.getTagNamesFromReferences(references, allTags),
});
return item;
})
// Ignore any saved objects that failed to convert to items.
.filter((item) => item !== null);
const response = {
hits,
pagination: {
Expand Down