Skip to content

[AI Assistant] The last system prompt was deleted successfully but remained in the list until page refreshed #230450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angorayc merged 4 commits into from
Aug 6, 2025
Merged

[AI Assistant] The last system prompt was deleted successfully but remained in the list until page refreshed #230450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b5bc99
fix deleting system prompt
angorayc Aug 4, 2025
1aa1bbf
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine Aug 4, 2025
e2e6750
lint
angorayc Aug 5, 2025
48833fb
Merge branch 'issue-230376' of github.com:angorayc/kibana into issue-…
angorayc Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...assistant/impl/assistant/common/components/assistant_settings_management/badges/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/

import { EuiBadge } from '@elastic/eui';
import { css } from '@emotion/react';
import React from 'react';

export const BadgesColumn: React.FC<{
Expand All @@ -16,7 +17,13 @@ export const BadgesColumn: React.FC<{
items && items.length > 0 ? (
<div>
{items.map((title, idx) => (
<EuiBadge key={`${prefix}-${idx}`} color={color}>
<EuiBadge
key={`${prefix}-${idx}`}
color={color}
css={css`
max-width: 400px;
`}
>
{title}
</EuiBadge>
))}
Expand Down
1 change: 1 addition & 0 deletions ...prompt_editor/system_prompt/system_prompt_settings_management/use_system_prompt_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export const useSystemPromptTable = () => {
render: ({ conversations, id }: SystemPromptSettings) => (
<BadgesColumn items={conversations.map(({ title }) => title)} prefix={id} />
),
width: '50%',
},
{
align: 'left',
Expand Down
23 changes: 12 additions & 11 deletions ...astic-assistant/impl/assistant/settings/use_settings_updater/use_system_prompt_updater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ interface SystemPromptUpdater {
selectedSystemPrompt?: SystemPromptSettings;
systemPromptSettings: SystemPromptSettings[];
}

const DEFAULT_SYSTEM_PROMPT_SETTINGS: SystemPromptSettings[] = [];
const DEFAULT_SYSTEM_PROMPT_SETTINGS_UPDATES: SystemPromptSettings[] = [];
const DEFAULT_PROMPTS_BULK_ACTIONS: PromptsPerformBulkActionRequestBody = {};

export const useSystemPromptUpdater = ({
allPrompts,
connectors,
Expand All @@ -71,13 +76,15 @@ export const useSystemPromptUpdater = ({
toasts,
}: Params): SystemPromptUpdater => {
// server equivalent
const [systemPromptSettings, setSystemPromptSettings] = useState<SystemPromptSettings[]>([]);
const [systemPromptSettings, setSystemPromptSettings] = useState<SystemPromptSettings[]>(
DEFAULT_SYSTEM_PROMPT_SETTINGS
);
// local updates
const [systemPromptSettingsUpdates, setSystemPromptSettingsUpdates] = useState<
SystemPromptSettings[]
>([]);
>(DEFAULT_SYSTEM_PROMPT_SETTINGS_UPDATES);
const [promptsBulkActions, setPromptsBulkActions] = useState<PromptsPerformBulkActionRequestBody>(
{}
DEFAULT_PROMPTS_BULK_ACTIONS
);
// System Prompt Selection State
const [selectedSystemPrompt, setSelectedSystemPrompt] = useState<
Expand Down Expand Up @@ -105,7 +112,6 @@ export const useSystemPromptUpdater = ({
filter,
});
useEffect(() => {
if (!Object.keys(data).length && !systemPrompts.length) return;
const updateSystemPromptSettings = (prev: SystemPromptSettings[]) => {
const updatedSettings = systemPrompts.map((p) => {
const conversations = Object.values(data).filter(
Expand All @@ -121,15 +127,10 @@ export const useSystemPromptUpdater = ({
return prev;
};

setSystemPromptSettings(updateSystemPromptSettings);
setSystemPromptSettings((prev) => updateSystemPromptSettings(prev));
setSystemPromptSettingsUpdates((prev) => updateSystemPromptSettings(prev));
}, [data, systemPrompts]);

useEffect(() => {
if (systemPromptSettings.length) {
setSystemPromptSettingsUpdates(systemPromptSettings);
}
}, [systemPromptSettings]);

const onSystemPromptSelect = useCallback(
(systemPrompt?: SystemPromptSettings | string) => {
if (systemPrompt == null) {
Expand Down